Version: 1905211840370
Baseline: 1905140117570
- Fix story render service during prerendering. (#22346)
- ๐ Restore text coloring in Travis logs (#22415)
- "AMP Cache Guidelines" update (#21786)
- Validator rollup (#22413)
- ๐ Clean up
.eslintignore
(#22411) - โจ Add referrer presence signals to the config rewriter varGroups. (#22365)
- allow cookie writer macros (#22388)
- ๐ Use minified build for visual diff tests (#22402)
- โป๏ธ Refactor math utils in extensions (#21876)
- ๐Fix variable service race. (#22375)
- fix wrong data event Select amp-date-picker range (#22408)
- ๐Fix flicker when opening an animated accordion. (#22399)
- โจamp-experiment 1.0: Added a 15KB limit on amp-experiment JSON (#22372)
- ๐ Run local integration tests on minified builds by default (#22380)
- Reformat beaverads contribution (#22396)
- ๐Fix sidebar open animation. (#22324)
- โจ Intent To Implement: BeaverAds support for amp-ads (#22281)
- updates size according to guidance (#20618)
- Update AMPHTML validator version (#17940)
- Use passive events for carousel. (#22004)
- ๐
amp-script
Remove AMP cors requirement for author code (#22389) - Differentiate 'render-start' msg and RENDER_START signal (#22305)
- ๐๐ Fix logic used to determine the branch creation point on Travis (#22355)
- ๐ Skip failing e2e tests and set retry to 2 (#22390)
- ๐ Don't overwrite browserify transform config (#22386)
- ๐ Update the build target logic used during PR checks (#22348)
- Add separate iframe transport URLs for Canary (#22296)
- โป๏ธMove VariableService to doc level #2 (#22300)
- Enable linker for AMP.navigateTo (#22361)
- ๐โป๏ธ Move test configuration out of
package json
(#22362) - ๐ Appropriately handle async E2E test error (#22366)
- Ensure that the waitForBody yields at the earliest possible time when body is opened (#22343)
- ๐๐ Fixes for
gulp pr-check
(#22364) - ๐ Support RTL for base carousel (#21994)
- Rename waitForBody to waitForBodyOpen (#22347)
- ๐ Add safe zone in screen edges to prevent blocking navigation (#22116)
- Remove unnecessary service stubs in linker-manager-test (#22356)
- โจ Introduce LiveStoryManager (#22273)
- [AoG] Fix two race conditions in amp-bind/amp-list when backgrounded (#22227)
- Use DOMReady (bodyComplete) signal where necessary (#22344)
- โป๏ธLightbox refactoring. (#22232)
- Force build additional components during prerendering if needed. (#22326)
- ๐ฆ Update dependency @ampproject/animations to v0.2.0 (#22228)
- ๐ฆ Update dependency fs-extra to v8 (#22259)
- ๐ฆ Update dependency eslint-plugin-jsdoc to v5 (#22313)
- ๐ฆ Update dependency eslint-config-prettier to v4.3.0 (#22333)
- Create custom attribute for text background color in stories (#22138)
- ๐ฆ Update dependency jsdom to v15.1.0 (#22262)
- ๐ฆ Update dependency puppeteer to v1.16.0 (#22276)
- ๐ฆ Update dependency codecov to v3.5.0 (#22304)
- ๐ฆ Update dependency eslint-plugin-prettier to v3.1.0 (#22336)
- ๐ Add max width to amp-twitter (#22334)
- Documentation for story page attachments CTA label and title. (#21989)
- ๐Switch to .prettierrc to avoid breaking IDE extensions (#22332)
- Update feature deprecation/removal process (#22114)
- ๐โจ Adopt
prettier
for code formatting (#21212) - ๐Enable passing viewer caps as hashparam (#22317)
- Remove amp-consent experimental flag (#22306)
- Handling video visibility updates. (#22140)
- amp-next-page: Fetch failure should be a user error (#22293)
- ๐๐ Mark
--local-changes
test status as skipped for large refactors (#22323) - โจamp-consent: Allowed passing the consent string through a macro (#22299)
- New amp-ad for aniview (#20884)
- ๐โป๏ธ๐ฎ๐ Refactor
gulp pr-check
(#22319) - ๐ Don't run unit tests on local changes for large refactors (#22320)
- ๐ Altered Safari Preconnect Polyfill Endpoint (#21138)
- amp-form: Reduce typecasts, clean up (#22298)
- Fix messenger command typo in web-push service worker (#20245)
- SwG release 0.1.22.51 (#22301)
- ๐๐ฎ Simplify the way
gulp lint
works on Travis (#22294) - Add validation rules for (#22289)
- amp-embed support for opinary (#22195)
- Validator Rollup (#22286)
- ๐Fix usage of
getElementsByTagName
on ShadowRoot. (#22290) - ๐ Fix broken links in AMP4Email spec. (#22044)
- ๐ Fix lint error in 3p/integration.js (#22284)
- โจAdd shadow integration test for amp analytics (#22252)
- amp form submit-error action fix (#22221)
- ๐ End e2e task with grace (#22164)
- ๐ amp inabox: Removed margin: auto !important for the amp4ads use case (#22274)
- โป๏ธ SwG Crypto naming change: "keys" -> "cryptokeys" (#22272)
- Rename Chargeads to Newsroom AI (#20860)
- Add dirtyBit support to stored consent value (#22257)
- Write cookies to eTLD+1 (#22255)
- ๐โจ๐ Run tests against minified code during PR checks (#22263)
- Remove position: absolute when measuring fluid creative height. (#22242)
- ๐ Store the native getBoundingClientRect before patching (#22269)
- ๐โป๏ธ Refactor post-compilation config writes (#22256)
- Override global scrollTo in iOS embed cases (#22244)
- ๐ฎ Remove support for xhr identity attribute "cross-origin". (#21909)
- ๐ Use a multislot request for pubmine ads (#21781)
- ๐โป๏ธ๐ฎ๐ Refactor
compile()
inbuild-system/tasks/helpers.js
(#22254) - ๐ web-worker: Set error reporter (#21855)
- โจ Support dynamically added lists and add configuration options (#21778)
- Support for Idealmedia (#22102)
- ๐โ Update failing autocomplete e2e test (#22250)
- โจamp-consent: Added support for allowing CMPs to add their own documentation and examples for amp-consent (#21752)
- ๐ Re add IE11 to our CI in blocking mode (#22248)
- Support for Lentainform (#22101)
- Support for MGID (#22100)
- ๐ Clean up describes-e2e (#22206)
- Validator rollup (#22236)
- Rename version to internalRuntimeVersion in AmpPass.java (#22234)
- validator.amp.dev is live, update links (#22231)
- ๐๐ฎ Use
compiler.jar
instead ofrunner.jar
for single pass, remove unnecessary code (#22056) - repace version() calls with the version string literal (#22216)
- โจ๐๐ Lightbox captions changes. (#22189)
- Config for ios-fixed-no-transfer experiment (#22224)
- Experiment to disable transfer layer in 12.2 and above (#22223)
- ๐ฆ Update dependency gulp to v4.0.2 (#22157)
- ๐ฆ Update dependency codecov to v3.4.0 (#22211)
- ๐ฆ Update dependency @octokit/rest to v16.25.3 (#22190)
- SwG Release 0.1.22.50 (#22226)
- โจAdd allow-blocked-end-date flag and e2e test (#22029)
- ๐ Retry tests before failing them on Travis (#22210)
- ๐ Enable integration testing on IE11 (#21667)
- โจ Implementing subscriptions encryption to work with the Viewer (#22058)
- Revert "โป๏ธMove VariableService to doc level (#22137)" (#22218)
- Revert "โป๏ธMove VariableService to doc level (#22137)" (#22218)
- amp-bind: Update textarea initial value via [defaultText] (#22205)
- toggleAutoplay is an action, not an event. (#22202)
- Delete auto ads responsive experiment from experiments.js (#22191)
- Skip flaky A4A test (#22165)
- โจamp-consent: consent-ui Allow passing in the reason for prompt in the iframe name attribute (#21647)
- ๐โป๏ธ Refactor
compileJs
into smaller functions (#22147) - ๐Fix dev server shadow mode. (#22207)
- amp-script: Share size limit across elements (#22083)
- updated documentation on sizes attribute behavior on amp-img (#22166)
- ๐ ๐ amp-lightbox: prevent iOS scroll freeze in both directions. (#22199)
- ๐ Support RTL inputs and datasets on amp-autocomplete (#22128)
- added note about ads and flying carpets (#22186)
- โจAdd support for mask-trim-zeros attribute on amp-inputmask. (#22175)
- Update validator output due to changed message. (#22196)
- Delete auto ads responsive experiment from config (#22192)
- Allow SVG elements in stories. (#22187)
- Validator rollup (#22188)
- โ Skip all amp-skimlinks integration tests. (#22181)
- ๐๐๐support for CAaja ads network (#21671)
- Docs: remove "experimental" (overloaded term) (#21943)
- For AdSense, expect checksum to be a 32-bit integer that is not base-64 encoded. (#21716)
- ๐Propagate data-ad-host attribute to ad url param for amp-auto-ads (#22092)
- ๐ amp-recaptcha-input: Added amp.dev example (#21834)
Breakdown by component
ads
Reformat beaverads contribution (#22396) โจ Intent To Implement: BeaverAds support for amp-ads (#22281)amp-a4a
Remove amp-consent experimental flag (#22306) โจamp-consent: Allowed passing the consent string through a macro (#22299)amp-access
Fixes typo in amp-access and amp-subscriptions docs (#22363)amp-accordion
๐Fix flicker when opening an animated accordion. (#22399)amp-ad
โจ Intent To Implement: BeaverAds support for amp-ads (#22281) Differentiate 'render-start' msg and RENDER_START signal (#22305)amp-ad-custom
Add validation rules for (#22289)amp-ad-network-doubleclick-impl
Remove position: absolute when measuring fluid creative height. (#22242)amp-analytics
โจ Add referrer presence signals to the config rewriter varGroups. (#22365) allow cookie writer macros (#22388) ๐Fix variable service race. (#22375) Add separate iframe transport URLs for Canary (#22296) โป๏ธMove VariableService to doc level #2 (#22300) Enable linker for AMP.navigateTo (#22361) Remove unnecessary service stubs in linker-manager-test (#22356) ๐ AMP analytics docs: Correct format support (-email, +stories) (#22338) Write cookies to eTLD+1 (#22255)amp-auto-ads
๐Fix usage of `getElementsByTagName` on ShadowRoot. (#22290)amp-autocomplete
๐ Fix formatting issues in extension docs and add missing front-matter (#22351) ๐โ Update failing autocomplete e2e test (#22250)amp-base-carousel
๐ Skip failing e2e tests and set retry to 2 (#22390)amp-connatix-player
๐ Connatix Player extension: fix broken documentation page (#22311)amp-consent
Rename consentState to consentStateValue (#22308) Add dirtyBit support to stored consent value (#22257)amp-date-picker
fix wrong data event Select amp-date-picker range (#22408)amp-dynamic-css-classes
Rename waitForBody to waitForBodyOpen (#22347)amp-experiment
โจamp-experiment 1.0: Added a 15KB limit on amp-experiment JSON (#22372) Rename waitForBody to waitForBodyOpen (#22347) Use DOMReady (bodyComplete) signal where necessary (#22344)amp-form
๐ Skip failing e2e tests and set retry to 2 (#22390) ๐ Fix formatting issues in extension docs and add missing front-matter (#22351) amp-form: Reduce typecasts, clean up (#22298)amp-geo
Rename waitForBody to waitForBodyOpen (#22347) Use DOMReady (bodyComplete) signal where necessary (#22344)amp-gist
๐ Fix formatting issues in extension docs and add missing front-matter (#22351)amp-gwd-animation
Rename waitForBody to waitForBodyOpen (#22347) Use DOMReady (bodyComplete) signal where necessary (#22344)amp-inputmask
๐ Fix formatting issues in extension docs and add missing front-matter (#22351)amp-lightbox
๐ Add email to amp-lightbox supported formats (#22330)amp-lightbox-gallery
๐amp-lightbox-gallery: update the broken example link (#22310)amp-link-rewriter
๐ Fix formatting issues in extension docs and add missing front-matter (#22351) Use DOMReady (bodyComplete) signal where necessary (#22344)amp-list
๐ Skip failing e2e tests and set retry to 2 (#22390)amp-mraid
๐ Fix formatting issues in extension docs and add missing front-matter (#22351)amp-next-page
amp-next-page: Fetch failure should be a user error (#22293)amp-recaptcha-input
๐amp-recaptcha-input: Removed the experimental blurb in the recaptcha reference docs (#22307)amp-script
Validator rollup (#22413) ๐ `amp-script` Remove AMP cors requirement for author code (#22389)amp-sidebar
๐Fix sidebar open animation. (#22324)amp-skimlinks
Rename waitForBody to waitForBodyOpen (#22347)amp-smartlinks
๐ Fix formatting issues in extension docs and add missing front-matter (#22351) Use DOMReady (bodyComplete) signal where necessary (#22344)amp-sticky-ad
Rename waitForBody to waitForBodyOpen (#22347)amp-story
Fix story render service during prerendering. (#22346) โจ Introduce LiveStoryManager (#22273) Use DOMReady (bodyComplete) signal where necessary (#22344) ๐ Add max width to amp-twitter (#22334)amp-subscriptions
Fixes typo in amp-access and amp-subscriptions docs (#22363) โป๏ธ SwG Crypto naming change: "keys" -> "cryptokeys" (#22272)amp-viewer-integration
๐ Clean up `.eslintignore` (#22411)validator
Validator rollup (#22413) - cl/249265307 Revision bump for #22372 - cl/249156543 Allow amp-script with an experiment token. - cl/248381896 Revision bump for #22289๐๐ฎ Simplify the way gulp lint
works on Travis (#22294)
Over the past year, various lint rules were added to improve AMP's code correctness. For example, #14742, #12748, #15255, #14761. In addition, lint checks were enabled for the code in validator/
, which is developed in a different repo and periodically synced to amphtml
. See #18601 and #13966.
As a result, gulp lint
is run only against the files edited by a PR during PR builds, while hundreds of linter warnings are printed during push builds.
This PR does the following:
- Silences 200+ outstanding linter warnings for
amphtml-internal/prefer-deferred-promise
,amphtml-internal/unused-private-field
, andamphtml-internal/vsync
, and for thevalidator/
directory - Updates
lint.js
to lint all files during Travis PR and push builds - Paves the way for #21212 by starting with a clean slate of linter errors
Follow up tasks:
- Fix remaining
amphtml-internal/prefer-deferred-promise
,amphtml-internal/unused-private-field
, andamphtml-internal/vsync
errors and re-enable the rules in error mode (#14742, #12748) - Fix lint errors in
validator/
and re-enable all rules invalidator/.eslintrc
(#18601, #13966)
Validator Rollup (#22286)
cl/248060156 Revision bump for #21909