Fix test_not_animatable() when underlying value not supported.
Currently test_not_animatable() produces an error outside of a test()
when the underlying value is not supported. This is a problem,
particularly if the error can vary between implementations (rather than
being a test authoring error) because then the resulting exception leads
to a harness error and causes differences in test counts between
implementations. This is undesirable in WPT and causes the current
weird state of
https://wpt.fyi/results/css/css-values/calc-size/animation/interpolate-size-interpolation.html
This effectively moves the problematic assertion inside the test() --
except that the problematic assertion was already there but it wasn't
working because it depended on the scope of the "underlying" variable,
which was incorrect. So this fixes the scope of "underlying" so that
the existing assertion of the same thing inside the test() works. This
helps test_not_animatable() tests produce the same test counts on both
supporting and non-supporting implementations.
I left the test assertion that is catching test authoring error the way
it was since it isn't really a problem in this way.
Bug: 346977015
Change-Id: I4b1a18c13cdfab4e2a8fa597ecfd22cd7e02a40f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6033413
Commit-Queue: David Baron dbaron@chromium.org
Reviewed-by: Joey Arhar jarhar@chromium.org
Cr-Commit-Position: refs/heads/main@{#1385186}