WebNN: WPT fixes c/o code coverage reports
Code coverage reports [1] for WebNN input validation logic [2] [3]
turned up several missing cases, some cases where a glitch in the test
data was causing a failure before the intended one, and where helper
functions were producing the wrong test data so skipped code.
-
convTranspose2d(), resample2d(), pooling - validate size members;
was just validating that 2 sizes were passed. -
gru()/gruCell()/lstm()/lstmCell() - populate recurrentBias option;
was incorrectly applying recurrentBias data to bias option. -
split() - validate when splits option is scalar; ensure that axis is
valid when not validating it
This doesn't bring code coverage to 100%; there are several more
validation cases in the code where the spec doesn't call out
validation. That is being tracked by a separate audit. Also,
validation for data types is being reworked, so leaving those cases
alone.
1: https://analysis.chromium.org/coverage/p/chromium
2: //services/webnn/public/cpp/graph_validation_utils.cc
3: //third_party/blink/renderer/modules/ml/webnn/ml_graph_builder.cc
Change-Id: Iff70050500dcb2760b66013ba8bcfe95bb497191
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5672899
Reviewed-by: Phillis Tang phillis@chromium.org
Auto-Submit: Joshua Bell jsbell@chromium.org
Reviewed-by: ningxin hu ningxin.hu@intel.com
Commit-Queue: Joshua Bell jsbell@chromium.org
Cr-Commit-Position: refs/heads/main@{#1325639}