HTML Focusgroup attribute value rename
In a recent update to the spec (see OpenUI bug
openui/open-ui#859 and spec update at
https://open-ui.org/components/focusgroup.explainer/
the focusgroup direction have changed from physical descriptions
"horizontal" and "vertical" to logical CSS terms that imply the
direction limitations adapt to content direction: "inline" and "block".
This change (my first), is a simple rename of terms "horizontal" and
"vertical" to "inline" and "block" respectively. Other than the
attribute value parsing changes and related enums and function names,
this change does not actually [yet] consider the inline and block
direction when handling directional arrow keys from user input. That
will be saved for a future change.
Specific changes in this CL:
-
FocusgroupFlags::kHorizontal-->::kInline -
FocusgroupFlags::kVertical-->::kBlock -
FocusgroupFlags::kWrapHorizontally-->::kWrapInline -
FocusgroupFlags::kWrapVertically-->::kWrapBlock -
FocusgroupFlags::kWrapVertically-->::kWrapBlock -
FocusgroupDirection::kForwardHorizontal-->::kForwardInline -
FocusgroupDirection::kForwardVertical-->::kForwardBlock -
FocusgroupDirection::kBackwardHorizontal-->::kBackwardInline -
FocusgroupDirection::kBackwardVertical-->::kBackwardBlock -
FocusgroupControllerUtils::IsDirectionHorizontal()->
IsDirectionInline() -
FocusgroupControllerUtils::IsDirectionVertical()->
IsDirectionBlock()
Web tests impacted by this change are updated (and the
corresponding spec link is also updated).
Bug: 4021071
Change-Id: Ic3c9a5dc56c0d48f8c1aa5c5cec3dc70bb1f5687
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5554766
Commit-Queue: Benjamin Beaudry benjamin.beaudry@microsoft.com
Reviewed-by: Benjamin Beaudry benjamin.beaudry@microsoft.com
Reviewed-by: Mason Freed masonf@chromium.org
Cr-Commit-Position: refs/heads/main@{#1305376}