vaadin/flow 23.6.11

Vaadin Flow 23.6.11

on GitHub

Changes since 23.6.10

All changes

Fixes

• Prevent deadlock on concurrent push and disconnect (CP: 23.7) (#24229) (CP: 23.6)
  Commit · Pull request

  This PR cherry-picks changes from the original PR #24229 to branch 23.6. --- #### Original PR description > The previous AtomicBoolean guard in AtmospherePushConnection closed only the disconnect-vs-disconnect race. A push thread that reads disconnecting as false before a concurrent disconnect() flips it can still proceed into synchronized(lock) behind the disconnect thread, which is itself blocked inside resource.close() waiting for the servlet container's HTTP session lock held by the push thread — a two-lock cycle. > > Move resource.close() out of the monitor: inside synchronized(lock) capture the resource into a local and call connectionLost() to transition the state, then release the monitor before invoking close() on the stashed reference. Add a matching re-check of isConnected() at the top of the synchronized block in push() so a push that waited for the monitor observes the late disconnect and defers via PUSH_PENDING/RESPONSE_PENDING instead of NPEing on the cleared resource. The disconnecting flag stays set until close() returns so subsequent pushes take the fast path and no new disconnect() re-enters while close() is still in flight. > > Related-to #24192

• Fix potential deadlock in AtmospherePushConnection disconnect (#24133) (CP: 23.6)
  Commit · Pull request

  This PR cherry-picks changes from the original PR #24133 to branch 23.6. --- #### Original PR description > Fixes #24129