Patch Changes
-
#124
3706c1aThanks @tufantunc! - Fix the approval dialog turning Accept into a decline, and three boolean CLI flags that did nothing (#91).Approving a command now takes one keystroke, and works. The elicitation request asked for a required
confirmboolean on top of the protocol's ownaccept/decline, so clients rendered a checkbox beside the accept row. Choosing Accept without ticking it submitted a form missing a required field, the client answeredcancel, and ssh-mcp reportedAPPROVAL_DENIED: User did not approve this command— to a user who had just pressed Approve. The decision now comes fromactionalone. An explicitconfirm: falseis still honoured for clients that send one.Approval waits 10 minutes instead of 60 seconds. The request inherited the SDK's
DEFAULT_REQUEST_TIMEOUT_MSEC, setting a human's reading time from a default meant for machine round trips. An operator who stepped away, or who was working out an unfamiliar dialog, had it expire underneath them.A timed-out approval says so.
APPROVAL_UNAVAILABLEled with "a client without elicitation support" for every error, including a timeout where support was fine — the same wrong-cause defect the message was split out to fix, one release later, inside its own fix. Timeouts now name the elapsed budget and say the prompt may still be open.--disableApproval,--auditEntropyScanand--auditTamperEvidentwere no-ops.parseArgvstoresnullfor a flag written without=, which is how all three are documented, and each call site tested that for truthiness. They did nothing unless spelled--flag=1. The audit pair is the serious half: anyone who turned on hash-chained tamper-evident logging was running without it and had no signal. All flags now read presence through one helper, and--flag=false(or0,no,off) turns one back off.