rh-hideout/pokeemerald-expansion expansion/1.9.4 on GitHub

## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.9.4`.

🌋 IMPORTANT 🌋

This update integrates pret's latest Makefile changes, which rearranges the entire file in order to speed up compilation times overall. If you did any changes to it (such as installing Poryscript) and are having issues resolving the conflicts, keep expansion's version of Makefile and reapply your changes afterwards.

🧬 General 🧬

Fixed

Fixed alignment errors in EWRAM_INIT and friends when using u8, u16, etc. by @aronson in #5512
Update test LD script to respect 4 byte data section alignment by @aronson in #5517
Fixed Missing string_util.h include in mini_printf.c by @mrgriffin in #5572
Fixed unnecessary dependency scanning for test build and test rom names by @ravepossum in #5594
Fixed makefile: dependencies for map_group_count.h by @SBird1337 in #5648
- Fixes an issue that caused the build to fail on updates to src/debug.c due to mismatched dependency.

🗺️ Overworld 🗺️

Changed

Followers sprite fixes by @Cafeei in #5669
Follower fixes, Melmetal, Patrat, Woobat by @hedara90 in #5685
Fixed Farfetch'd overworld sprite by @hedara90 in #5711

Fixed

Fixed Berry mutations always generating a Persim Berry by @Bassoonian in #5504

🐉 Pokémon 🐉

Changed

Changing EVO_NONE from 0xFFFE to 0 by @GhoulMage in #5547
- There could be a case for out of bounds errors if arrays or iterations are happening where you're using + 1 or - 1, as EVO_FRIENDSHIP used to be the first index although it started with 1.
PokeCommunity sprites batch (October) by @kittenchilly in #5655
Followers sprite fixes by @Cafeei in #5669
Follower fixes, Melmetal, Patrat, Woobat by @hedara90 in #5685
Fixed Farfetch'd overworld sprite by @hedara90 in #5711

Fixed

Fixed P_FRIENDSHIP_EVO_THRESHOLD not checking for Gen 8 by @kittenchilly in #5503
Fixed HGSS dex search printing wrong mon after selecting evos by @ravepossum in #5552
Fixed 64px uncompressed followers by @hedara90 in #5601
Deoxys Sprite/Animation Fixes by @SarnPoke in #5603
Fixes Aegislash not reverting back by @AlexOn1ine in #5734

⚔️ Battle General ⚔️

Changed

Fixed damage calc modifiers by @AlexOn1ine in #5604

Fixed

Fixed Shiny Pokemon not being shiny after transforming with a gimmick by @hedara90 in #5573
Handle showdowns apostrophe the same way as ASCII apostrophe by @cawtds in #5712
Fixes Misty Terrain displaying wrong message by @AlexOn1ine in #5742
Fixes Dynamax dynamic move type by @AlexOn1ine in #5739

🤹 Moves 🤹

Changed

Fixed damage calc modifiers by @AlexOn1ine in #5604
Updated ability popups for Skill Swap, Mummy/Lingering Aroma, Worry Seed, Simple Beam, fix Doodle/Role Play bugs by @PhallenTree in #5493

Fixed

Fixed Follow Me failing in Single Battles for Gen 6/7 config by @AsparagusEduardo in #5542
Fixed AnimTask_HorizontalShake uses for shaking screen in battle anims by @ghoulslash in #5562
Fixed weather genie move anims and Springtide Storm targets by @ravepossum in #5553
Fixes Magic Guard not preventing Salt Cure by @AlexOn1ine in #5583
Fixes Dragon Tail using the effect twice during a Parental Bond attack by @AlexOn1ine in #5630
Fixes Magic Coat message by @AlexOn1ine in #5645
Fixes Take heart by @AlexOn1ine in #5658
Fixed Floral Healing anim by @AlexOn1ine in #5733
Fixes Population Bomb / Triple Kick missing message by @AlexOn1ine in #5747
Changes Max Phantasm move anim script call by @AlexOn1ine in #5737
Fixes Partner targeting and Acupressure/Ally Switch interaction by @AlexOn1ine in #5446
Revival Blessing fixes + Using Lunar Blessing's animation by @ghoulslash in #5490
Fixed curse + Protean interaction by @hedara90 in #5663
Added Minimize interaction to Supercell Slam by @hedara90 in #5713

🎭 Abilities 🎭

Changed

Fixed damage calc modifiers by @AlexOn1ine in #5604

Fixed

Adds tests and Costar fix from PR #5526 by @AlexOn1ine in #5529
Fixes Red Card / Eject Pack interaction with Emergency Exit by @AlexOn1ine in #5657
Fixed curse + Protean interaction by @hedara90 in #5663
Mimicry updates typing with RemoveAllTerrains() by @AERDU in #5666
Updated ability popups for Skill Swap, Mummy/Lingering Aroma, Worry Seed, Simple Beam, fix Doodle/Role Play bugs by @PhallenTree in #5493
Fixed curse + Protean interaction by @hedara90 in #5663
Fixes Ice Face regression by @AlexOn1ine in #5678
Fixes Neutralizing Gas crashes + adds missing interaction, Regenerator small fix by @PhallenTree in #5694

🧶 Items 🧶

Changed

Removes duplicate Booster Energy code by @AlexOn1ine in #5656

Fixed

Fixes Red Card / Eject Pack interaction with Emergency Exit by @AlexOn1ine in #5657
Fixes Red Card / Eject Pack interaction by @AlexOn1ine in #5724
Fixes gems triggering on confusion damage by @AlexOn1ine in #5723
Fixes Kee Maranga and Enigma Berry by @AlexOn1ine in #5727
Fixes Blunder Policy by @AlexOn1ine in #5722
Fixes Rusted Shield/Sword allowed to be Knocked Off from Zamazenta/Zacian by @iriv24 in #5750

🤖 Battle AI 🤖

Fixed

Fixed certain move data being cleared on turn end by @Pawkkie and @AlexOn1ine in #5488
Global is used instead of passed var by @AlexOn1ine in #5546
Fixes dynamicMoveType global not being reset during AI calcs by @AlexOn1ine in #5628

🧹 Other Cleanup 🧹

Remove one redundant call of SetAiLogicDataForTurn in DoBattleIntro by @AlexOn1ine in #5491
Cleanup extraneous function in battle_anim.h by @hedara90 in #5506
Add newline to move relearner string by @Bassoonian in #5523
Fixed 10,000,000 Volt Thunderbolt name by @AsparagusEduardo in #5533
Added constant to expansion inclusive copyright magic number by @pkmnsnfrn in #5413
Centralise AI Tests trainer name by @Bassoonian in #5532
Remove now outdated information from readme by @Bassoonian in #5548
Changing EVO_NONE from 0xFFFE to 0 by @GhoulMage in #5547
- There could be a case for out of bounds errors if arrays or iterations are happening where you're using + 1 or - 1, as EVO_FRIENDSHIP used to be the first index although it started with 1.
Shed Skin chance fix by @Pawkkie in #5558
Restore test file dependencies so they're rebuilt properly by @ravepossum in #5617
Improve SEND_OUT error message; require Speed for all battlers by @mrgriffin in #5631
Removes duplicate Booster Energy code by @AlexOn1ine in #5656
Wrong assumtion in dauntless_shield.c by @AlexOn1ine in #5692

🧪 Test Runner 🧪

Added

Add curious medicine test by @ghoulslash in #5540
Tests: detect task leaks by @mrgriffin in #5528

Changed

Add text width tests for move, ability, item, and pokedex descriptions by @kittenchilly in #5505
Centralise AI Tests trainer name by @Bassoonian in #5532
Add basic Steam Engine, Guard Dog Tests by @ghoulslash in #5569
Fixed damage test by @GhoulMage and @mrgriffin for teaching me pokeemerald-expansion tests in #5574
Fallback memmem implementation by @mrgriffin in #5561
Hydra: Support %p in test summaries by @mrgriffin in #5626
Improve SEND_OUT error message; require Speed for all battlers by @mrgriffin in #5631
Check that PASSES_RANDOMLY affected a Random call by @mrgriffin in #5635
Wrong assumtion in dauntless_shield.c by @AlexOn1ine in #5692

Fixed

Update test LD script to respect 4 byte data section alignment by @aronson in #5517
Adds tests and Costar fix from PR #5526 by @AlexOn1ine in #5529
Fixed broken Starting Terrain test by @hedara90 in #5582

📚 Documentation 📚

Add changelog header in PR template to aid automation by @AsparagusEduardo in #5539
Added compressed OW mon VRAM notice in config file by @AsparagusEduardo in #5599
Update README.md to link to INSTALL.md by @Pawkkie in #5720
Fixes minor move desc errors by @AlexOn1ine in #5728

📦 Branch Synchronisation 📦

pret

15th of October in #5527
- Slight storage system documentation by @luckytyphlosion in pret#2024
- Clean up defines lacking spaces by @Bassoonian in pret#2025
- UB fix in battle_transition.c by @cawtds in pret#2007
- preproc: support arbitrary expressions in enums by @mrgriffin in pret#2026
- [Build System Rewrite] Refactored Makefile by @Icedude907 in pret#1950
- Fixed incorrect point macros in contest_ai_script.inc by @NTx86 in pret#2028
- [Build System Rewrite] Massive build speed improvement via scaninc changes by @Icedude907 in pret#1954
- [Build System Rewrite] Improved audio rules by @Icedude907 in pret#1957
- Update INSTALL.md to state that Windows 8 is no longer supported by Microsoft by @luciofstars in pret#2029
- Update pull_request_template.md to include Discord username update by @luciofstars in pret#2030
- remove ScriptContext_Enable from secret_base.h by @DizzyEggg in pret#2032
- Remove gflib by @Kurausukun in pret#2033
- Minor toolchain fixes by @GriffinRichards in pret#2031
- Bugfix for cable car hikerGraphicsIds array by @Scyrous in pret#2039
- Remove explicit symbol sizes in sym_common.txt by @GriffinRichards in pret#2038
- Ignore mGBA screenshots by @Jaizu in pret#2041
- Replaced copyright magic numbers in intro.c with constants by @pkmnsnfrn in pret#2035
- Fixed typo: | should be || in Task_TryFieldPoisonWhiteOut by @AreaZR in pret#2044
- [preproc] support C23 enum underlying type syntax by @mrgriffin in pret#2043
- Fixed deleting files with dependency files by @mid-kid in pret#2045
- Remove unnecessary looping for rule generation and unroll macros by @mid-kid in pret#2046
- Get rid of common syms by @luckytyphlosion in pret#2040
- Bugfix for cable car hikerGraphicsIds array by @Scyrous in pret#2039
- UB fix in battle_transition.c by @cawtds in pret#2007
- Fixed typo: | should be || in Task_TryFieldPoisonWhiteOut by @AreaZR in pret#2044
- Get rid of common syms by @luckytyphlosion in pret#2040
- Fixed incorrect point macros in contest_ai_script.inc by @NTx86 in pret#2028
5th of November in #5644
- Added define value for bard sound length by @fdeblasio in pret#2052
- Silence 'Nothing to be done for generated' messages by @GriffinRichards in pret#2059
- Lay out emerald version png horizontally by @GriffinRichards in pret#2062
29 of November in #5736
- Remove usage of gHeap in sSpritePalettes_ContestantsTurnBlinkEffect by @Lactozilla in pret#2064
- BUGFIX: Fix Counter and Mirror Coat checking the wrong category by @surtr-games in pret#2066
- Add TRY_DRAW_SPOT_PIXEL by @GriffinRichards in pret#2055
- Added extra encoded character support by @AsparagusEduardo in pret#2050

merrp's followers

Merrp merge (12th of October) by @Bassoonian in #5514
- d80190f fix: Dig in Sealed Chamber no longer freezes follower.

New Contributors

@AERDU made their first contribution in #5666

Full Changelog: expansion/1.9.3...expansion/1.9.4

rh-hideout/pokeemerald-expansion expansion/1.9.4 Version 1.9.4 on GitHub

🌋 IMPORTANT 🌋

🧬 General 🧬

Fixed

🗺️ Overworld 🗺️

Changed

Fixed

🐉 Pokémon 🐉

Changed

Fixed

⚔️ Battle General ⚔️

Changed

Fixed

🤹 Moves 🤹

Changed

Fixed

🎭 Abilities 🎭

Changed

Fixed

🧶 Items 🧶

Changed

Fixed

🤖 Battle AI 🤖

Fixed

🧹 Other Cleanup 🧹

🧪 Test Runner 🧪

Added

Changed

Fixed

📚 Documentation 📚

📦 Branch Synchronisation 📦

pret

merrp's followers

New Contributors

rh-hideout/pokeemerald-expansion expansion/1.9.4
Version 1.9.4

on GitHub