rh-hideout/pokeemerald-expansion expansion/1.9.3

Version 1.9.3

on GitHub

## How to update
- If you haven't set up a remote, run the command `git remote add RHH https://github.com/rh-hideout/pokeemerald-expansion`.
- Once you have your remote set up, run the command `git pull RHH expansion/1.9.3`.

🌋 REFACTORS 🌋

📜 = Uses a migration script.

• Converted settotemboost command to callnative in #5418
• Removed unused RESOURCE_FLAG_TRACED in #5430
• Changed MOVEEND_ defines to an enum in #5449

✨ Feature Branches ✨

merrp/aarant's Followers

Fixed

• Fixed Expansion-exclusive issue that caused trainers to not play their "pointing" animation when Followers were out during battle intro by @kittenchilly in #5406

⚔️ Battle General ⚔️

Changed

• Improved Mega evolution animation to make it a little smoother by @kleenxfeu in #4816

Fixed

• Fixed affection check for exp multiplier by @Bassoonian in #5421
• Fixed multiple Primal Reversions not occurring if multiple battlers fainted on the previous turn by @PhallenTree in #5430

🤹 Moves 🤹

Added

• Added missing B_AFTER_YOU_TURN_ORDER config by @PhallenTree in #5400
  • Gen 5-7: After You fails if the order remains the same after using After You.
  • Gen 8+: After You no longer fails if the turn order remains the same after using After You.
• Added missing B_QUASH_TURN_ORDER config by @PhallenTree in #5400
  • Gen 5-7: If multiple Pokémon are affected by Quash, they move in the order they were affected by Quash.
  • Gen 8+: If multiple Pokémon are affected by Quash, they now move fastest to slowest.
• Added missing updated B_UPDATED_CONVERSION_2 by @wiz1989 in #5453
  • Gens 2-4: Conversion 2 changes the user's type to a type that is resistant/immune to the last move the user was hit by.
  • Gen 5+: Conversion 2 changes the user's type to a type that resists the last move used by the selected target.

Fixed

• Fixed Scale Shot corrupting the move used on the next turn by @AlexOn1ine in #5397
• Fixed Growth's description not being updated based on B_GROWTH_STAT_RAISE by @nescioquid in #5398
• Fixed Quash not updating the battlers' actions correctly by @PhallenTree in #5400
  • Cleanup by @PhallenTree in #5430
• Fixed Snatched Swallow not recovering HP if the Snatcher is not under the effect of Stockpile (should still heal) by @PhallenTree in #5430
• Fixed Counter users being damaged by Spiky Shield by @AlexOn1ine in #5402
• Fixed Electrified Dragon Darts not correctly avoiding targets with ability immunity (Volt Absorb, Motor Drive) by @PhallenTree in #5430
• Fixed Trace not activating a switch-in ability it traces (eg. Intimidate) by @PhallenTree in #5430
  • Removed unused RESOURCE_FLAG_TRACED.
• Fixed recoil damage not triggering healing berries by @AlexOn1ine in #5449
  • Also changed MOVEEND_ defines to an enum.

🎭 Abilities 🎭

Fixed

• Fixed Dancer activating even if the dance move is stolen by Snatch by @PhallenTree in #5430
• Fixed Ability popup when multiple Pokémon faint at the same time by @PhallenTree in #5430
• Multiple ability fixes by @PhallenTree in #5447
  • Fixed Protosynthesis/Quark Drive sometimes not activating ability popup despite still gaining the boost as they should.
  • Fixed Protosynthesis/Quark Drive activating on Transformed battlers.
  • Fixed Protosynthesis activating despite Cloud Nine being present on the field.
  • Fixed Quark Drive not activating if the battler is not grounded.
  • Fixed Protosynthesis/Quark Drive/Beast Boost stat raise priority when multiple stats are tied for the highest one.
    • Before: Attack, Defense, Speed, Special Attack, Special Defense.
    • After: Attack, Defense, Special Attack, Special Defense, Speed.

🧶 Items 🧶

Fixed

• Fixed Ogerpon's Masks not increasing the power of moves by 20% by @AlexOn1ine in #5391
• Fixed Jubilife Muffin not working by @kittenchilly in #5444
• Fixed duplicating flute bug in double battles by @ghoulslash in #5436

🤖 Battle AI 🤖

Fixed

• Fixed Trick/Switcheroo giving AI score even if the opponent has no held item by @kittenchilly in #5412
• Various AI fixes in AI_CalcMoveEffectScore by @ghoulslash in #5474
  • Missing break from EFFECT_ABSORB switch case.
  • Using last used move for Mirror Move instead of predicted move.

🧹 Other Cleanup 🧹

Changed

• Converted settotemboost command to callnative by @ghoulslash in #5418
• Removed trailing whitespace by @kittenchilly in #5455
• Removed binary match workaround for Rayquaza's tail in Sootopolis' cutscene by @hedara90 in #5480

Fixed

• Fixed potential uninitialized behavior in ChangeOrderTargetAfterAttacker by @AlexOn1ine in #5393
• Fallback on default BW map pop-up theme to reduce potential for error by @ravepossum in #5392
• Multiple typo fixes by @nescioquid in #5398
• VS Seeker documentation fix by @Bassoonian in #5415

🧪 Test Runner 🧪

Added

• Added missing After You and Quash tests by @PhallenTree in #5400

Changed

• Improved Tangling Hair test to make sure that chained effects do not overwrite relevant battler IDs by @ghoulslash in #5423
• Improved Full Heal item tests by @kittenchilly in #5444

Fixed

• Fixed Wake-Up Slap test typo by @Pawkkie in #5442
• Fixed test assumption fail summary fields using more memory than needed by @AsparagusEduardo in #5443
• Fixed issue with PASSES_RANDOMLY in AI tests by @Pawkkie in #5486

New Contributors

• @nescioquid made their first contribution in #5398
• @kleenxfeu made their first contribution in #4816
• @wiz1989 made their first contribution in #5453

Full Changelog: expansion/1.9.2...expansion/1.9.3