ppy/osu 2023.1026.0

on GitHub

Audio

Add new generic-error sample (ppy/osu-resources#288 by @nekodex)

SFX tweaks (#25178 by @nekodex)

A bunch of little fixes grouped together:

• Fixes toolbar ruleset buttons not having hover sounds
• Replaces NowPlayingOverlay pop-in/pop-out sounds with newer generic overlay pop-in/pop-out ones
• Changes NewsCard select samples from Default sample set to Button
• Reduces LoginOverlay sample panning to match NowPlayingOverlay
• Changes back button sample set (in KeyBindingPanel) from ButtonSidebar to Default
• Adds keypress feedback/sound when binding keys (in KeyBindingPanel)
• Changes RevertToDefaultButton from Button sample set to Default

Smaller changes

• Use new generic-error sample in appropriate places (#25113 by @nekodex)
  • Used by the duplicate keybinding popup and also replaces password-fail (incorrect room password popup)

Code Quality

Remove reference to multiplayer_scores table (ppy/osu-server-spectator#192 by @bdach)

Smaller changes

• Clean up KeyBindingRow and related classes (#25092 by @bdach)
• Remove remaining usages of LargeTick{Hit,Miss} in mania (#25100 by @bdach)
• Refactor key binding panel for easier usage (#25104 by @bdach)
• Remove no longer used scoring difficulty attributes (#25142 by @bdach)
• Apply various fixes and cleanup to spinner logic (#25143 by @peppy)
• Fix various new rider EAP inspections (#25155 by @peppy)
• Replace DistancedHitObjectComposer with composition-based approach (#25171 by @bdach)
• Isolate diffcalc workflow runs (#25176 by @smoogipoo)

Editor

Fix osu!mania beat snap grid sometimes not displaying correctly (#25073 by @peppy)

Persist the state of "show speed changes" between editor sessions (#25153 by @peppy)

Add beat snap grid to osu!taiko editor (#25154 by @peppy)

Framework

Add button to randomise test scene background colour (ppy/osu-framework#6022 by @peppy)

Fix some beatmap videos no longer rendering (ppy/osu-framework#6024 by @FreezyLemon)

MPEG-4 Part 2 is a video coding standard that sits "between" H.262 and H.264. Xvid, DivX and some less known formats implement it.

Smaller changes

• Add notes regarding using inline delegates with Scheduler.AddOnce (ppy/osu-framework#6023 by @peppy)
• Update FFmpeg binaries (ppy/osu-framework#6026 by @github-actions[bot])
• Update native libs (ppy/osu-framework#6027 by @peppy)
• Bring back shader workaround to fix blur on iOS (ppy/osu-framework#6031 by @frenzibyte)
• Throw exception when pushing a screen at OnExiting without blocking (ppy/osu-framework#6033 by @hwabis)

Gameplay

Fix argon health bar not completing flash animation correctly (#25074 by @peppy)

Noticed this while doing some work around the health bar. The flash just wasn't playing due to an oversight in the miss-finish-animation logic. I've also adjusted the flash a bit.

Show results immediately if user hits "back" key after finishing gameplay (#25097 by @peppy)

I've gone ahead and matched the osu!stable behaviour for this, as it seems like it's what people are used to and they will settle for no less.

Smaller changes

• Fix legacy score calculators using incorrect mod multipliers (#24988 by @smoogipoo)
• Fix multiplayer not correctly pausing the track on initialisation (#25079 by @peppy)
  • This resolves crashes experience in the last release (before the hotfix).
• Fix default preview point being incorrect on old beatmaps (#25083 by @peppy)
• Fix health bar animating startup sequence when it shouldn't be (#25136 by @peppy)
• Fix incorrect volume on some beatmaps (#25179 by @bdach)

Gameplay (osu!)

Adjust slider repeat animation on legacy skins to closer match stable (#25160 by @bdach)

Add an "Adjust pitch" switch to DT/HT (#24640 by @Givikap120)

Adjust slider ends to be more lenient during very fast sliders (#24966 by @peppy)

On very fast sliders, you now only need to be tracking somewhere in the last 36ms, rather than precisely at the (hidden) position of the last tick.

######### Miss

######### Valid hits

Fix circle scale not matching stable due to missing multiplier (#25167 by @peppy)

This fixes some replays incorrectly having misses due to a floating-point scale mismatch.

Change spinner score display to show when reaching max bonus score (#25177 by @peppy)

Fix spinner cheese by accounting for spin directionality (#25157 by @peppy)

You now need to spin in one direction for a full spin in order to increment the total spin count.

Smaller changes

• Adjust approach circle maximum size limits for backwards compatibility (#25067 by @bdach)
• Apply a few more object sizing limits (#25110 by @peppy)
• Fix spinner ticks not playing samples correctly sometimes (#25216 by @bdach)
  • This was probably revealed by the lowering of the spinner cap, which made the ticks more spread out and made this issue more likely to occur.

Gameplay (osu!catch)

Adjust legacy skin catcher sizing to match 1:1 with osu!(stable) (#25070 by @frenzibyte)

Overall, here are visual cross-comparisons of the catcher's display between lazer and stable:

master	this PR

Fix "Floating Fruits" mod not flipping playfield properly (#25173 by @bdach)

Gameplay (osu!mania)

Remove osu!mania hold note "ticks" (#25062 by @smoogipoo)

Change osu!mania "perfect" judgements to only award bonus score (#25111 by @peppy)

Online

Add ability to invite players to multiplayer rooms (#25005 by @minetoblend)

Adds invites for multiplayer matches. Players can be invited by right clicking their profile in the user list (F9 menu).

We will add more places to trigger the invite from in the future!

Smaller changes

• Fix score importer looking up guest user by username online (#25077 by @bdach)
• Add ability to invite players to multiplayer rooms (ppy/osu-server-spectator#188 by @minetoblend)
  • Server-side changes.
• Don't upload replays for failed scores (ppy/osu-server-spectator#190 by @smoogipoo)

Performance

Ensure health displays don't pile up transforms when off-screen (#25076 by @peppy)

Results

Show maximum bonus statistics on results screen (#25096 by @peppy)

Settings

Disallow binding multiple bindings in a single section to one key (#25105 by @bdach)

Add ability to revert slider settings to default when double-clicking nub (#25163 by @Joehuu)

Smaller changes

• Clear pre-existing bindings of same key combination to single action (#25152 by @bdach)

Song Select

Improve mouse interactions at song select (#25182 by @peppy)

Add ability to search for difficulty names using square brackets (#24921 by @Pasi4K5)

Smaller changes

• Fix "Hard Rock" mod affecting CS/AR in osu!mania and osu!taiko (#25101 by @peppy)
  • Not sure if there are other exceptions we should account for here. This is mostly fixing this for visual purposes. We'd probably want to hide these stats in the mod select screen at some point if they are not relevant to a ruleset.
• Remove drag handles from manage collections dialog for now (#25140 by @peppy)
  • The realm implementation doesn't support this. May come back at a future date, but this matches stable so it's not a huge deal.
• Fix collections not being sorted alphabetically in context menus (#25139 by @peppy)
  • As mentioned in #21602 (comment).

Testing

• Remove test scene background stack and use new ChangeBackgroundColour (#25082 by @peppy)
• Fix key binding panel test failures from introducing placeholder text (#25115 by @bdach)

Tooling

• Fix + improve diffcalc command for comment-based execution (#25159 by @smoogipoo)
  • The biggest change here is to use actions-cool/check-user-permission to check permissions. My intention is for only those with write permissions to this repo to be able to run the action via commenting !diffcalc.

The text at the top of the workflow details how to use this.

A second, somewhat important change is to run the timeout job on the self-hosted runner, since it has different usage limits to the GH runners. This was missed in my initial implementation, but the limits are appropriate for self-hosted runners.

• Fix invalid PR URL in diffcalc GitHub action (#25169 by @smoogipoo)
  • As seen in https://github.com/ppy/osu/actions/runs/6570346137/job/17847635703

Documentation: https://docs.github.com/en/rest/overview/issue-event-types?apiVersion=2022-11-28#properties-for-commented (grep)

Tournament

Reduce black fill of song bar in tournament UI back to reasonable levels (#25081 by @peppy)

UI

Move playlist item download button to left (#25063 by @peppy)

Felt really anti-user when you go to click the results button and the downloads button pops into its place.

Before:

After:

Smaller changes

• Add extended info support to tiny mod switches (#25093 by @Joehuu)
  • https://github.com/ppy/osu/assets/35318437/ddda6117-e557-4f90-96f7-f885a6c52afd
• Use dimmed placeholder text instead of empty box on cleared bindings (#25106 by @bdach)
• Fix dangerous buttons using different shades of pink (#25112 by @bdach)
• Change beatmap listing key to B to match Ctrl-B shortcut (#25180 by @Susko3)
  • B is also better than D because the button says browse. This matches P for play and E for edit.
• Localisation updates (ppy/osu-resources#291 by @peppy)
• Limit image size in comments (#25202 by @EVAST9919)

Full Changelog: 2023.1013.0...2023.1026.0