Refactoring work by @lebensterben
- Major changes in
lychee-lib::filter
module:- Fields in
Excludes
except theRegexSet
is now moved toFilter
. Filter
containsOption<Excludes>
andOption<Includes>
, which are
wrapper struct ofRegexSet
instead ofOption<RegexSet>
. As a result
the code now looks cleaner.- Factored out some filtering logics to dedicated functions.
- It's possible to write tests for those functions in addition to tests
for theFilter
struct.
- It's possible to write tests for those functions in addition to tests
- Added docs to
Filter::is_excluded
and reorgnized the code.
- Fields in
- placed
derive_builder
bytyped_builder
:- The internal interface very ugly, as admitted by the author, but we no
longer have nestedOption
s like before. - As a result, the
Client
building is much easier to read. - Main benefit of
typed_builder
is, the arguments feeded to builder is
checked at compile time instead of run-time.
- The internal interface very ugly, as admitted by the author, but we no
- Fixed a bug in
lychee::tests::usage
andlychee-lib::stats::test
.- Now it will clear environment variable which would otherwise cause an
issue ifGITHUB_TOKEN
is set.
- Now it will clear environment variable which would otherwise cause an
- Updated dependencies.