Merge pull request #633 from lokal-music/release/v12.3.1
Changelog
Windows builds: free code signing provided by SignPath.io, certificate by SignPath Foundation (code signing policy).
FYI:
Lokal is 100% local; the library, history, anything in database, or any info that is used for API's such as yt-dlp, LRCLIB, is NOT seen by us.
What's Changed
-
fix(desktop): suppress unavailable subline notices in sidebar lyrics (#632)
Details
Problem
When translation and/or romanization cannot be provided,
LyricsPanelrenders an inline floating status pill (for example Already in your language) based on persistent hook state. In desktop sidebar lyrics this pill has no dismissal affordance and can remain over the lyrics indefinitely.Fix
- Limit the three non-actionable subline status notices (
same-language, translation unavailable, romanization unavailable) to thefullscreenlyrics presentations. - Both sidebar placements (independent Lyrics side panel and embedded Right Sidebar, including compact card) already pass
fullscreen={false}, so these persistent notices are not displayed there. - Preserve useful source-picker / embed action notices (
noticestate), loading indicators, and all translation/romanization functionality. - Correct status precedence to ensure a stale, inactive translation state does not override a romanization notice in fullscreen lyrics.
Tests
- Add
scripts/sidebar-lyrics-subline-notice.test.mjs(Node test runner) covering sidebar suppression, fullscreen feedback, and active-status gating. - Independently exercised 9 status combinations against the exact helper source from the PR branch; all passed.
- Desktop UI visual verification still recommended in packaged build.
Summary by CodeRabbit
- New Features
- Fullscreen lyrics now display a notice when a requested translation is in the same language or unavailable, or when the selected romanization is unavailable.
- Bug Fixes
- Sidebar lyrics no longer show notices for non-actionable translation or romanization states. Inactive or ready sublines remain notice-free, and an active romanization status takes precedence over an inactive translation status.
- Limit the three non-actionable subline status notices (
Contributors: @CHEYCKIT
Full Changelog: v12.3.0...v12.3.1
Setup
See README.md for full setup instructions.
macOS: this build is ad-hoc signed, not notarized (no Developer ID certificate is configured). The first time, right-click Lokal in Applications and choose Open, or run xattr -dr com.apple.quarantine /Applications/Lokal.app.
Binary Checksums (SHA-256)
Lokal-12.3.1-arm64-mac.zip:
[663A93DA4BF4AF5A6B12C12C350E3A168885D08E1F0A09F9E9F51C133E9A69BA]
Lokal-12.3.1-arm64-mac.zip.blockmap:[ABA610BA009AA9046EE8DD0AC27E2CD7BF34D3AD51C42EB75D10808D0A40E53D]
Lokal-12.3.1-arm64.AppImage:[232FDA2E5612FBA496361B6EB1E10E87FCD144C2BAA7154C586D77E5D230DF8F]
Lokal-12.3.1-arm64.dmg:[5EA49CB40B5AB751B03847A224729F0CBF33C7A9824A385CB8F93B5D6023A64B]
Lokal-12.3.1-arm64.dmg.blockmap:[4946CEFFA5175A0B86D2CE9AF99C40DCDD9AC8EF474CE5855D6D4E80B1C17F1E]
Lokal-12.3.1-mac.zip:[A064DDF210DCD178457D501776B19B7D606EE5DC425E4AAAE70B2E454530868F]
Lokal-12.3.1-mac.zip.blockmap:[87A11A990F268ABF9E90177672424D3DE874615DAB4CE75977EB088A1D17A07A]
Lokal-12.3.1.AppImage:[45400B7716ECF1CB3E78F192CF1C31A3632826CFC29A7AB2A740C061DBD0872C]
Lokal-12.3.1.dmg:[0870836C385B3F524C275801CA5B2179239CBD2BFCD57D8AE025BBA4149D24FA]
Lokal-12.3.1.dmg.blockmap:[9184091709705820E07508DA1C4B1811D9FA300264FBFEC6260C8DD904782559]
Lokal-12.3.1.exe:[0F201C198817D09C57CB113F75314CCD47E7890811E9C22C531C7230C1E781BB]
Lokal-Setup-12.3.1.exe:[9C9B841CE910B10745BF8E2C035AA31A09ABC278F3A4EA685D1BA1888C7A1C9C]
Lokal-Setup-12.3.1.exe.blockmap:[661935D0554E7E05BF0987184929E2C67F4A85345991E08DAD43A1DB3EF5BFAA]
builder-debug.yml:[1C08248D9C7E541683AB32C8B3AA08A27001DD373438185AADD31B9A04402CB1]
latest-linux-arm64.yml:[FEC3DF05D140D3DECA643A370F71C6C299BF1BBBECEBF55AFD6FC65416D16B1C]
latest-linux.yml:[A231C40DFE3F2A4B37046D67E481C478D42BDAA7882ADF3945E8503586AC55EC]
latest-mac.yml:[39295F000126F204C8DE16568C3B498EA7BF890C04F5B991D7A85AFEE6C351A3]
latest.yml:[47DF1ADE9CDBE5F7B8F7DCDDD78B877D8E6BB17E892DD0FA4C0301A7469249FC]
lokal-music_12.3.1_amd64.deb:[168AF4783210A267A437D193CFEBB13923E8A8567AC74DA9B34066B4C821FBCA]
lokal-music_12.3.1_arm64.deb:[1FF4E16B3A13727D4A8FAEFEA32FB22C3C3A3EB5743419530F1AF75EC7DB8AE7]
