Merge pull request #610 from lokal-music/release/v12.2.1
Changelog
Windows builds: free code signing provided by SignPath.io, certificate by SignPath Foundation (code signing policy).
FYI:
Lokal is 100% local; the library, history, anything in database, or any info that is used for API's such as yt-dlp, LRCLIB, is NOT seen by us.
What's Changed
-
fix(desktop): address remaining Atmos ghost and repair reviews from #607 (#609)
Details
Follow-up to #607
Closes the two unresolved Major CodeRabbit review findings on the already-merged PR #607.
1. Do not replace stereo ghost references with an owned Atmos edition
When an explicit Atmos request finds an existing owned Atmos file,
DownloadManager.enqueuenow returns the existing edition without running either imported-ghost replacement or streamed-ghost replacement. Ordinary stereo downloads retain both existing replacement paths.2. Retain verified Atmos classification on missing-file repair
upgradeTrackFilenow re-probes the replacement physical file throughquality.probeAtmosFileand saves the resultingatmos_verifiedvalue with the replacement's other quality fields. This also prevents an unverified/non-JOC file from inheriting the deleted file's old Atmos designation. The scanner's missing-file duplicate repair uses this upgrade function.Regression coverage
Added tests in
scripts/download-library-sync.test.mjsfor:- Already-owned Atmos edition with stereo ghost in a playlist and Likes; neither imported nor streamed references should move.
- A missing verified Atmos library edition replaced by an actual verified Atmos file; identity and
atmos_verified=1should persist, with both indexing and repair performing a probe.
Verification
Reviewed the precise unresolved review threads, current main code, and diff; branch is three commits ahead of main with just three files changed. Runtime tests have not been executed in this environment; CI and real-media checks remain necessary.
Original review threads: ghost replacement · verification on repair.
Contributors: @CHEYCKIT
Full Changelog: v12.2.0...v12.2.1
Setup
See README.md for full setup instructions.
macOS: this build is ad-hoc signed, not notarized (no Developer ID certificate is configured). The first time, right-click Lokal in Applications and choose Open, or run xattr -dr com.apple.quarantine /Applications/Lokal.app.
Binary Checksums (SHA-256)
Lokal-12.2.1-arm64-mac.zip:
[8D252E22370F6E988857509D808325FA146E0DD4C7444591F64C11A71184D508]
Lokal-12.2.1-arm64-mac.zip.blockmap:[B9794D7A64947F7DE74AB5C33CB29697D5F50A7CC1F529A131B3A5C9A81A13AE]
Lokal-12.2.1-arm64.AppImage:[B2D86EE420254FEED4B937EE497DDE79305861208CDBC125EDB7200C34B486D9]
Lokal-12.2.1-arm64.dmg:[892E1BCFD7AC3A002D2D0890E7ACCF9C438396BB8A53EF518FE49EFD29249247]
Lokal-12.2.1-arm64.dmg.blockmap:[C4138339FA704037B082FE737551D729787F26761D87B5A110E1DA9AC4414578]
Lokal-12.2.1-mac.zip:[EBAAE987FE8594045F39C3AD858BA42E5C0C3D62024E6059DF15AE1296F1B42D]
Lokal-12.2.1-mac.zip.blockmap:[61F0A6298C819E225C4A0C0F73ABB347CDB530589B0951338D6D4CA21FAAB273]
Lokal-12.2.1.AppImage:[503F23C63ABAF0165ECB940E5890B31C8E0BA417FEA7C5584AC22B335AA7AAFF]
Lokal-12.2.1.dmg:[F0C9D78ECD03ECED9D928FBE7F5CDCDDF14117EFECED3E748D8A64C0D20A52E7]
Lokal-12.2.1.dmg.blockmap:[FCD1D08C8F2AE11B60E60DAF01E4DB1A00BF118260E759F8C507D49111180982]
Lokal-12.2.1.exe:[32A05F7AE88DE82AD5F37FAFCD328BA95201259D699E2DBEFD151DDDE6BE68E1]
Lokal-Setup-12.2.1.exe:[BA2E0A1E5C9D9756C5071E776725A30BF9ED424002AED5565BAC96EFDC3784EC]
Lokal-Setup-12.2.1.exe.blockmap:[FAFB98FC4A376D0B5001D6A620BD3A494E3530BDF0AD14B2B2854DEEF78DEEFA]
builder-debug.yml:[D1400EE908E9E87DDB64CDC69E92D24C3BCCED29DBF259E3EC87D34DEA999BE8]
latest-linux-arm64.yml:[4DB08CBB3449AF9E138DB7A72314AEE13798CA34DDC52065EF53166EB66F9E30]
latest-linux.yml:[04D17931294198B96ABAE8A7B05A4FF8634A853A4CA8E94D775703564BBF1223]
latest-mac.yml:[6636886EA2A9887AD06C243B8D2E2402F24D50C140E607D58095F99CBB2DA108]
latest.yml:[C7141E2A5870E10786CFE93308A63314EE1FDABA4F09C39E96ECCF492A8753C1]
lokal-music_12.2.1_amd64.deb:[19821722401D64DC618F6713734EFBF9BED0E616DB7357F62182D77D2E9E8648]
lokal-music_12.2.1_arm64.deb:[72B7E4A5CC76C7BFBE358C261CBAFD773CCBF8BF1A3D25ABA1A4D361D015C8B3]
