Critical Installation Bug Fix + Code Quality Improvements
Overview
This release fixes a critical bug in install.py that prevented 77 lines of Claude Desktop MCP configuration code from executing. Users installing mcp-memory-service will now get proper automatic MCP server setup.
Key Changes
Fixed
- Critical Installation Bug: Removed early
return Falseat line 1358 ininstall.pythat made lines 1360-1436 unreachable- 77 lines of Claude Desktop setup code now properly executes during installation
- Users will now get automatic MCP server configuration when running
install.py - Resolves all 27 pyscn dead code violations identified in issue #240 Phase 1
Improved
- Modernized
install.pywith pathlib throughout (via Gemini Code Assist automated review) - Specific exception handling (OSError, PermissionError, JSONDecodeError) instead of bare
except - Fixed Windows
memory_wrapper.pypath resolution bug (now usesresolve()for absolute paths) - Added config structure validation to prevent TypeError on malformed JSON
- Import optimization and better error messages
- Code structure improvements from 10+ Gemini Code Assist review iterations
Health Score Impact
- Dead Code Score: 70 → 85-90 (projected +15-20 points)
- Overall Health Score: 63 → 68-72 (projected +5-9 points)
Related Issues
- Fixes #240 (Phase 1 of Code Quality Improvements)
- PR #241: fix: resolve dead code in install.py - Phase 1 of issue #240
Installation
pip install --upgrade mcp-memory-service
# or
uv pip install --upgrade mcp-memory-serviceFull Changelog
See CHANGELOG.md for complete details.
What's Next: Issue #240 Phases 2 & 3 will address remaining code quality improvements including complexity reduction and coupling optimization.