Merged PRs
dolt
- 10487: Fix
dolt_cleannot respectingdolt_ignoreanddolt_nonlocal_tablespatterns
Fix #10462- Fix
dolt_ignoreanddolt_nonlocal_tablesnot being excluded fromdolt cleandefault command and SQL interface. - Add
dolt clean-xflag to overridedolt_ignoredeletions; similar togit clean -x.
- Fix
- 10482: commit verification with dolt_tests
This PR adds the ability to perform verification of commit content using the dolt_tests table.
Setting thedolt_commit_verification_groupsystem variable with a comma delimited set of test groups will result in test being run before a commit is completed.
This validation is performed for commit, merge, cherry-pick, and rebase (through cherry-pick). All procedures/CLI operations provide the --skip-verification flag to bypass.
Currently one known bug with a skipped test. Rebase workflow is presenting broken when a commit fails verification, but should be handled like a conflict, which would allow the user to --continue the workflow. - 10450: fix panic for empty table names, now a normal error
go-mysql-server
- 3426: Do not push filters into SubqueryAliases that wrap RecursiveCTEs
fixes #10472
All RecursiveCTEs are wrapped by a SubqueryAlias node. We currently don't push filters through a RecursiveCTE so pushing the filter below the SubqueryAlias just causes it to be awkwardly sandwiched in between and might make some queries less optimal if the filter contains outerscope columns since the SQA gets marked as uncacheable. We probably can push filters through a RecursiveCTE in some cases, but we should spend more time thinking about what that means (see #10490).
Also contains some refactors that I noticed along the way.
skipped tests will be fixed in #3427 - 3425: Do not set scope length during join planning
related to #10472
Scope length should only be set when assigning indexes if the scope length then is not zero. The scope length set during join planning is doesn't actually refer to the correct scope length, and if it was actually supposed to be zero, it was never correct set back to zero, causing a panic.