Merged PRs

dolt

• 9933: Fix performance issue when using large JSON documents in UPDATE statements.
  UPDATE statements return the number of rows that changed as a result of the operation. This requires comparing the new and old values for the rows.
  Because IndexedJsonDocument didn't properly implement the ComparableJSON interface, these values were being fully reconstructed in memory for the comparison, which was needlessly slow. Implementing the interface allows comparing two documents to be logarithmic on document size instead of linear.
• 9928: go: doltcore/remotestorage: Clear our cached repo token when Commit or Rebase are called on the ChunkStore.
  doltremoteapi returns RepoTokens on some RPC interactions. When Dolt mirrors the token back to doltremoteapi, doltremoteapi can check if the current repo state matches the token state and if it does, it can avoid doing some I/O work to refresh its current view of the repository.
  After a Commit(), the client was not clearing its view of the repoToken, and the server was not returning the new RepoToken on a successful commit. This meant that the client was potentially seeing stale data for the repository if its RepoToken represented the previous committed state and if its requests landed on a doltremoteapi replica where that state was also the state of the repository in memory.
  In multi-process concurrency against a ChunkStore, clients are expected to refresh their view of storage after a Commit and after a call to Rebaes. This corresponds to clearing our RepoToken, so that doltremoteapi will Rebase the store and return a new RepoToken which reflects the refreshed state.

go-mysql-server

• 3262: #9927: Fix SQL regression on UnaryMinus NULL CAST
  Fixes #9927
• 3261: Do not convert keys if key type is incompatible with column type
  fixes #9936
  fixes #7372
  makes progress on #9739
• 3260: dolthub/go-mysql-server#3259: Fix system variable lookup to only happen on no qualifier
  Fixes dolthub/go-mysql-server#3259
• 3258: #9935: Add fix for boolean evaluation in analyzer for EXISTS
  Fixes #9935
• 3256: #9927: Fix double negation overflow with Literals
  Fixes #9927
  Fixes #9053
• 3252: Add pure Go regex implementation for non-CGO builds
  This PR provides an optional pure Go regex engine that allows building go-mysql-server without CGO.
  The default build process (using ICU via CGO) remains unchanged.

  Implementation

  • With CGO (default): Uses the existing go-icu-regex library. (internal/regex/regex_cgo.go)
  • Without CGO (CGO_ENABLED=0 or -tags=gms_pure_go): Uses a new implementation based on Go's standard regexp package. (internal/regex/regex_pure.go)
    Build selection is handled via Go build tags.

  Compatibility Notes

  The pure Go engine trades compatibility for portability, as it is based on standard regexp package.
  Notable limitations compared to ICU include:
  • Lack of back-references
  • No before/after text matching
  • Differences in handling CR ('\r')
  • Other minor differences
    This change allows running the server in pure Go for users who can accept the trade-offs, providing greater build flexibility.
• 3251: Condense nested select * from SubqueryAliases into the innermost SubqueryAlias
• 3223: README.md: Add notes to the readme indicating cgo dependency.

Closed Issues

• 9936: Use of invisible hash index under-fetches rows
• 7372: Unexpected results when comparing string with type conversion
• 9927: Incorrect double-negation of integer
• 9935: Incorrect use of negation in AntiJoinIncludingNulls
• 9053: Incorrect negation of minimum signed integer
• 9865: Stored procedure containing a transaction always return EOF as a MySQL error
• 3259: Panic when column is missing and that column is a system variable