Merged PRs

dolt

go-mysql-server

• 3034: Allow drop trigger ... when trigger is invalid
  We should ignore parser errors when trying to drop triggers that are invalid.
  fixes: #9359
• 3032: Generalize types in CASE, IF, and IFNULL
  Fixes #9321
  Generalize types in CASE, IF, and IFNULL as described by MySQL docs
• 3031: Fix 7998 json escape double quotes
  Key write now uses same recursive call to writeMarshalledValue() as value under json_encode.go
  Fixes: #7998
• 3030: Distinguish nils in firstBuffer
  Fixes #9035
  In AggregationBuffer.firstBuffer , the buffer should not update if the first row has already been written. However, there was no way of distinguishing between a nil because the buffer is empty and a nil because the value in that column of the first row is nil.
  When you have two rows (NULL, 1) and (1, NULL), the first row gets written into []firstBuffer.val as {nil, 1}. Because there's no way to tell whether the first value is supposed to be nil, it ends up getting overwritten by the 1 in the second row. Because the second value is not nil, Update skips it. As a result, we end up with a row {1, 1} that matches neither of the original rows and evaluates to TRUE when grouped by c0 = c1, even though the original rows evaluate to NULL.
  This isn't an issue when the rows are (NULL, 1), (NULL, 1) or (1, NULL), (1, NULL) because the nil value remains a nil value when Update is called on the second row.
  I fixed this by adding a writtenNil flag to firstBuffer to indicate that the nil value is meant to be there and should not be overwritten.
• 3029: Fix 9347 panic case statements info schema
  information_schema updated to respect enum type
  Eval() under enum.go is more flexible with strings now
  Fixes: #9347
• 3028: add mysql dialect tag to new group by test
  new group by test added in dolthub/go-mysql-server#3025 is not Postgres/Doltgres compatible
• 3024: Adding skipped tests for UPDATE ... JOIN bugs
• 2994: fix NewServer call
  this is a followup to dolthub/go-mysql-server#2989

Closed Issues

• 9359: Error when trying to drop trigger
• 9347: Panic with case statements in information_schema.tables access
• 9321: Using an IFNULL with TINYINT param restricts the output as TINYINT
• 9355: dolt version 1.56.0 published on dockerhub but latest released version is 1.55.1