Merged PRs

dolt

• 9063: Normalize AUTO_INCREMENT values in tables.
  When the AUTO_INCREMENT field is unset, the value of the next AUTO_INCREMENT column defaults to 1. Thus, setting it to 0 and 1 produce identical behavior.
  By normalizing the value as its written, we ensure that both operations produce the same table hash as if the value was unset.
• 9061: Bug fix for doltgres range iter
• 9059: go: cmd/dolt: commands/sql: Fix the displayed query time in interactive mode after a query completes.
  The migration to subcontexts of the Queryist sql.Context meant that we lost the default setting of the query start time. Restore it in the sql command implementation itself.
• 9050: go,integration-tests/{bats,go-sql-server-driver}: Implement GC sesssion lifecycle validation at the storage layer. Enable checks for bats and go sql server integration tests.
  This makes *NomsBlockStore check the incoming Context object to ensure that it itself has been invovled in the appropriate GC lifecycle callbacks.
  It fixes a problem with statspro.AnalyzeTable, where the GC lifecycle callbacks happened more than once for a single session.
  It fixes some callsites to appropriately make the GC lifecycle callbacks, including LateBindingQueryist opening one session command for the whole lifetime of the returned sql.Context.
• 9047: go: utils/publishrelease/buildpgobinaries.sh: Bump optcross to pick up new dolthub_toolchains changes.
• 9041: go: store/datas/pull: Error handling improvements. Target an approximate file size instead of a number of chunks when uploading files.
  Our old heuristic was to cut a file and start uploading it when it reached a fixed number of chunks. We chose that number of chunks as just (1<<30 / 4096), which is the average chunk size the chunker targets. But the chunk targets pre-compressed sizes. So file uploads which were hitting the target could vary a lot in size. It's better to just track how many bytes we've written so far and cut it when (approximately) appropriate. This is still best effort and only approximately.
  Also improves error handling and structured concurrency a bit. Moves a number of goroutines up to the top-level errgroup in Pull(). Avoids creating – and thus potentially leaking – goroutines in NewPuller(), deferring them until Pull actually gets called. Gets rid of an unnecessary request-response thread structure in the implementation of PullChunkFetcher.
• 9032: integration-tests/go-sql-server-driver: Move max-connections testing to go-sql-server-driver.
• 9029: go: Add some GC lifecycle callbacks to commands which use a local SqlEngine.
• 9023: go: mvdata: Improve dump, import and export so that these commands create a single SqlEngine over their lifetime.
  Pass the SqlEngine along and reuse it in the operations where we dump table contents, parse import schemas, etc.
• 8965: Root Objects
  Counterpart to Doltgres PR:
  • dolthub/doltgresql#1265

go-mysql-server

• 2921: fix not equal conversions
  fixes: #9052
• 2920: fix negative integer limits
  In golang, the negation of the minimum int8, int16, int32, int64 is the same.
  fix: #9053
• 2919: fix double negatives
  We can't apply NOT(NOT(expr)) -> expr optimization if there will be a type conversion involved.
  This PR also fixes bad test involving current timestamps.
  fixes: #9054
• 2918: more precision fixes for unix_timestamp
  Changes:
  • have datetime_type equality to also compare precision
  • retain precision for date and datetime types in a table
    fixes: #9025
• 2916: prevent panics in replacePkSort
  Not sure how to reproduce this, but this should make the code more safe.
  fixes: dolthub/go-mysql-server#2915
• 2914: bump: dolthub/go-icu-regex
• 2912: Support for negative bool values
  Fixes #9036
• 2911: check group by ordinal range
  This PR adds an error check when attempting to group by a column index that is out of range.
  fixes: #9037

Closed Issues

• 9052: Incorrect optimization of operation in expression in WHERE clause
• 9053: Incorrect negation of minimum signed integer
• 9035: NULL in GROUP BY column is interpreted as 1
• 9054: Double negation is treated as original value in WHERE clause
• 9025: unix_timestamp's precision should keep with parameter
• 9051: Dolthub commit changes history loads forever
• 9037: Unexpected crash when using GROUP BY with non-column position
• 2915: Panic when calling min/max (without a Primary Key?)

Performance