Merged PRs
dolt
- 8788: Bug fix: ref conflict can cause tags to be temporarily removed on a replica
The read replica code that compares remote refs and local refs to determine which local refs need to be deleted when synchronizing a read replica from a remote had a problem where certain patterns of ref names could cause the code to select the wrong local refs to remove. These removed refs would not be present on the replica until a future synchronization run recreated them.
The fix for this is to use theRef.String()
method (instead ofRef.GetPath()
) to get a unique identifier for the ref (e.g.refs/tags/t1
) and to ensure that the remote and local ref lists are both sorted by that unique identifier. - 8787: better
nil
transaction checking forcommit
s - 8781: implement and test
drop temporary table ...
andshow create table
statements
addresses the related issue here: #8762 - 8780: go/store/types: Move to a safepoint controller which will allow a caller better control over when to take actions while the GC is running.
- 8777: Bump undici from 5.28.4 to 5.28.5 in /.github/actions/ses-email-action
Bumps undici from 5.28.4 to 5.28.5.Release notes
Sourced from undici's releases.
v5.28.5
⚠️ Security Release ⚠️
Fixes CVE CVE-2025-22150 GHSA-c76h-2ccp-4975 (embargoed until 22-01-2025).
Full Changelog: nodejs/undici@v5.28.4...v5.28.5
Commits
6139ed2
Bumped v5.28.5711e207
Backport of c2d78cd- See full diff in compare view
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=undici&package-manager=npm_and_yarn&previous-version=5.28.4&new-version=5.28.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) ---Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/dolthub/dolt/network/alerts). - 8773: Fix failing MacOS BATS tests
Testing Dolt'scaching_sha2_password
auth support with themysql
client on MacOS recently started failing with:mysql: command not found
These tests were previously working, but themysql
client seems to no longer be available. This change adds a new step to ensure the current LTSmysql
client is installed.
These tests normally run nightly, but they passed in an earlier CI run on this PR that triggered them. - 8767: implement implicit commits and fix import behavior
This PR implements the implicit commit logic introduced in this PR dolthub/go-mysql-server#2818
On error,dolt table import -c
does not create the table, and we did that by simply rolling back the existing transaction.
Since DDL statements now implcitlyCOMMIT
, we need to start a new transaction, and possibly drop any tables created.
fixes #7485
maybe fixes: #8716 - 8739: Create dolt_help system table
Created the dolt_help system table. This table is meant to store documentation for system tables, procedures, functions, and variables. Currently dolt_help is only populated with documentation for procedures, and only procedures that have equivalent CLI commands.
Part of #7984
go-mysql-server
- 2824: implement
drop temporary table ...
and displaytemporary in show create table statements
In-memory database doesn't support temporary tables, so tests are here: #8781
fixes: #7992 - 2822: Bug fix: record
last_insert_id
when 0 is specified for the auto_increment column value
fixes: #8769 - 2819: Don't force a table rewrite when appending extra values to the end of an enum.
Adding extra strings to the end of an enum type doesn't change the values for any of the existing strings. A table rewrite isn't necessary in this case.
If a specific table implementation does need to be rewritten when an enum type changes this way, they can still implementShouldRewriteTable
in order to force a rewrite anyway. - 2818: implicit commit on ddl statements
Certain queries ignore autocommit, and will implicitly commit the transaction.
vitess
- 395: syntax for
drop temporary table ...
- 394: parse more partition options in
ALTER TABLE
statements
parses more partition options as no-ops
fixes: #8744
Closed Issues
- 8716: Multiple Users report "table not found" errors when using Dolt under concurrency
- 7980: Create a config.yaml file when database server is first run
- 7992:
SHOW CREATE TABLE
doesn't includeTEMPORARY
for temporary tables - 7485: MySQL DDL ignores autocommit transactionality
- 8769:
last_insert_id
gives 0 when 0 is explicitly specified for anauto_increment
primary key in an insertion