Merged PRs
dolt
- 8494: Fix bounds check in import scanner
fixes: #8495
The before code checks whethers.i
is valid after doing the buffer access:The after code inverts the check to make surefor ; unicode.IsSpace(rune(s.buf[s.i])); s.i++ { if s.i >= s.fill { s.read() } }
s.i
is valid before indexing into the buffer.for { if s.i >= s.fill { s.read() } if !unicode.IsSpace(rune(s.buf[s.i])) { break } s.i++ }
- 8479: cross-schema foreign key support for doltgres tables
Depends on dolthub/go-mysql-server#2713
go-mysql-server
- 2717: push
Distinct
nodes belowSort
nodes
This PR optimized queries like:When there are many duplicate values in columnselect distinct i from t order by i;
i
, it is much more efficient to eliminate duplicates first, then sort the results.
There are somewhat unrelated optimizations left as TODOs.
Optimize query: #8488 - 2716: Update Parser interface documentation
Updates documentation for theParser
interface to document the requirement that implementations must returnvitess.ErrEmpty
for empty queries. Without this, GMS will not handle empty queries correctly.
Related to: dolthub/doltgresql#884 - 2715: remove exchange node
These aren't used anywhere, so it's getting removed.
Partition still exists if we ever want to reimplement some version of this. - 2713: Support for schema names in foreign key definitions
Adds schema names in many places required for foreign key operation in databases with schemas (doltgres)
Closed Issues
- 8495: Import scanner performs bound check after buffer access