Merged PRs
dolt
- 8534: Fix issue where JSON diff would fail under specific circumstances.
If all of the following are true during a JSON diff operation:- One document fits in a single chunk and the other doesn't
- The location of the chunk boundary in the larger document is also present in the smaller document. (It doesn't correspond to a location that was added or removed)
- The chunk boundary falls at the end of a value in the document (before the next key or comma/right brace/etc)
Then the differ would fail to advance the prolly tree cursor and would incorrectly see the larger document as corrupt.
This fixes that issue and improves the error messaging to make it seem less like the database is corrupt, since the error is much more likely to be a parsing bug like this one.
Closed Issues
- 8530: Materialized View Gives PrivilegedDatabase Error
Performance
| Read Tests | MySQL | Dolt | Multiple |
|---|---|---|---|
| covering_index_scan | 2.11 | 0.61 | 0.3 |
| groupby_scan | 12.98 | 16.71 | 1.3 |
| index_join | 1.37 | 2.26 | 1.6 |
| index_join_scan | 1.3 | 1.82 | 1.4 |
| index_scan | 34.33 | 55.82 | 1.6 |
| oltp_point_select | 0.18 | 0.27 | 1.5 |
| oltp_read_only | 3.49 | 5.37 | 1.5 |
| select_random_points | 0.34 | 0.65 | 1.9 |
| select_random_ranges | 0.39 | 0.64 | 1.6 |
| table_scan | 34.95 | 55.82 | 1.6 |
| types_table_scan | 75.82 | 147.61 | 1.9 |
| reads_mean_multiplier | 1.5 |
| Write Tests | MySQL | Dolt | Multiple |
|---|---|---|---|
| oltp_delete_insert | 7.98 | 5.77 | 0.7 |
| oltp_insert | 3.75 | 2.91 | 0.8 |
| oltp_read_write | 8.58 | 11.24 | 1.3 |
| oltp_update_index | 3.89 | 2.91 | 0.7 |
| oltp_update_non_index | 3.89 | 2.86 | 0.7 |
| oltp_write_only | 5.37 | 5.88 | 1.1 |
| types_delete_insert | 7.7 | 6.09 | 0.8 |
| writes_mean_multiplier | 0.9 |
| TPC-C TPS Tests | MySQL | Dolt | Multiple |
|---|---|---|---|
| tpcc-scale-factor-1 | 99.97 | 41.75 | 2.4 |
| tpcc_tps_multiplier | 2.4 |
| Overall Mean Multiple | 1.60 |
|---|