Merged PRs
dolt
- 8289: User Contribution Fixup
Revised: #8246
Fixes: #8221 - 8288: Skip filter iter, with more test fixes
This is the same as #8242 with one change and new test in GMS dolthub/go-mysql-server#2639. The change prevents string comparisons from skipping range.Matches, because the index range iterators can return false positives/prefix matches. - 8281: Db/dolt ci events init
- 8246: Fixed grammar typos re issue #8221
Solved ./go typos as requested in #8221. This was my first-ever big project contribution, even if it's simple, so hope I followed procedure appropriately :)
go-mysql-server
- 2637: Adding a test combining duplicate indexes through
create table
andalter table
Additional test case for dolthub/go-mysql-server#2634 - 2635: Fix multi-statements in nested triggers
changes:- have different savepoint names
- this fixes nested triggers overwriting save points and clearing the same savepoint
- handle aliases independently for each statement in trigger blocks
- sync up prepend and scope nesting for triggers
- wrap
applyTrigger
rule wrapstriggerExecutor
s over individual statements inBeginEndBlock
s - this prevents wrapping
triggerExecutor
s over the wrong statements (not matching event or table)
related: #8213
- 2634: Adding tests for supporting duplicate secondary indexes
New tests asserting that multiple indexes over the same set of columns can be created on tables.
#8274 fixes Dolt for these tests to pass.
Closed Issues
- 8221: Fix Grammar Typos in Go Comments
- 8213: nested (delete) triggers have the wrong context in the nested call
- 8250: Permission for the home directory: panic: runtime error: invalid memory address or nil pointer dereference
Performance
Read Tests | MySQL | Dolt | Multiple |
---|---|---|---|
covering_index_scan | 2.18 | 0.68 | 0.3 |
groupby_scan | 12.98 | 16.41 | 1.3 |
index_join | 1.39 | 2.66 | 1.9 |
index_join_scan | 1.3 | 2.14 | 1.6 |
index_scan | 34.95 | 54.83 | 1.6 |
oltp_point_select | 0.18 | 0.3 | 1.7 |
oltp_read_only | 3.49 | 5.77 | 1.7 |
select_random_points | 0.34 | 0.65 | 1.9 |
select_random_ranges | 0.39 | 0.69 | 1.8 |
table_scan | 34.95 | 54.83 | 1.6 |
types_table_scan | 75.82 | 144.97 | 1.9 |
reads_mean_multiplier | 1.6 |
Write Tests | MySQL | Dolt | Multiple |
---|---|---|---|
oltp_delete_insert | 7.98 | 5.99 | 0.8 |
oltp_insert | 3.75 | 2.97 | 0.8 |
oltp_read_write | 8.58 | 11.87 | 1.4 |
oltp_update_index | 3.89 | 3.02 | 0.8 |
oltp_update_non_index | 3.89 | 2.97 | 0.8 |
oltp_write_only | 5.37 | 6.09 | 1.1 |
types_delete_insert | 7.7 | 6.43 | 0.8 |
writes_mean_multiplier | 0.9 |
TPC-C TPS Tests | MySQL | Dolt | Multiple |
---|---|---|---|
tpcc-scale-factor-1 | 100.08 | 39.36 | 2.5 |
tpcc_tps_multiplier | 2.5 |
Overall Mean Multiple | 1.67 |
---|