Merged PRs
dolt
- 7159: Bug fix:
dolt_blame_<tablename>
view should backtick quote identifiers
Fixes thedolt_blame_<tablename>
view definitions so that table names and primary key column names are backtick quoted. Without this, customers can't use thedolt_blame_<tablename>
views if the table name or primary key columns contain characters (e.g. "-") that require identifier quoting. - 7151: go: Migrate to always use Try accessors on flatbuffer submessage access.
- 7145: fix
column_diff_table
for modifed json columns
JSON types are represented asmap[string]interface{}
, which panics in Golang when used with!=
operator.
This PR changes the logic to use ourgmstypes.Compare()
logic instead,
fixes #7140 - 7143: Poorly formatted version doesn't error
Fixes an issue where bad data inversion_check.txt
returns an error. This change makes version overwrite any bad data in this file instead.
Fixes: #7138
go-mysql-server
- 2198: fix decimal/float conversion for
HashInTuple
expressions
fixes #7147 - 2197: prevent RangeJoinHeap plans over Filter nodes
Currently, we don't have proper handling of nodes that aren'tRangeHeap
s in theRangeJoinIter
.
This PR makes it so that we don't create plans that would have these nodes.
Additionally, we error instead of panicking when we see an invalid node in this area.
fixes #7139 - 2195: fix type promotion for in expressions
TODO: check type promotion for int -> float/decimal for all expressions
fixes #7120
Closed Issues
- 7139: panic: interface conversion: sql.Node is *plan.Filter, not *plan.RangeHeap
- 7138: dolt version "broken" (?) in 1.29.3
- 7147: Unexpected Results of In expressions
- 7140: Panic when trying to filter
dolt_column_diff
table
Latency
Read Tests | MySQL | Dolt | Multiple |
---|---|---|---|
covering_index_scan | 2.14 | 2.86 | 1.3 |
groupby_scan | 12.98 | 17.63 | 1.4 |
index_join | 1.34 | 5.0 | 3.7 |
index_join_scan | 1.25 | 2.14 | 1.7 |
index_scan | 34.33 | 55.82 | 1.6 |
oltp_point_select | 0.17 | 0.43 | 2.5 |
oltp_read_only | 3.3 | 7.7 | 2.3 |
select_random_points | 0.32 | 0.73 | 2.3 |
select_random_ranges | 0.38 | 0.87 | 2.3 |
table_scan | 34.33 | 55.82 | 1.6 |
types_table_scan | 74.46 | 158.63 | 2.1 |
reads_mean_multiplier | 2.1 |
Write Tests | MySQL | Dolt | Multiple |
---|---|---|---|
oltp_delete_insert | 5.28 | 5.88 | 1.1 |
oltp_insert | 2.66 | 2.86 | 1.1 |
oltp_read_write | 7.17 | 14.73 | 2.1 |
oltp_update_index | 2.66 | 3.02 | 1.1 |
oltp_update_non_index | 2.71 | 2.97 | 1.1 |
oltp_write_only | 3.89 | 7.17 | 1.8 |
types_delete_insert | 5.28 | 6.43 | 1.2 |
writes_mean_multiplier | 1.4 |
Overall Mean Multiple | 1.7 |
---|