Merged PRs
dolt
- 7136: Better messaging for
dolt login
Updates the messaging fordolt login
to have more clear instructions if a browser does not automatically open.
Resolves: #7133
go-mysql-server
- 2196: Prepend subquery scope to sql.TableFunction nodes
Most but not all table functions implement sql.Table. Table functions that do not implement sql.Table still need to return prepended rows to maintain indexing rules. - 2195: fix type promotion for in expressions
TODO: check type promotion for int -> float/decimal for all expressions
fixes #7120 - 2193: Set the
original_name
field in response metadata in addition to thename
field
A customer reported that the MySQL C++ Connector library was unable to retrieve column name information from a Dolt sql-server. After looking at the two wire captures between MySQL and Dolt, this is because the MySQL C++ Connector library pulls the column name from theoriginal_name
field, not from thename
field.
I've updated the unit tests that assert the expected response metadata fields are populated, and I'll follow up next with some changes in the Dolt repo to our C++ Connector library acceptance tests so that they use response metadata and assert that it is filled in.
After that, it would be good to proactively look at any other response metadata fields that we aren't setting. For example, theFlags
field seems important to fill in correctly for tooling to use.
Closed Issues
- 7133:
dolt login
should give better error message if it can't open a browser - 7120: Unexpected Results when Using IN for Floating-Point
- 7040: Support unique indexes on
TEXT
fields without a prefix length (MariaDB compatibility)
Latency
Read Tests | MySQL | Dolt | Multiple |
---|---|---|---|
covering_index_scan | 2.18 | 2.86 | 1.3 |
groupby_scan | 12.98 | 17.32 | 1.3 |
index_join | 1.37 | 5.0 | 3.6 |
index_join_scan | 1.27 | 2.14 | 1.7 |
index_scan | 33.72 | 55.82 | 1.7 |
oltp_point_select | 0.17 | 0.43 | 2.5 |
oltp_read_only | 3.3 | 7.7 | 2.3 |
select_random_points | 0.32 | 0.72 | 2.2 |
select_random_ranges | 0.38 | 0.86 | 2.3 |
table_scan | 34.33 | 55.82 | 1.6 |
types_table_scan | 74.46 | 161.51 | 2.2 |
reads_mean_multiplier | 2.1 |
Write Tests | MySQL | Dolt | Multiple |
---|---|---|---|
oltp_delete_insert | 5.57 | 5.99 | 1.1 |
oltp_insert | 2.76 | 2.91 | 1.1 |
oltp_read_write | 7.3 | 14.73 | 2.0 |
oltp_update_index | 2.76 | 3.07 | 1.1 |
oltp_update_non_index | 2.81 | 2.97 | 1.1 |
oltp_write_only | 3.96 | 7.17 | 1.8 |
types_delete_insert | 5.37 | 6.55 | 1.2 |
writes_mean_multiplier | 1.3 |
Overall Mean Multiple | 1.7 |
---|