Merged PRs
dolt
- 6701: Test the privilege serialization doesn't write empty databases
Related: dolthub/go-mysql-server#2018
go-mysql-server
- 2029: Return innodb_lock_wait_timeout=1 always
See: #4190 - 2025: Failure to push filter causes dropped filter
We make a hard assumption during join planning that there are no errant filters in the join tree. Every filter is either a join edge, or sitting on its relation. When this is not true, the memo can generate a transitive edge between two relations that loses track of the original filter. The process for triggering this bug is 1) filter in an ON condition gets moved to the middle of the tree, 2) the filter fails to get pushed to its join edge/relation, 3) we generate a transitive join edge that loses track of that filter, and then 4) we choose the transitive join edge in costing.
You'll see the filter restored in the integration query plans in the PR. I added a minimal repro with the appropriate ON conditions and forced a transitive edge that drops the filter if pushdown regresses in the future.
vitess
- 276: Allow parsing of
SECONDARY_ENGINE = NULL
This is a simple change to allow parsing a NULL value for the SECONDARY_ENGINE attribute for CREATE TABLE and ALTER TABLE statements. - 275: Adding parser support for
VISIBLE
andINVISIBLE
modifiers for indexes
Fixes: #6690
Closed Issues
Latency
Read Tests | MySQL | Dolt | Multiple |
---|---|---|---|
covering_index_scan | 2.07 | 2.91 | 1.4 |
groupby_scan | 12.98 | 17.95 | 1.4 |
index_join | 1.27 | 4.74 | 3.7 |
index_join_scan | 1.21 | 2.22 | 1.8 |
index_scan | 33.12 | 57.87 | 1.7 |
oltp_point_select | 0.14 | 0.39 | 2.8 |
oltp_read_only | 2.66 | 7.17 | 2.7 |
select_random_points | 0.3 | 0.72 | 2.4 |
select_random_ranges | 0.37 | 0.95 | 2.6 |
table_scan | 33.12 | 57.87 | 1.7 |
types_table_scan | 74.46 | 170.48 | 2.3 |
reads_mean_multiplier | 2.2 |
Write Tests | MySQL | Dolt | Multiple |
---|---|---|---|
bulk_insert | 0.001 | 0.001 | 1.0 |
oltp_delete_insert | 5.77 | 5.88 | 1.0 |
oltp_insert | 2.76 | 3.02 | 1.1 |
oltp_read_write | 6.43 | 14.21 | 2.2 |
oltp_update_index | 2.81 | 2.97 | 1.1 |
oltp_update_non_index | 2.91 | 2.91 | 1.0 |
oltp_write_only | 3.82 | 7.17 | 1.9 |
types_delete_insert | 5.47 | 6.32 | 1.2 |
writes_mean_multiplier | 1.3 |
Overall Mean Multiple | 1.8 |
---|