Merged PRs
dolt
- 6523: Changing primary index to use the Rewriter function, instead of Mutate
Ensures that the tuple descriptors use the correct types, and don't do address validation on unnecessary data.
go-mysql-server
- 1949: Revert "Merge pull request #1944 from dolthub/zachmu/timestamp"
This reverts commit ca69015243946a0a42a0ec6a225da9c4551a0e12, reversing changes made to c11b504a18c48671c29c1494460f662e1f13f712. - 1944: Changed datetime and timestamp types to honor precision and default to 0 digit precision
This matches the MySQL behavior.
Partial fix for #6503 - 1915:
ANSI_QUOTESsupport for go-mysql-server
Now that our parser has support for parsing in ANSI_QUOTES mode and treating double quotes as identifier quotes, this PR starts using that support when we parse queries. The main changes in this PR are:- a new
SqlModetype to make it easier to load SQL_MODE and inspect enabled modes. - tracks SQL_MODE when a procedure/trigger/view is created.
- passes ParserOptions to the parser, to enable parsing in ANSI_QUOTES mode.
- connects the Vitess error logger to GMS' error log, so that errors in Vitess aren't swallowed (currently if a statement in a ComPrepare message doesn't parse, GMS doesn't log anything).
Dolt has a similar, corresponding PR: #6465
Related to: #6305
- a new
vitess
- 264: Revert dolthub/vitess#261
Change in description breaks prepared statements that send a value with character data above the max size of a CHAR column (256 bytes).
Fixes dolthub/dolthub-issues#489
Closed Issues
Latency
| Read Tests | MySQL | Dolt | Multiple |
|---|---|---|---|
| covering_index_scan | 2.07 | 3.02 | 1.5 |
| groupby_scan | 12.98 | 18.28 | 1.4 |
| index_join | 1.25 | 4.82 | 3.9 |
| index_join_scan | 1.21 | 2.39 | 2.0 |
| index_scan | 32.53 | 58.92 | 1.8 |
| oltp_point_select | 0.14 | 0.45 | 3.2 |
| oltp_read_only | 2.71 | 7.98 | 2.9 |
| select_random_points | 0.31 | 0.83 | 2.7 |
| select_random_ranges | 0.37 | 1.18 | 3.2 |
| table_scan | 32.53 | 57.87 | 1.8 |
| types_table_scan | 75.82 | 170.48 | 2.2 |
| reads_mean_multiplier | 2.4 |
| Write Tests | MySQL | Dolt | Multiple |
|---|---|---|---|
| bulk_insert | 0.001 | 0.001 | 1.0 |
| oltp_delete_insert | 4.57 | 5.88 | 1.3 |
| oltp_insert | 2.26 | 2.86 | 1.3 |
| oltp_read_write | 5.88 | 15.27 | 2.6 |
| oltp_update_index | 2.26 | 2.91 | 1.3 |
| oltp_update_non_index | 2.26 | 2.86 | 1.3 |
| oltp_write_only | 3.25 | 7.43 | 2.3 |
| types_delete_insert | 4.57 | 6.32 | 1.4 |
| writes_mean_multiplier | 1.6 |
| Overall Mean Multiple | 2.1 |
|---|