Merged PRs
dolt
- 5865: Drop the formatting flag from the engine
Small step to untangling shell and query engine. #3922
Existing tests cover behavior. This is a fairly straight forward refactor. - 5863: Testing dolt commit in branch control bats tests
This case was not tested and a customer was having issues so improved our tests - 5823: Two code clean ups
- More the format flag out of the sql engine. It's only used by the sql command, and causes confusion
- Drop the Dbddl code path. It's not longer required.
go-mysql-server
- 1751: Unions finalize subquery expressions
The SUBQUERY -> UNION -> SUBQUERY_EXPR pattern was subject to an edge case where the outer SUBQUERY disabled recursively finalizing the inner SUBQUERY_EXPR. The intervening UNION node blocked the outer reach, but failed to re-enable finalizeSubquery during finalizeUnion. This PR edits the finalizeUnionSelector to explicitly re-enable finalize nested subqueries.
This PR also toucheshoistOutOfScopeFilters
for the same edge case.
Issue: #5875 - 1747: Added latin1_spanish_ci and latin1_danish_ci collations
Fixes #5866 - 1746: update
json_set
support for edge cases
updated logic ofjson_set
to support more input edge cases - 1743: Optimize division with integers by using floats internally instead of decimal.Decimal
Fix for #5832
Seems unlikely to break anything in Dolt, but I went ahead and ran Dolt CI tests: #5857
vitess
- 234: go/netutil/conn.go: Avoid panicing when ConnWithTimeouts has a Set{,}Deadline method called.
Clients does not expect setting deadlines on connections to panic. In particular, the standard library's TLS implementation adopts an existing net.Conn and will call SetWriteDeadline on it in certain cases.
It makes more sense to allow the deadlines to be managed by the client when they see fit. This changes the behavior to simply forward the deadlines along as soon as the client code has shown an interest in managing the deadlines. - 231: support 'show events' statement parsing
- Added support for
SHOW EVENTS
statement parsing - Added support for
SHOW CREATE EVENT
statement parsing - Removed
FULL
option fromSHOW TRIGGERS
as it's not supported in MySQL.
- Added support for
Closed Issues
- 5019: Feature request: Optimize initialization for large databases
- 5877: PHP Client drops connection on empty
call dolt_commit
- 5839: SIGSEGV when attempting to create a new branch while in detached head state.
- 5744: Panic if trying to create a commit on a "use"d tag
- 4570: Three-way merge does not handle type changes
- 5866: Collation latin1_spanish_ci not implemented
- 5568: limit in subquery pushed above where clause
- 5659: Implement SQL function
find_in_set
- 5808: Database won't start after import
- 5183: One-time "optimistic lock failed on database Root update" on read replicas after dolt upgrade
Latency
Read Tests | MySQL | Dolt | Multiple |
---|---|---|---|
covering_index_scan | 1.89 | 2.71 | 1.4 |
groupby_scan | 12.08 | 16.41 | 1.4 |
index_join | 1.18 | 4.03 | 3.4 |
index_join_scan | 1.14 | 2.07 | 1.8 |
index_scan | 30.81 | 55.82 | 1.8 |
oltp_point_select | 0.15 | 0.5 | 3.3 |
oltp_read_only | 2.86 | 8.58 | 3.0 |
select_random_points | 0.29 | 0.75 | 2.6 |
select_random_ranges | 0.35 | 1.14 | 3.3 |
table_scan | 30.81 | 55.82 | 1.8 |
types_table_scan | 70.55 | 170.48 | 2.4 |
reads_mean_multiplier | 2.4 |
Write Tests | MySQL | Dolt | Multiple |
---|---|---|---|
bulk_insert | 0.001 | 0.001 | 1.0 |
oltp_delete_insert | 5.37 | 5.99 | 1.1 |
oltp_insert | 2.52 | 2.97 | 1.2 |
oltp_read_write | 6.55 | 15.55 | 2.4 |
oltp_update_index | 2.61 | 3.07 | 1.2 |
oltp_update_non_index | 2.66 | 3.02 | 1.1 |
oltp_write_only | 3.75 | 7.3 | 1.9 |
types_delete_insert | 5.28 | 6.79 | 1.3 |
writes_mean_multiplier | 1.4 |
Overall Mean Multiple | 2.0 |
---|