Merged PRs
dolt
- 5864: go/libraries/doltcore/env/actions/remotes.go: Don't put chunks.TableFile instances into a map, since implementations can have embedded closures.
Just hash the TableFiles by their IDs.
This fixes a crash onbackup restorewhen restoring from a backup which: (1) uses nbs.NomsBlockStore (for example, gs://, or file://) and (2) transiting any given TableFile takes > 500ms. This is most likely to happen with gs:// remotes.
Closed Issues
Latency
| Read Tests | MySQL | Dolt | Multiple |
|---|---|---|---|
| covering_index_scan | 1.93 | 2.76 | 1.4 |
| groupby_scan | 12.3 | 16.41 | 1.3 |
| index_join | 1.21 | 4.1 | 3.4 |
| index_join_scan | 1.14 | 2.11 | 1.9 |
| index_scan | 31.37 | 55.82 | 1.8 |
| oltp_point_select | 0.14 | 0.5 | 3.6 |
| oltp_read_only | 2.86 | 8.58 | 3.0 |
| select_random_points | 0.29 | 0.77 | 2.7 |
| select_random_ranges | 0.35 | 1.14 | 3.3 |
| table_scan | 31.37 | 55.82 | 1.8 |
| types_table_scan | 71.83 | 170.48 | 2.4 |
| reads_mean_multiplier | 2.4 |
| Write Tests | MySQL | Dolt | Multiple |
|---|---|---|---|
| bulk_insert | 0.001 | 0.001 | 1.0 |
| oltp_delete_insert | 5.57 | 6.32 | 1.1 |
| oltp_insert | 2.81 | 3.02 | 1.1 |
| oltp_read_write | 6.79 | 15.83 | 2.3 |
| oltp_update_index | 2.86 | 3.13 | 1.1 |
| oltp_update_non_index | 3.02 | 3.13 | 1.0 |
| oltp_write_only | 4.03 | 7.56 | 1.9 |
| types_delete_insert | 5.47 | 7.17 | 1.3 |
| writes_mean_multiplier | 1.4 |
| Overall Mean Multiple | 2.0 |
|---|