Merged PRs

dolt

• 5809: Add dolt_ignore system table.
  Some notes:
  1. The implementation of dolt_ignore is slightly more complicated than the implementation of existing writable persisted system tables (like dolt_procedures and dolt_docs), but I think it's better this way.
     For context, tables like dolt_procedures exist as DoltTables stored in the user's db alongside user created tables. The user can read and write from these tables, but cannot create, drop, or alter them. CLI commands reference these tables and create them if they don't already exist. This works, but it means that the logic that governs these tables is spread out across the different commands that interact with them, and the user can't interact with them until running a command that creates them.
     dolt_ignore works slightly differently: it's backed by a DoltTable, but it also has its own sql.Table implementation. This allows us to define behavior for when the backing table hasn't been created yet: reads return an empty index, and writes create the table. As far as the mysql engine is concerned, this table always exists. So for the commands that care about dolt_table, the logic can be simpler.
  2. I'm not entirely happy with the implementation: I end up defining the schema twice, once as an sql.Schema, and once as a schema.Schema. I couldn't find an easy way to convert between them. If there's discrepancies between the two definitions, it could cause issues.
  3. dolt_ignore only works with FORMAT_DOLT at the moment. If using FORMAT_LD, the table will be ignored by dolt add and dolt_stash. There's no reason it can't work with FORMAT_LD, but the logic for getting a RowIter from an Index is slightly different and I didn't invest the time to figure it out. This is currently only documented in a comment, but can be documented more widely if needed.
  4. dolt_ignore only affects the staging and stashing of untracked files. This is consistent with git's behavior. If a table that has already been added, dolt_ignore will not prevent further changes to it. It also won't prevent a staged table from being renamed, either to or from an ignored table name.

Closed Issues

Latency