Merged PRs
dolt
- 5475: proto/third_party: Bump versions.
- 5474: go/libraries/doltcore/remotesrv: Add some rudimentary input validation on request messages.
- 5472: go/store/nbs: fix re-entrant deadlock in journal_writer
- 5469: bug fix: binlog multi-db support
We were missing the call to set the session's current database for binlogQuery
events. This was causing queries to execute against the wrong database when using binlog replication with multiple databases. Our binlog tests didn't catch this because the multi-db tests used fully qualified table names, so it didn't matter what database was currently selected.
This change adds the call to set the current database and updates the multi-db tests to use a mix ofuse
statements and fully qualified table names (and also cleans up some of our query error logging to make log output more helpful for debugging). - 5461: go/doltcore/migrate: modify migrated tuples sink to sort incoming tuples
#4221 alters tuple ordering for NBF__LD_1__
to sortNULL
fields last. In NBF__DOLT__
,NULL
fields are ordered first. This change todolt migrate
sorts migrated tuples on-the-fly to compensate for this mismatch - 5347: add stash to clientEventType
go-mysql-server
- 1629: add support for
!
and fixNOT
operator not working for UPDATE trigger!
was not supported forIF
clause inTRIGGER
statementsNOT
clause was not working forUPDATE
TRIGGER
statements
- 1627: Made signal statements work with user vars
Fixes #5452
Closed Issues
- 5379: Running a GetRepoMetadata request against the remotesrv within the sql-server, without data crashes the sql-server
- 5470: Error: "unsupported feature: unary operator: !" in IF in trigger definition
- 3770: Support DELETE JOINs
- 5452: dolt sql fails fails with "syntax error" on importing a trigger definition
- 5453: dolt panics in query "unknown type" in memo.go
Latency
Read Tests | MySQL | Dolt | Multiple |
---|---|---|---|
covering_index_scan | 1.93 | 2.66 | 1.4 |
groupby_scan | 12.3 | 16.41 | 1.3 |
index_join | 1.16 | 4.18 | 3.6 |
index_join_scan | 1.12 | 2.07 | 1.8 |
index_scan | 30.26 | 51.94 | 1.7 |
oltp_point_select | 0.15 | 0.48 | 3.2 |
oltp_read_only | 3.02 | 8.43 | 2.8 |
select_random_points | 0.3 | 0.74 | 2.5 |
select_random_ranges | 0.35 | 1.12 | 3.2 |
table_scan | 30.81 | 52.89 | 1.7 |
types_table_scan | 69.29 | 158.63 | 2.3 |
reads_mean_multiplier | 2.3 |
Write Tests | MySQL | Dolt | Multiple |
---|---|---|---|
bulk_insert | 0.001 | 0.001 | 1.0 |
oltp_delete_insert | 2.61 | 12.3 | 4.7 |
oltp_insert | 1.32 | 2.91 | 2.2 |
oltp_read_write | 5.0 | 17.63 | 3.5 |
oltp_update_index | 1.34 | 6.09 | 4.5 |
oltp_update_non_index | 1.34 | 6.67 | 5.0 |
oltp_write_only | 2.14 | 8.9 | 4.2 |
types_delete_insert | 2.76 | 13.22 | 4.8 |
writes_mean_multiplier | 3.7 |
Overall Mean Multiple | 2.9 |
---|