Merged PRs
dolt
- 5169: Fix log table RowCount panic
CommitClosure
methods are not nil-safe, check before callingCommitClosure.Count()
. - 5167: Removed branch control database file size limitation
The resulting database file is fully compatible with older dolt clients since the read path skips the size and noms prefix. Switching the strings toCreateShared
also gave a decent space savings as well.
To see if there was a noticeable performance difference, I tried removing everything except for the binlog, and reconstructing the branch control tables from the binlog, and the differences were negligible. The resulting file was definitely smaller, but performance-wise there wasn't much difference when reading or writing from the file. We spend so much time in the engine that it doesn't really matter. So I decided to go this route since we still retain full compatibility. - 5137: System Table to-commit/commit-hash lookups
Filters and joins on system tables can take use commit hashes in
equality filters as direct lookups into the node store. System tables
reject non-point lookups.
Missingfrom_commit
optimizations.
go-mysql-server
- 1546: add
information_schema.parameters
table
Addedinformation_schema.parameters
table.
Removinggrant option
privileges being granted incorrectly ingrant all
statement. - 1545: Merge join panicked with non-comparator filter expression
Merge joins are only created with a subset ofexpression.Comparer
filters today (EQUALS). We previously expected a single comparer filter at exec time. But when there are multiple filters, the parent filter expression will be an AND, and the type cast fails.
Instead of force casting the filter to a comparer during exec iter building, we will now expect a conjunction of comparers. For simplicity, we join on the first filter and add a parent filter iter with the rest. Alternatively, we could limit merge joins to single filters, or expend the memo to accommodate filters moved out of join conditions during join exploration. - 1544: fix for information schema tables collation and charset values
- 1543: Validate lookup selection before adding to memo
- 1542: Support decimal literals.
Fixes #5068 - 1541: truncate really long queries
- 1540: Validate the lookup expression for indexedTableAccess
The interface for converting a table scan to an indexedTableAccess disregarded whether the index implementation supported a specific type of range expression. The introduction of commit hash indexes for system tables requires us to prevent arbitrary range lookups, permitting only point lookups. - 1535: add some information_schema privileges and constants tables
Tables added:SCHEMA_PRIVILEGES
TABLE_PRIVILEGES
USER_PRIVILEGES
KEYWORDS
ST_GEOMETRY_COLUMNS
ST_SPATIAL_REFERENCE_SYSTEMS
SCHEMATA_EXTENSIONS
ST_UNITS_OF_MEASURE
USER_ATTRIBUTES
-attributes
column is missing.COLUMNS_EXTENSIONS
-engine_attribute
andsecondary_engine_attribute
are reserved for future use.TABLES_EXTENSIONS
-engine_attribute
andsecondary_engine_attribute
are reserved for future use.TABLES_CONSTRAINTS_EXTENSIONS
-engine_attribute
andsecondary_engine_attribute
are reserved for future use.
Closed Issues
- 5068: dolt doesn't handle large numbers without a cast