Merged PRs
dolt
- 5160: change --out-and-err to append to existing file
- 5157: Fix
call DOLT_VERIFY_CONSTRAINTS()
false-positive
Fix for bug reported by Fritter in Discord.
Here's what happened:- Parent table has a simple pk
- Child table has a compound pk of length 3
- The foreign key is a single int column. It is the first column in the child table's pk, and the only column of parent's pk.
- No additional indexes are defined because we can reuse the pk index.
If we reuse the pk index, we have some special case code that builds a fake index definition. The issue is that we happened to pass sorted tags of the pks, instead the column-order tags. We then use the index definition to prefix iter secondary indexes.
This issue would not appear if you got lucky with the tags of your columns. Specifically, the sorted tag order had to match the tag order. For tables with one pk, this is always the case, and for the test we have for two pks, we also happen to get lucky. Unfortunately, Fritter has three column compound pk and he did not get lucky.
- 5152: go/libraries/doltcore/sqle/read_replica_database.go: Optimize the sql-server read replica case when syncing a lot of new branches.
We already fetch all the new commits we need at once. Some lingering code had us refetching the commit values themselves from the upstream instead of directly setting the new branch to the commit hash which we just fetched.
go-mysql-server
- 1541: truncate really long queries
- 1539: if privilegeSet is nil, return empty row for info schema tables
- privilegeSet was nil for
ld
repository tests as there were no privileges granted and was trying to test on information_schema.views table. - the now exported method is used in
ld
to grant all privileges for the test user
fixes test in https://github.com/dolthub/ld/pull/12642
- privilegeSet was nil for
Closed Issues
Latency
Read Tests | MySQL | Dolt | Multiple |
---|---|---|---|
covering_index_scan | 1.93 | 2.71 | 1.4 |
groupby_scan | 12.3 | 16.41 | 1.3 |
index_join | 1.18 | 4.65 | 3.9 |
index_join_scan | 1.14 | 4.03 | 3.5 |
index_scan | 30.81 | 53.85 | 1.7 |
oltp_point_select | 0.16 | 0.48 | 3.0 |
oltp_read_only | 3.02 | 8.43 | 2.8 |
select_random_points | 0.31 | 0.77 | 2.5 |
select_random_ranges | 0.36 | 1.14 | 3.2 |
table_scan | 30.81 | 63.32 | 2.1 |
types_table_scan | 69.29 | 189.93 | 2.7 |
reads_mean_multiplier | 2.6 |
Write Tests | MySQL | Dolt | Multiple |
---|---|---|---|
bulk_insert | 0.001 | 0.001 | 1.0 |
oltp_delete_insert | 2.71 | 18.95 | 7.0 |
oltp_insert | 1.44 | 3.82 | 2.7 |
oltp_read_write | 5.18 | 26.2 | 5.1 |
oltp_update_index | 1.47 | 8.58 | 5.8 |
oltp_update_non_index | 1.47 | 9.56 | 6.5 |
oltp_write_only | 2.26 | 15.27 | 6.8 |
types_delete_insert | 2.81 | 20.74 | 7.4 |
writes_mean_multiplier | 5.3 |
Overall Mean Multiple | 3.7 |
---|