Merged PRs

dolt

• 5122: go/store/{blobstore,nbs}: Refactor Blobstore interface to work in multi-db mode
  Currently in nbs/store.go NewBSStore() initializes a blobstoreManifest with a static name "manifest". The manifestManager uses this name as a key to cache memory copies of manifestContents. In multi-db mode, this causes disparate manifestContents to clobber each other.
• 5119: go/libraries/doltcore/remotesrv: Reducing logging verbosity.
  Over time some trace logging snuck into remotesrv. At the same time, the logs were not as useful as they could have been and did not make use of log levels. Clean things up a bit to log more information about the amount of work done in some of the requests without being overly verbose.
• 5116: go/libraries/doltcore/remotestorage: chunk_store: Fix semantics of Rebase and Root. Root stays fixed until a Rebase call.
  When remotestorage.DoltChunkStore was originally written, it forwarded all ChunkStore calls to the remotesapi. In reality, a client should expect a snapshot of the database on open, and the root should only change when Rebase() or Commit() is called. This fixes up that initial flaw. Rebase() becomes a refresh of the Root from the gRPC service, and Root() itself is just a read of the cached root hash.
  This reduces unnecessary traffic to the remotestorage service and improves performance of things like sql-server read replicas.
• 5105: add --schema-only flag for dolt dump
  --schema-only is used for dump table schemas with no data into sql file.

go-mysql-server

• 1524: Fix empty cachedResult/existIter issues
  MAX_1_ROW no longer uses a CachedResult, and eagerly loads its child on the first call RowIter(). Three things can happen:
  1. the child returns one row, which we cache in the node state
  2. the child returns zero rows, which we note with a flag in the node state
  3. the child returns more than one row, and we error
     RowIter returns the result row or an emptyIter if no child rows were returned. The emptyIter sentinal is important for antiJoin correctness and join short-circuit performance.
     Original error from system table benchmarks:

  error running query {connectTime=2023-01-07T01:12:10Z, connectionDb=sbtest, error=attempted to call RowIter() on a disposed Node: *plan.CachedResults, query=select * from dolt_commit_ancestors where commit_hash = (select commit_hash from dolt_log limit 1 offset 599)}
  

• 1523: Change coster for non-stats tables
  dolt side #5112
• 1522: Fixed ENUM issue when using INSERT INTO ... SELECT
• 1521: implementing more st_... functions
  implements:
  • st_startpoint
  • st_endpoint
  • st_isclosed
• 1520: implementing st_distance
  MySQL docs: https://dev.mysql.com/doc/refman/8.0/en/spatial-relation-functions-object-shapes.html#function_st-distance

Closed Issues

• 5094: support dolt dump --schema-only

Latency