Merged PRs
dolt
- 5215: Revert "merge join correctness bump"
Reverts #5212 - 5212: merge join correctness bump
- 5208: go/store/nbs: add concurrency to blobstore persister operations
- 5207: go/libraries/doltcore/remotesrv: Response with HTTP status code 206 when writing partial responses.
Also add Accept-Ranges headers in all HTTP responses for portions of table files and Content-Range headers for partial file responses.
This makes the HTTP server more correct and can improve compatibility with various HTTP middleware. - 5205: go/libraries/doltcore/sqle/dsess: When commiting a transaction with a DOLT_COMMIT, merge against the current HEAD if necessary.
Update the transaction logic to land a merge of current HEAD and the staged root value when we are creating a commit and the current HEAD has moved since the start of the transaction.
Dolt allows two concurrent transactions to both land commits on a branch HEAD. In the past, Dolt would simply commit the staged value on each transaction as the value of the database for the commit, and would merge the working sets so that the branch working set was updated with the latest data. This would result in histories with commits which seemed to delete previously committed data, only for it to still be present in the working set and to reappear in later commits. This was particularly problematic under remote replication, where the dolt commits themselves are replicated.
A change landed recently attempted to fix this by writing the merged working set value as the committed value. That works in the case of @@dolt_transaction_commit, assuming there are no manual calls to DOLT_COMMIT with manually staged changes, for example, but it has the wrong semantics when a user is manually staging and commiting changes. - 5201: dolt pull without configs doesnt return error when up to date
dolt pull
should not error out when there is no user name or email set. However, whendolt pull
is run in a workspace that is already up to date with remote, the CLI returns an errorup to date
instead of printingEverything up-to-date.
. This change fixesdolt pull
to not return an error when the workspace is already up to date.
fixes: #5079 - 5193: Fixed error in csv and json output formats for sql shell
Fixes #5158
The issue was that system string result types couldn't be converted into dolt schemas for printing.
Depends on dolthub/go-mysql-server#1550 - 5192: go/store/NBS: faster sanity checks
- 5191: add z-address encoding
- 5190: go/store/nbs: Fix some trivial quota leaks.
- 5177: go/cmd/dolt: sqlserver: If tls config is defined for the sql-server, use it for the remotesapi port as well.
- 5165: Fixed branch -d behavior on unmerged branches to match git
Fixes #5139 - 4959: First pass at online GC
go-mysql-server
- 1556: fix multiple column partition
fix for: #5209 - 1552: fixes from diffs between mysql and dolt info_schema dumps
- Fixed incorrect values in Dolt that did not match MySQL result on information_schema dump
- Unskipped fixed test
- 1514: binlog replication interface between GMS and Dolt
This PR adds aBinlogReplicaController
interface that defines how GMS interacts with the binlog replication code in Dolt when a user enters a replication SQL command, such asCHANGE REPLICATION SOURCE TO ...
,START REPLICA
, etc.
The biggest remaining TODO in this code is adding support forCheckPrivileges
functions.
In the future, we may want to refactor out the generic binlog replication code to GMS and keep the Dolt/storage specific components in Dolt with a more detailed interface, but that felt like overkill for the initial binlog implementation.
vitess
- 215: Adding two new binlog replication statements:
RESET REPLICA
andCHANGE REPLICATION FILTERS
- 214: Added CALL ... AS OF
Closed Issues
- 3216: Support the
table_rows
column with the information_schema.TABLES keyword - 5194: Extremely variable
dolt pull
download speeds - 5175: High load in 1) SELECT queries when we have 7000 rows and 21000 branches 2) create extra branches when we've already have 21000
- 5158: Using
--result-fomat
gives an error when requesting the working head of a repository using the@@db_working
system variable - 5079: command
dolt pull
returns 1 when it should return 0 - 5139: Dolt incorrectly checks "fully merged" state when trying to safely delete branches