Merged PRs

dolt

• 4986: Fix 'new manifest created with non 0 lock' error
  Fixes #4975
  Fix dropping and creating the same database on dolt sql-server. We were caching doltdb's using a singleton and at the manifest cache level which lead to problems.
• 4974: Systab edits
• 4971: Reset source branch after checkout
  When checking out a branch, clear the source branch's working set only after the destination checkout succeeds without errors.

go-mysql-server

• 1475: Fixed stored procedure panics
  This fixes two panics that were discovered for stored procedures. The first comes from this issue: #4980. The second deals with an issue with external stored procedures, where the usage of an uninitialized user variable would throw a panic over the nil value.
• 1474: fix hexadecimal literal value conversion
  MySQL docs:
  In numeric contexts, MySQL treats a hexadecimal literal like a BIGINT UNSIGNED (64-bit unsigned integer).
• 1469: bringing back assert prepared
  For some reason, I deleted AssertErrPrepared, which allowed many tests to incorrectly pass.
  This PR adds that back and fixes the failing tests.
  There were a couple validation rules that were never run, which seems wrong (validateUnionSchemasMatch is still never run for prepared queries).
  I also added a helper TestSingleScriptPrepared to more easily debug prepared script tests
  There are prepared tests in dolt that also fail because of these changes, so I also had to fix them
  Companion PR: #4968
• 1468: Update README.md
  added team link and dolt docs link
• 1466: fixes bug where TIMEDIFF wasn't returning null when given null
  • added unit tests for null arguments for TIMEDIFF
  • added unit tests for null arguments for DATEDIFF
  • updated TIMESTAMPDIFF to throw an error when given a null unit
  • added unit tests for null arguments for TIMESTAMPDIFF
• 1461: Implemented LOOP, LEAVE, and ITERATE, partially implemented DECLARE ... HANDLER
  This needs many, many, many more tests. Also should rewrite how stored procedures are analyzed as well, but that's a larger project overall.
• 1460: add STRCMP functionality
  fixes: #4478

vitess

• 208: Allow charsets/collations in single or double quotes for create database/alter database
  Fixes: #4977
• 206: Update README.md
  added blurb about Dolt's use of vitess and links
• 205: Added LOOP, LEAVE, and ITERATE
  Finding a workaround to allow : to parse resulted in the changes you see in token.go. There may be a better way to go about it, but I don't want to spend more time on it since this appears to work.

Closed Issues

• 4977: Can't create database with navicat: Dolt does not accept single quotes on charset identifier
• 4980: Panic in stored procedure
• 4992: incorrect result from order by clause for case sensitive string values
• 4975: Intermittently receive the message error reading from or writing to noms: new manifest created with non 0 lock when running dolt in docker.
• 4981: insert on decimal type column fails with prepared stmt - decimal conversion issue

Latency