Merged PRs
dolt
- 4632: update readmes for docker images
- 4631: go/doltcore/schema: Set primary key ordinals on schema migration
- 4630: [dolt migrate]: Validate ws migration, skip table validation if table did not change
- 4624: go/doltcore/migrate: Account for
types.BoolKind
in very old databases - 4619: [dolt migrate]: don't prefetch leaf nodes when validating migrated data
Bounds memory usage to size of table file indices and number of cpu cores
Migrating https://www.dolthub.com/repositories/dolthub/museum-collections pre-pr with 8 cores and 64gb of ram takes 5,049 seconds.
Post-pr it takes 6,017 seconds on the same machine.
Only a(5049 - 6017) / 6017 = -16.09%
performance hit.
Previously memory usage was spiking to 42gb, now it remains under 2gb. - 4618: go/libraries/doltcore/remotesrv: Add a symmetric key encryption layer to seal URL returned from the gRPC service an unseal them in the HTTP service.
This will allow us to add authn/z to the gRPC layer. - 4617: go/store/nbs: Faster prefix lookup for table file indices
goos: darwin goarch: amd64 pkg: github.com/dolthub/dolt/go/store/nbs cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz BenchmarkFindPrefix BenchmarkFindPrefix/benchmark_prefixIdx() BenchmarkFindPrefix/benchmark_prefixIdx()-12 16069794 71.68 ns/op BenchmarkFindPrefix/benchmark_findPrefix BenchmarkFindPrefix/benchmark_findPrefix-12 22866360 52.23 ns/op PASS
- 4613: Fixing variable name in
getPORT
helper function
I noticed some errors with grep syntax in a failed BATS test. Looks like we just had an empty env var so there wasn't anything passed togrep
, which caused errors and prevented us from fully checking if a port is in use.