Merged PRs
dolt
- 4228: Make
dolt conflicts resolve $tbl --theirs
faster
dolt conflicts resolve $tbl --theirs
previously took too long as it used a nested for-loop query. That query has been replaced with some out-of-engine machinery. - 4224: Added skipped tests for charcter set matching tests back
These tests can be unskipped when dolthub/go-mysql-server#1224 makes it into Dolt. - 4215: Secondary lookup cursor reuse
Locally on OSXindex_join_scan
goes from3.4ms/q
->2.5ms/q
. - 4202: go/store/prolly: Added
map.FetchOrdinalRange
to utilize batch chunk reads on scans
go-mysql-server
- 1224: SET NAMES collation fix, results have proper charset
Fixes two issues.SET NAMES
would cause all statements that feature aCOLLATE
expression to error if the character set and collation did not match, however such a comparison only makes sense for string literals (at parse time). This has been fixed, as the parse-time check only occurs for literals, and checks that require analysis (such as table columns) now occur at the appropriate time. In addition, the system variablecharacter_set_results
was not used when returning string results, resulting in unexpected behavior, which has also been fixed. - 1222: use float input as str for decimal type
The scale of float input in INSERT statement gets rounded when converting to float64 value.
The scale of input for DECIMAL data type should not be rounded. - 1221: 1 % 0 should not panic but return NULL
From https://dev.mysql.com/doc/refman/8.0/en/mathematical-functions.html#function_mod:MOD(N,0) returns NULL.
- 1217: any number of column is allowed for where exists subquery
Any number of column from the subquery is allowed. The result ofWHERE EXISTS subquery
is dependent on the number of rows rather than the number of columns
Fix for #3772 - 1216: fix infinite recursion for recursive cte used with union subquery
Changes: - 1215: Collation fixes
Fixes the following issues:- #4172
- #4168
CREATE TABLE
and friends will now take the table collation into consideration. This extends to adding a modifying columns, which will use the table collation when no collation is specified. Additionally, thelatin1
character set has been added. Lastly, we properly block usage of non-implemented character sets and collations.
vitess
- 186: add implicit
from dual
toselect x
in recursive cte statements - 173: parse json_table syntax
TODO:NESTED
FOR ORDINALITY
ON EMPTY
ON ERROR