Merged PRs

dolt

• 4036: Fix indeterministic diff delta matching
  Before this fix, tables with different names would attempted to be matched even if there was a pair of tables with a matching name.
• 4029: Andy/migration concurrency
• 4026: Adding links to roadmap and blogs
• 4024: Fix dolt diff not working when there is a space in a column name
• 4018: Bug fix to configure remote dialer when no databases exist yet
  When creating a DoltDatabaseProvider, the GRPCDialProvider was being pulled from the first DoltEnv found in the mutli-repo environment. When no DoltEnvs existed yet, the GRPCDialProvider was being set to nil, which caused dolt_clone to fail (see dolthub/hosted-issues#31).
  This change pulls out the GPRCDialProvider code from DoltEnv into a separate type that can work (without supporting custom user credentials) when there is no existing DoltEnv yet.
  Fixes: dolthub/hosted-issues#31
• 4016: /{.github,go}: bump required go to 1.19
• 3918: Expose a means to iterate sql.Row's from a durable.Index

go-mysql-server

• 1172: Allow common table expressions in INSERT, UPDATE, DELETE statements
  This fixes #4025
• 1170: Fix lock binary typing errors
• 1169: sql/parse: Add support for sqlparser.Union nodes that carry ORDER BY and LIMIT clauses.
• 1166: /.github/workflows: bump ubuntu 22.04
• 1159: Pushing AsOf expressions down to tables used in unions and subqueries in view definitions
  Tables used in unions and subqueries in a view definition weren't getting updated with an asof expression when one was used on the view. This PR extends the resolve_views analyzer rule to close those gaps.
  Fixes: #4011
  Added Dolt enginetests, too: #4028
• 1158: Add support for deprecated BINARY attribute after charset
  Fixes #4019
• 1151: displaying database and table grants
  Makes it so that database and table specific grants show up for query SHOW GRANTS for <user>
  Fix for: #3589
  Also somewhat fix for: #4007
  Testing PR: #4017
• 1150: /{.github,go.mod}: bump go to 1.19
• 1149: Prevent JSON and GEOMETRY columns from having literal default values
  MySQL disallows BLOB, TEXT, JSON, and GEOMETRY columns from having a literal column default value:
  https://dev.mysql.com/doc/refman/8.0/en/data-type-defaults.html#data-type-defaults.html#data-type-defaults-explicit
  go-mysql-server already prevents BLOB and TEXT column types; this PR extends that check to cover JSON and GEOMETRY columns as well.
  Fixes: #4003
• 1132: Additional book keeping for dropping auto_increment
  This PR add additional logic in the memory implementation of table and validate_create_table to handle cases where auto_increment is dropped in an ALTER TABLE MOIDFY statement.

vitess

• 182: Fix error in REPEAT function
• 180: Support for common table expressions in INSERT, UPDATE, DELETE
• 179: allow unescaped reserved keywords when prefixed with table name, and add more reserved keywords
  Changes:
  • fixed misidentified keywords as column safe
  • fixed incorrect tests
  • every reserved keyword in MySQL is reserved in our grammar now
  • exceptions are DUAL and MINUTE_SECOND
    Note:
  • we are still missing many unreserved keywords
  • some of our reserved keywords are unreserved in MySQL
    Fix for: #3979
• 178: Added BINARY to match deprecated functionality
  Fixes #4019
• 177: Removed unused methods
  Follow up from #175
• 176: /{.github,go.mod}: bump go to 1.19
• 175: Remove all package-level flags

  Summary

  This is my attempt to perform a minimally invasive purge of all package-level flags.
  I would appreciate some input on:
  • whether any of the upstream repos that use this vitess fork will be impacted by these changes
  • whether this change should be more invasive (e.g., if you don't use the AuthServerClientCert it may be better to remove it entirely rather than just prune the flags)

  Motivation

  dolthub/vitess#174

  Testing

  I've removed all package-level flags:

  ryanpbrewster@argon:~/p/g/dolthub-vitess$ rg "flag\.\w"
  go/mysql/auth_server_clientcert.go
  35:     if flag.CommandLine.Lookup("mysql_server_ssl_ca").Value.String() == "" {
  

  The existing tests still pass:

  ryanpbrewster@argon:~/p/g/dolthub-vitess$ go test go/...
  ok      go/ast  (cached)
  ok      go/build        (cached)
  ok      go/build/constraint     (cached)
  ok      go/constant     (cached)
  ok      go/doc  (cached)
  ok      go/format       (cached)
  ok      go/importer     (cached)
  ok      go/internal/gccgoimporter       (cached)
  ok      go/internal/gcimporter  (cached)
  ok      go/internal/srcimporter (cached)
  ?       go/internal/typeparams  [no test files]
  ok      go/parser       (cached)
  ok      go/printer      (cached)
  ok      go/scanner      (cached)
  ok      go/token        (cached)
  ok      go/types        (cached)
  

• 172: Changes for adding new auth method

Closed Issues

• 4025: [Feature Request] use a recursive cte result in an update
• 4011: As of reach dependent on view commit history
• 3215: Dolt dump should support views
• 3589: SHOW GRANTS doesn't show grants correctly
• 3039: Implement the CHECK TABLE syntax.
• 3009: Support the DO statement
• 3008: Support CASCADE syntax for ALTER TABLE
• 3006: Support the EXTRACT function
• 4019: Need to support BINARY syntax in ALTER because Dolt uses a binary collation
• 3932: Can't create doc from sql if no docs exist
• 1488: Support for BINARY collation of CHAR / VARCHAR columns
• 2391: Case of enum literals lost in information schema
• 2631: Color coded server logs
• 2259: dolt pull should force a commit message for non-ff merges
• 3144: Dolt statistics table improperly returns two indexes for the Primary Key
• 3107: ALTER TABLE ADD COLUMN with default value referring to non-existent column panics
• 3414: Constraint Violations and Foreign Key Checks
• 3148: Bad error message for string is too large for column
• 3409: Support '--quiet' for dolt cli commands
• 3485: Schema import should support .sql files
• 3500: dolt constraints verify for working set changes
• 3502: Dolt log gets very slow on repositories with lots of commits
• 3103: DESCRIBE is broken for tables that have an expression based defaults
• 3058: Panic on CREATE USER with empty password
• 3511: Corrupted Database from inserts on dolt_branch table
• 2992: Panic on weird Like Condition
• 2198: SHOW STATUS returns an empty table
• 1970: Unique indexes are ignored for keyless tables.
• 1690: GCP Remotes should take in path to application configs
• 1161: ENUM values are always lowercased regardless of actual case
• 174: Remove package-level Vitess flags