Merged PRs

dolt

• 3905: Fix for persisted database specific system variables failing to load
  Fix for #3887
  Persisting and loading ${branch_name}_default_branch from config now works.
• 3901: Update release and nightly files to include import benchmarking
• 3899: go/store/types: SerialMessage: Unify TupleRowStorage and SerialMessage.
  Get rid of TupleRowStorage and use SerialMessage everywhere. In turn, change
  SerialMessage so that it carries its kind and size prefix as part of itself.
• 3898: /.github/workflows/ci-performance-benchmarks-new-format.yaml: remove since #benchmark also does new format
• 3894: fix minor log.Fatalln output
  Signed-off-by: Abirdcfly fp544037857@gmail.com
  log.Fatalln is equivalent to Println() followed by a call to os.Exit(1).
  see example:
  https://go.dev/play/p/VcdbrSNK6wH

  package main
  import (
  "log"
  "os"
  )
  func main() {
  log.Fatalln("A")
  log.Fatalln("B") // unreachable code
  os.Exit(2)
  }
  /* output:
  2009/11/10 23:00:00 A
  Program exited.
  */

• 3875: Benchmark __DOLT_1__ on release
• 3868: yaml config also initialize .doltcfg directories
  Fix for: #3865
• 3867: Sql server jwt auth
  GMS PR: dolthub/go-mysql-server#1123
• 3862: Support dolt_remote() stored procedure
  Supported options:
  DOLT_REMOTE('add', ...)
DOLT_REMOTE('remove', ...)
DOLT_REMOTE('rm', ...)
  Got dialer out of env.Remote object definition, dialer will be set when GetRemoteDB() method is called in dolt push and pull
  Manually copied DoltDatabaseProvider interface from Zach's PR, #3745 , in order to get Zach's implementation of accessing FS from the Provider object.
• 3861: Add a better error message for schema mismatch
  With csv file imports we used to throw an error if the a read row did not have the same numbers of columns as the original schema.
  For example:

  Rows Processed: 0, Additions: 0, Modifications: 0, Had No Effect: 0
  A bad row was encountered while moving data.
  csv reader's schema expects 3 fields, but line only has 2 values.
  line: '5,5,'
  These can be ignored using '--continue'
  

  This is not particularly useful output when the size of the row is massive. It has been a headache debugging this issue for the recent museums bounty. This pr is changing the error message to as follows:

  Rows Processed: 0, Additions: 0, Modifications: 0, Had No Effect: 0
  A bad row was encountered while moving data.
  CSV reader expected 3 values, but saw 2.
  The row was interpreted to be: '{
  "pk": "5"
  "v1": "5"
  "v2": ""
  }
  '
  

  Also improve printing for skipping rows
• 3745: dolt_clone stored procedure
  Adds support for a new dolt_clone() stored procedure.
  Removes most of the use of os.Chdir (except for in test code and one or two dolt-cli-only spots).
  Doc Updates: dolthub/docs#804

go-mysql-server

• 1129: json_contains bug fixes
  Bug fixes for Dolt's implementation of json_contains (MySQL Documentation)
  Fixes: #3895
• 1125: revert superuser to be any host
• 1124: still read JSON privilege files, but write flatbuffer format
  fix for: #3859
  tests are in dolt pr
  companion pr: #3860
• 1123: Allow plugin for other auth types
  Implementation doc: https://docs.google.com/document/d/1ts7ht9p-VkNgYhD2ouXRGNn8DdPP8wHTNm_T8voSDTE/edit?usp=sharing
  Needed vitess changes: dolthub/vitess#172
• 1118: superuser is localhost
  Companion PR: #3810

vitess

• 172: Changes for adding new auth method
• 171: Add rows parsing for LOAD DATA IGNORE and address flaky tls test
  This PR does two things
  1. Addresses #2548 by introducing new conditions in sql.y
  2. Addresses flaky tls server tests by updating tests to use Tls13 and adding an additional error check

Closed Issues

• 3919: Using dolt sql with a running dolt sql-server
• 3895: "Invalid argument" for json_contains() queries
• 3806: Need a way to add, modify and delete remotes on SQL path
• 3481: Panic with describe
• 3513: Implement cherry-pick
• 3623: Deprecate multi-db-dir, databases field in config.yaml
• 3865: v0.40.18 tries to open empty string as privilege file if not explicitly provided
• 3859: Reading Old Version of Privilege File with Newer version of Dolt causes Panic