Merged PRs
dolt
- 3432: Bump R Client Tests
Integrates changes for #3418 - 3427: Include connected DB in log messages
- 3422: Default branch now database-specific global variable
- 3419: Restore obfuscated default branch error
- 3398: go/libraries/doltcore/sqle: Change Index and IndexLookup implementations to not capture table rows. Resolve them from the table at RowIter/Partitions time.
- 3389: Touch up reset docs
- 3385: Support add and modify column via table rewrites (new format only for now)
- 3379: Only skip engine, not inverse
Enginetest -race has it's own CI job that is only run on merge main. As part of that PR, I tried to skip enginetest -race during routine PR tests. I mistakenly did the opposite, running only enginetest -race on ubuntu. - 3375: Fixing revert command usage docs
- 3374: dolt reset --hard clears any merge state
Closes #3371
Whendolt reset --hard
is called, it now clears the merge state if set. - 3369: short dolt procs
> call dbranch('-b', 'new') > call dadd('.'); > call dcommit('-am', 'message'); > call dreset('--hard', 'main')
- 3368: go/store/types: Remove WalkValues func and method.
- 3356: go/{store/datas,libraries/doltcore/doltdb/durable}: Move DOLT_1 format to flatbuffers top-of-DAG.
- 3354: Fix
dolt conflicts cat
failing to show conflicted rows in the union-ed schema between left, right, and base.
Fixes a one-liner bug where the conflicted rows wouldn't show with the union schema between left, right, and base. Added a bats test as well. - 3345: Implemented foreign keys for the new format
This adds foreign key support to the new format. - 3272: Add first-hour-db and bats tests for it
Added dump file offirst-hour-db
database, which is slightly modified version of MySQL Sakila DB to fit current Dolt version.
Added bats tests on first-hour-db, to test current supported functionalities.
Added both the dump file and tests as more functionalities are supported/fixed in Dolt.
Currently tests basics of importing the dump file.
go-mysql-server
- 1014: Added field for connected db to logger
- 1013: Moving transaction initialization before query analysis
Moves transaction creation ahead of query analysis, so that queries can be executed with the latest committed state from other transactions.
Fixes: #3402 - 1009: sql/analyzer: Fix reresolveTables to not drop IndexedTableAccess and DeferredAsOfTable nodes on its transform.
enginetest: Add a test to assert IndexedTableAccess in a prepared statement
behaves correctly when querying a table that has been modified since the
prepare. - 1008: Bug fix for rewriting table during modify column
- 1005: Allowing "DEFAULT NULL" for blob column definitions
Fixes: #3388 - 1004: Support for rewriting tables on column modifications
- 1003: Replace statements that order by primary key, to use indexed table access
- 1002: New interface to rewrite table on certain schema change operations
Interface isn't quite final but this can be checked in. Complementary dolt changes are done and tested but want to get feedback on this approach first. - 1000: Regression test case for #3247
#3247 reported a panic that our test cases didn't cover. Another commit (dolthub/go-mysql-server@324e43b) already fixed the panic, so this PR just adds a quick test to ensure we don't regress with the same bug. - 997: adding
COLLATE
toSHOW CREATE TABLE
Fix for: #3351
Also fix for: #3352 - 992: Allow unresolved tables and procedures in trigger body in CREATE TRIGGER
In order to allow non-existent tables and non-exitent procedures in trigger body in CREATE TRIGGER statement, we no longer run analyzer on trigger body, instead all validation checks are performed on a single rule,validateCreateTrigger
.
Added tests for cases of different action times and events. - 990: support SELECT INTO 'variable' functionality
Added functionality support for SELECT INTO variable only. Usages of 'outfile' or 'dumpfile' will return unsupported syntax error.
Added tests for different cases of SELECT INTO syntax. Using SELECT INTO around unions will not work unless the result is a single row because we do not support order by and limit clauses for union statements even though we parse it correctly.
vitess
- 165: Change the prepared statements return value
- 162: Adding the
SIGNED
keyword for numeric type column definitions
SIGNED
is the default, so specifying it is allowed in SQL, but is a no-op.
https://dev.mysql.com/doc/refman/8.0/en/numeric-type-syntax.html
Found via: MySQL Grammar Crawler - 161: support parsing
analyze table t
Adding support to parseanalyze
statements: https://dev.mysql.com/doc/refman/8.0/en/analyze-table.html - 160: return Into value in GetInto() in SelectStatement
This allows to get Into value without doing switch on its types.
Closed Issues
- 3402: sql-client can't find knex-created table until show tables called
- 3407: Bug: error: '*sql.ColumnDefaultValue' is not a valid value type for 'TINYINT'
- 3165: Support unique constraints on tables without a primary key
- 3288: allow
create trigger
to reference non-existent table in trigger_body - 3388: text/blob types may only have expression default values
- 3355: DEFAULT NULL for text/blob types give error
- 3371:
dolt reset --hard
should clear merge state - 3247: panic: unresolved function is a placeholder node, but Type was called
- 3351:
SHOW CREATE TABLE
is missingCOLLATE
- 3352: Collation not explicitly defined in
SHOW CREATE TABLE
,dolt schema show
,dolt table export
, anddolt dump
output - 950: README suggests installing via now depreciated "go get"
- 989: willing to maintaion sql standard schema support?