Merged PRs
- 862: /go/{go.mod, go.sum}: Update go.mod with go-mysql-server@master
- 861: dotnet mysql client test
- 860: Fixed column renaming breaking default values
- 859: mysql client test c
- 187: Additions to utc_timestamp and timediff
- 186: fix collations
- 185: Fixed bug with column renames breaking default values
- 184: /sql/expression/function/{date.go, date_test.go, registery.go}: Add utc_timestamp
- 183: Fixes for bugs found during integration of column defaults
- 180: triggers
- 178: Column Defaults Implementation Part 2
Here is a comprehensive set of tests for default logic. Practically everything that was added in dolthub/go-mysql-server#174 is covered here, including some edge cases. In addition, the memory table implementation was broken/insufficient in a few ways, so I patched those up.
The biggest change besides the tests is the additional pass when projecting expressions. This is required in order for defaults that reference other columns (especially those that come after) to be able to pull the correct value. This was something I noticed only after I wrote a test that wasn't behaving as expected (compared to the MySQL client). In fact, all of the changes outside ofenginetestswere due to fixing bugs that were found from testing. - 176: Add import statements to readme example
The example in the readme has no import statements, so it's unclear to someone new to the project. So I added some import statements! - 174: Column Defaults Implementation Part 1
This is missing basically all of the new tests, which will come in a separate PR. Proper expressions -> string behavior will also come in a separate PR. Besides that, this is pretty much most of it barring additional bug fixes. All existing tests (some of which use defaults already) pass.
For integrators, they'll make use of the newengine.ApplyDefaultsmethod.