Allow disabling the default Security Group @ento (#160)
what
- This PR adds a new variable,
security_group_enabled
(default: true), that lets you disable the creation ofaws_security_group.ecs_service
why
- Currently there is no way to disable the creation of
aws_security_group.ecs_service
, even if you disable its security group rules throughvar.enable_all_egress_rule
,var.enable_icmp_rule
,var.use_alb_security_group
, andvar.use_nlb_cidr_blocks
. - In my case, I wanted to use my own security group by specifying its id in
var.security_group_ids
. Not being able to disable the creation ofaws_security_group.ecs_service
led to clutter in the list of security groups in AWS console and potential confusion as to which ones were actually used - It would also be an option to not create
aws_security_group.ecs_service
when no security group rules would be created, but I thought it better to have an explicit variable for controlling it