Pass module.this.context to cloudposse/lb-s3-bucket/aws @jwstric2 (#86)
what
- Describe high-level what changed as a result of these commits (i.e. in plain-english, what do these changes mean?)
- Use bullet points to be concise and to the point.
- Context, as inherited from the user defined context, is passed and used in the access_logs
why
- Provide the justifications for the changes (e.g. business case).
- Describe why these changes were made (e.g. why do these commits fix the problem?)
- Use bullet points to be concise and to the point.
- Bug found where the s3 bucket was not using our defined context label_order
label_order = ["namespace", "environment", "name", "attributes"]
. The bucket being created was still using our defined stage of prod. In our use case, if the context is passed in, label_order will be respected by the lb-s3-bucket. - This change, however, could have repercussions if the the label orders lets say does not have attributes in it, which could try and create buckets that could collide in naming (depending on user setup and resources).
- We are accepting if this PR is rejected that it's possible to create your own bucket and pass it in; which is an acceptable solution
references
- Link to any supporting github issues or helpful documentation to add some context (e.g. stackoverflow).
- Use
closes #123
, if this PR closes a GitHub issue#123
N/A in this case