cloudposse/atmos v1.166.0-rc.6

on GitHub

• There is no use of this code here because we set the values already here

why

• We were suspecting this code to not work anyway and cleaning up the code is much better, it avoids confusion. Especially when we already set the values here

Note: We are not refactoring the whole logging logic here. This is just a clean up that would help us reduce the pr size. Also reducing the places where we repeat setting the values

references

• https://linear.app/cloudposse/issue/DEV-3074/remove-unused-flags-value-code

Summary by CodeRabbit

• New Features

  • Introduced a unified logging helper that provides consistent terminal messaging.
  • Enhanced logging configuration capabilities to allow dynamic adjustments based on environment variables and command-line inputs.

• Refactor

  • Centralized the logging configuration to pull settings directly from the configuration, improving error handling and message consistency.
  • Added new functions for parsing command-line flags and setting log configuration.

• Tests

  • Updated CLI log outputs and error messages to reflect revised severity labels and environment details.
  • Adjusted expected outputs in test cases to align with new logging behavior.

• Chores

  • Removed deprecated environment variable support for overriding logging settings.

Added handling for nil configuration pointers in the YQ expression evaluation utilities.

why

When atmosConfig is passed as nil to EvaluateYqExpression(), it would panic with a nil pointer dereference when trying to access atmosConfig.Logs.Level. This happens in scenarios where the configuration hasn't been loaded yet or when the function is called from contexts where configuration isn't available.

references

Summary by CodeRabbit

• Bug Fixes
  • Enhanced YAML expression evaluation to gracefully handle absent configurations, preventing unexpected errors and ensuring reliable, consistent results.
  • Updated default logging behavior improves stability during expression processing.