This PR fixes a commonly seen crash.
When the FEC in chiaki fails, it may present as a slight glitch and report corrupted frame, however, if you are unfortunate, it may take awhile for the IDR frame to arrive.
During that period of time, chiaki will keep sending corrupted P-frames that we cannot decode. This will either
- resolve (eventually), depending on where you are in the chain
- cascade into a crash as the switch keeps waiting for an IDR frame and processing garbage P-frames
Rather than that, I would rather live with some jerkiness every now and then, and immediately request for an IDR frame.
The setting is avaliable for you to toggle if you want, however, I reco keeping it on.
Recovery time is approx 200ms and will present as a slight skip, unless you have sustained packet loss (if your network is not good), in which case it will obviously be a stuttery stream.
The changes are being upstreamed in chiaki-ng/chiaki-ng#697
20:22:20.386[INFO] StreamView::draw #28861: streamActive=true, sessionStarted=true, menuOpen=false
20:22:20.974[INFO] Frame Processor received 23+1 / 30+1 units, attempting FEC
20:22:20.975[ERROR] FEC failed
20:22:20.975[WARNING] Missing unit 0x2
20:22:20.975[WARNING] Missing unit 0x3
20:22:20.975[WARNING] Missing unit 0x4
20:22:20.975[WARNING] Missing unit 0x5
20:22:20.975[WARNING] Missing unit 0x7
20:22:20.976[WARNING] Missing unit 0x8
20:22:20.976[WARNING] Missing unit 0x9
20:22:20.976[INFO] StreamConnection requesting IDR frame
20:22:20.976[INFO] FEC failed, waiting for IDR frame
20:22:20.976[WARNING] Failed to complete frame 28590
20:22:20.976[WARNING] Video receiver could not flush frame.
20:22:20.976[WARNING] Detected missing or corrupt frame(s) from 28590 to 28591
20:22:20.985[WARNING] Detected missing or corrupt frame(s) from 28590 to 28592
20:22:20.991[WARNING] Detected missing or corrupt frame(s) from 28590 to 28593
20:22:21.001[WARNING] Detected missing or corrupt frame(s) from 28590 to 28594
20:22:21.014[WARNING] Detected missing or corrupt frame(s) from 28590 to 28595
20:22:21.030[WARNING] Detected missing or corrupt frame(s) from 28590 to 28596
20:22:21.047[WARNING] Detected missing or corrupt frame(s) from 28590 to 28597
20:22:21.064[WARNING] Detected missing or corrupt frame(s) from 28590 to 28598
20:22:21.080[WARNING] Detected missing or corrupt frame(s) from 28590 to 28599
20:22:21.109[WARNING] Increasing received packets to reduce hit on stream quality
20:22:21.122[INFO] Received IDR frame, resuming decode
What's Changed
Full Changelog: v0.2.5...v0.2.6