Baseline release: 2104302228000
Raw notes
4afb1e1 📦 Update cimg/base Docker tag to v2021.05 (#34169)
3592c8c 🏗 Remove gcloud setup step from CircleCI (#33920)
e76986f ✨ [Story video] Added performance metric boolean for video on first page (#34019)
955f851 📖 Improved documentation on modern presets (#34083)
6559be0 🏗 Optionally exclude JSS with make-extension --nojss (#34173)
6a9ada0 ♻️ Condense polyfills and lock down imports (#34151)
6f573b1 🏗 Switch top-level reviewer list from reviewerTeam to reviewerPool (#34176)
36e8189 ✨[Amp story] [Page attachments] Adding support for title & cta-text attributes (#34026)
ccfc5a6 ✨ [Amp story] [Page attachments] Render page attachment in layoutCallback (#34174)
cb3eb4b 🏗 Use bot name of renovate-approve for owner approval of upgrade PRs (#34182)
558439d 📖 Remove user who's no longer a member from OWNERS (#34178)
7298f2d Revert "🏗 Use bot name of renovate-approve for owner approval of upgrade PRs" (#34183)
756bb4e Resolve some minor diffs that have crept in from bad syncs. (#34150)
e57cd3d Sync for validator/cpp/engine (#34185)
edfd93b ✨ Bento amp-video-iframe (#31055)
3227b39 📦 Update dependency fs-extra to v10 (#34189)
e603abf 📦 Update dependency eslint-plugin-jsdoc to v33 (#34156)
a312f68 📦 Update subpackage devDependencies (#34155)
ced1a8c 📦 Update babel devDependencies to v7.14.0 (#34139)
f8a4f5a 📦 Update build-system devDependencies (#34140)
08ee55b ✅ Validator should satify amp-youtube, not amp-video (#34198)
a31778a 🏗 Disable updates for validator webui (#34202)
1f4187e Sync for validator/cpp/engine (#34196)
5b59e36 amp-iframely validation update (#34187)
ce8fe2d ✨ ♻️ [amp story] [Page attachments] Pre tap animations (#34142)
01b03f3 📦 Update dependency codecov to v3.8.2 (#34180)
a71eafe 📦 Update dependency @babel/preset-env to v7.14.1 (#34203)
20a587e 🐛 Fix a bug that validator failed to get cli opts (#34210)
f2a49b8 ♻️ Extract type assertions out of log to multiple pure function calls (#34088)
20cc7f6 📦 Update build-system devDependencies (#34201)
8dbd2ae 🏗 Use correct suffix for renovate-approve bot (#34211)
063eef4 🏗 Allow auto-merge for low-risk validator upgrades (#34214)
61b962a 📦 Update validator devDependencies (#34205)
e22e0e1 📖 Guide to Building a Bento Video Player (#34195)
e877d38 🐛 Bento <amp-video-iframe>: assorted fixes (#34218)
3f36c04 📦 Update dependency @types/node to v14.14.44 (#34219)
f945f90 📦 Update dependency eslint-plugin-jsdoc to v33.1.0 (#34225)
eafdbdb 📦 Update dependency puppeteer to v9.1.1 (#34226)
44a77f9 🐛 amp-youtube 1.0: forward mute method (#34221)
5abe364 ✅ Validator rules for amp-vimeo 1.0 (#34199)
8d60de5 ✨ added support for consent for Taboola amp-analytics (#34166)
1dfbaff Types: fix all type parse errors and ensure no new ones crop up (#34105)
c7778e4 📖 🐛 Update amp-story-panning-media docs image link and size (#34236)
3884a6b resources: rename V1 to R1, to clear up ambiguity (#34227)
588a202 allow http and relative for amp-story-page-attachment (#34234)
7285c14 ♻️ Types: opt for null shorthand (#34233)
daaf127 📦 Update core dependencies (#34146)
627516e ♻️ Enable type-checking src/polyfills in CI (#34239)
ff2d14b 🐛 amp-brightcove: improve autoplay handling (#34207)
a6ec5ec ♻️📖 Provide a Storybook wrapper to execute video actions (#34222)
520d9bb 🏗 [bento][npm] Add package.json for all bento components with npm definition (#34087)
5245f96 ♻️ Name amp-ima-video methods uniformly for Bento (#34246)
a81915a Remove consent storage limit for viewer (#34054)
e84936c 🐛 Fix bad type (#34254)
30d62af ♻️ Use Helpers and Modern Syntax Examples (#34250)
370e686 update amp-script console error to mention data-ampdevmode (#34235)
51c0542 ♻️ Move imaVideo.js so it can be owned by Bento and Components (#34247)
4e31c2d ♻️ 📖 Global dep-check rule for Bento video (#34252)
d74de58 🏗 runtime: allow for iterator polyfill (#34249)
e181aae Bento: Prepare Twitter Preact implementation (#34194)
aca625a 🐛 Log output when onError set (#34259)
b72b712 ✅ ♻️ <amp-ima-video> test is not an AMP element test (#34230)
a8895fa 🚀 Remove Error classification (#34257)
d405fe0 🏗 amp-subscriptions* owners update (#34261)
2e762f0 🏗 SwG Release 5/5/21 (#34238)
9372b58 🏗️ Simplify enabling npm bundle for components (#34262)
3dea667 🏗 Add wg-components as bundle size approver of dist.3p/ (#34267)
b287571 ♻️ refactor: move builtin components to their own folders (#34237)
fdad648 ✨ [Amp story] Add amp-story-page-outlink component (#34171)
865ef77 amp-twitter: Add Storybook samples (#34273)
98f7d25 📖 Update LTS release docs to indicate supported AMP flavors (#34258)
06edda1 📦 Update dependency mocha to v8.4.0 (#34270)
44a094c 🏗 Disable JSDoc requirement on Storybook files (#34255)
b71abd1 📦 Update dependency google-closure-compiler to v20210505 (#34269)
69c4783 📦 Update dependency @ampproject/worker-dom to v0.29.3 (#34242)
d5b9ac9 📦 Update core devDependencies (#34240)
72d610d 🖍 [Amp story] [Page attachments] Style adjustments (#34275)
df5b6a1 ♻️ [bento][amp-stream-gallery] Split component files for NPM Packaging (#34208)
68394c2 ✨ [bento][amp-sidebar] SSR compatible design for Sidebar Toolbar (#34158)
57e1205 ♻️ 🏗 Fix type errors in runtime-test-base (#34161)
d47ba35 ♻️ 🏗 Create proxy for kleur/colors to expand typing. (#34243)
5e34317 📦 Update com_googlesource_code_re2 commit hash to aa45633 (#34290)
d8c06e2 Check video duration when setting AutoAdvance default (#34153)
4772fee 📦 Update dependency postcss-import to v14.0.2 (#34297)
07c8f51 📦 Update dependency eslint to v7.26.0 (#34289)
49bea4e ❄️ Skip flaky stories tests (#34303)
8612a96 🏗 Improve usability of describes by making it configurable (#34286)
0c63a01 📦 Update dependency postcss to v8.2.15 (#34301)
4847034 ✅ Validator rules for amp-video-iframe 1.0 (#34200)
695ff17 amp-twitter:1.0 - Allow binding to data-tweetid and other configuration attrs (#34296)
c85ae91 🚮 Remove unused font from examples (#34309)
4d86879 ✨ Add parameter to configure amp-story-player animation (#34204)
5a6595b 🐛 [amp-lightbox-gallery] Use declared amp-carousel extension to build carousel (#34292)
aa33d85 🐛 ✅ [Amp story] [Attachments] Get reference to win (#34299)
da4174a ♻️ <amp-ima-video>: Serialize children (#34229)
643df3b 📦 Update dependency eslint-plugin-jsdoc to v34 (#34304)
d182a12 🏗✅ Sandbox all unit and integration tests (#34305)
fb5a5f7 Bento: Assign placeholder and fallback elements to service slot (#34310)
709223e 📦 Update linting devDependencies (#34288)
4251200 📦 Update dependency esbuild to v0.11.19 (#34147)
aa2c23f 🐛Update tests of updateTimeDelay to be more fuzzy (#34313)
f2813ee 📦 Update dependency esbuild to v0.11.20 (#34322)
58cbfbe 🐛✨ [amp-ad] [amp-auto-ads] Firstimpression.io: more debug options, (#34170)
ddb383d 🏗 Sandbox describes.repeated and get rid of the global window.sandbox (#34329)
4516d35 ♿ [amp-render] add aria-live attribute if not specified (#34320)
521db8c 🐛 [Amp story] [Page attachments] [Outlink] Split outlink codepaths for open attachment (#34330)
726db26 ♻️ Modernize some core code (#34280)
027bbe0 ✨ Text fragments support on amp viewer (#34074)
cce0a42 🐛 Initialize Logs in web-push's helper frame endpoint (#34326)
da2f35b Bento: Find rendered lightDomTag elements by attribute instead of tagName (#34325)
68bfdae validator update (#34339)
e6f307e Add unit tests for amp-facebook-comments:0.1 (#34331)
e16d1e7 Let GitHub Actions write package jsons for bento (#34311)
1832519 🏗 Add OWNERS for src/preact (#34298)
93f8023 📦 Update com_googlesource_code_re2 commit hash to bc42365 (#34341)
c11536e Add additional wording to page attachment tests for target=_top (#34334)
d339316 📦 Update dependency eslint-plugin-jsdoc to v34.0.2 (#34336)
0f54826 📦 Update dependency jest-progress-bar-reporter to v1.0.21 (#34338)
a422114 📦 Update babel devDependencies to v7.14.2 (#34344)
9b2011c 📦 Update core devDependencies (#34353)
9181e74 🐛Solve dumb CC type inference bug (#34355)
180f2eb Upgrade Preact to 10.5.13 (#30043)
5a78566 ♻️ Start updating assertions to use core/assert instead of src/log (#34284)
5149732 🏗♻️ Refactor and simplify initialization / clean up of unit and integration tests (#34346)
f04e66d ♻️ Provide core tryCallback helper (#34348)
6733444 ♻️ Clean up extern typedefs (#34345)
11b8fd2 ♻️ Modernize polyfills (#34342)
fea7d58 ♻️ Consolidating more core type helpers (#34253)
2179341 ♻️ Simplify rendering <amp-ima-video> with CSS and static templates (#34248)
8f3d690 🏗 [bento][npm][amp-twitter] Update npm definition and package file for publishing (#34333)
38f3654 🐛Fix lint error in test-ima-video-internal.js (#34365)
162d754 amp-script: sandboxed implies nodom (#34025)
54db502 ✨ [amp-render] placeholder and fallback support (#34294)
feece2e 📦 Update com_google_googletest commit hash to 662fe38 (#34373)
d178917 ✅ Add unit tests for amp-facebook-like (#34361)
226a503 [amp-story-player] Fix layout bug (#34360)
89e7f03 📖 Pressboard vendor updates (#34188)
f73e140 ✨ amp-auto-ads extension: Denakop (#34215)
81db03e 🐛 Forbid private properties inside BaseElement (#34376)
ceebc5b SwG release 0.1.22.165 (#34352)
73ae075 ✅ Add unit tests for amp-facebook-page (#34351)
0baf410 📖 Disable deadlink checking for Infoline (#34384)
8cadf3d 📦 Update dependency esbuild to v0.11.21 (#34381)
4851de2 📦 Update linting devDependencies (#34377)
50acf90 🚮 Clean up obsolete npm resolutions (#34388)
cdc8fb9 ♻️ 🏗 Fix typing in the build-system (#34162)
582c7d5 ❄️ 🏗 🐛 Add empty passing check to visual-diff tests when they are not needed (#34371)
e947dec Remove FunctionalTestController, make ControllerPromise extend Promise (#33844)
3df9a77 ✅ [Story player] Fix animation unit test flakiness (#34382)
c225912 🏗 Switch AMP's main bug template to a yaml-based form (#34393)
3ec59ca Adding Blue Triangle to amp-analytics list✨ (#34012)
c950d87 🏗 Allow Performance WG to manage check-types (#34395)
2271ac3 Fix nits in #34376 (#34392)
73cba25 📦 Update dependency karma-esbuild to v2.2.0 (#34396)
cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
adfe2d4 📖 Expand AMP issue template intro text (#34397)
6bfb301 ♻️ Enable passing type-checking on src/experiments and src/examiner (#34394)
2297f1e 📖 Convert feature request issue template to a form (#34398)
2dd14e5 PubMatic OpenWrap to pass consent strings (#34403)
Breakdown by component
ads (12)
1dfbaff Types: fix all type parse errors and ensure no new ones crop up (#34105)7285c14 ♻️ Types: opt for null shorthand (#34233)5245f96 ♻️ Name amp-ima-video methods uniformly for Bento (#34246)51c0542 ♻️ Move `imaVideo.js` so it can be owned by Bento and Components (#34247)b72b712 ✅ ♻️ <amp-ima-video> test is not an AMP element test (#34230)da4174a ♻️ `<amp-ima-video>`: Serialize children (#34229)d182a12 🏗✅ Sandbox all unit and integration tests (#34305)58cbfbe 🐛✨ [amp-ad] [amp-auto-ads] Firstimpression.io: more debug options, (#34170)2179341 ♻️ Simplify rendering <amp-ima-video> with CSS and static templates (#34248)89e7f03 📖 Pressboard vendor updates (#34188)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)6bfb301 ♻️ Enable passing type-checking on src/experiments and src/examiner (#34394)
amp-a4a (5)
1dfbaff Types: fix all type parse errors and ensure no new ones crop up (#34105)c85ae91 🚮 Remove unused font from examples (#34309)d182a12 🏗✅ Sandbox all unit and integration tests (#34305)fea7d58 ♻️ Consolidating more core type helpers (#34253)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-access (5)
6a9ada0 ♻️ Condense polyfills and lock down imports (#34151)7285c14 ♻️ Types: opt for null shorthand (#34233)d182a12 🏗✅ Sandbox all unit and integration tests (#34305)fea7d58 ♻️ Consolidating more core type helpers (#34253)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-accordion (7)
1dfbaff Types: fix all type parse errors and ensure no new ones crop up (#34105)7285c14 ♻️ Types: opt for null shorthand (#34233)520d9bb 🏗 [bento][npm] Add package.json for all bento components with npm definition (#34087)d182a12 🏗✅ Sandbox all unit and integration tests (#34305)180f2eb Upgrade Preact to 10.5.13 (#30043)fea7d58 ♻️ Consolidating more core type helpers (#34253)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-ad (2)
756bb4e Resolve some minor diffs that have crept in from bad syncs. (#34150)d182a12 🏗✅ Sandbox all unit and integration tests (#34305)
amp-ad-custom (2)
fea7d58 ♻️ Consolidating more core type helpers (#34253)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-ad-exit (2)
d182a12 🏗✅ Sandbox all unit and integration tests (#34305)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-ad-network-adsense-impl (2)
fea7d58 ♻️ Consolidating more core type helpers (#34253)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-ad-network-adzerk-impl (3)
7285c14 ♻️ Types: opt for null shorthand (#34233)fea7d58 ♻️ Consolidating more core type helpers (#34253)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-ad-network-doubleclick-impl (4)
7285c14 ♻️ Types: opt for null shorthand (#34233)d182a12 🏗✅ Sandbox all unit and integration tests (#34305)fea7d58 ♻️ Consolidating more core type helpers (#34253)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-addthis (4)
1dfbaff Types: fix all type parse errors and ensure no new ones crop up (#34105)7285c14 ♻️ Types: opt for null shorthand (#34233)d182a12 🏗✅ Sandbox all unit and integration tests (#34305)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-analytics (9)
8d60de5 ✨ added support for consent for Taboola amp-analytics (#34166)7285c14 ♻️ Types: opt for null shorthand (#34233)d182a12 🏗✅ Sandbox all unit and integration tests (#34305)fea7d58 ♻️ Consolidating more core type helpers (#34253)89e7f03 📖 Pressboard vendor updates (#34188)0baf410 📖 Disable deadlink checking for Infoline (#34384)3ec59ca Adding Blue Triangle to amp-analytics list✨ (#34012)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)6bfb301 ♻️ Enable passing type-checking on src/experiments and src/examiner (#34394)
amp-auto-ads (4)
d182a12 🏗✅ Sandbox all unit and integration tests (#34305)58cbfbe 🐛✨ [amp-ad] [amp-auto-ads] Firstimpression.io: more debug options, (#34170)f73e140 ✨ amp-auto-ads extension: Denakop (#34215)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-base-carousel (2)
7285c14 ♻️ Types: opt for null shorthand (#34233)180f2eb Upgrade Preact to 10.5.13 (#30043)
amp-bind (5)
1dfbaff Types: fix all type parse errors and ensure no new ones crop up (#34105)b287571 ♻️ refactor: move builtin components to their own folders (#34237)c85ae91 🚮 Remove unused font from examples (#34309)d182a12 🏗✅ Sandbox all unit and integration tests (#34305)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-bodymovin-animation (2)
d182a12 🏗✅ Sandbox all unit and integration tests (#34305)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-brightcove (2)
1dfbaff Types: fix all type parse errors and ensure no new ones crop up (#34105)ff2d14b 🐛 amp-brightcove: improve autoplay handling (#34207)
amp-consent (4)
a81915a Remove consent storage limit for viewer (#34054)d182a12 🏗✅ Sandbox all unit and integration tests (#34305)fea7d58 ♻️ Consolidating more core type helpers (#34253)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-date-countdown (2)
7285c14 ♻️ Types: opt for null shorthand (#34233)520d9bb 🏗 [bento][npm] Add package.json for all bento components with npm definition (#34087)
amp-date-display (1)
520d9bb 🏗 [bento][npm] Add package.json for all bento components with npm definition (#34087)
amp-date-picker (3)
d182a12 🏗✅ Sandbox all unit and integration tests (#34305)fea7d58 ♻️ Consolidating more core type helpers (#34253)e947dec Remove FunctionalTestController, make ControllerPromise extend Promise (#33844)
amp-experiment (2)
c85ae91 🚮 Remove unused font from examples (#34309)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-facebook (2)
73ae075 ✅ Add unit tests for amp-facebook-page (#34351)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-facebook-comments (4)
7285c14 ♻️ Types: opt for null shorthand (#34233)fb5a5f7 Bento: Assign placeholder and fallback elements to service slot (#34310)e6f307e Add unit tests for amp-facebook-comments:0.1 (#34331)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-facebook-like (2)
d178917 ✅ Add unit tests for amp-facebook-like (#34361)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-facebook-page (2)
73ae075 ✅ Add unit tests for amp-facebook-page (#34351)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-form (4)
7285c14 ♻️ Types: opt for null shorthand (#34233)d182a12 🏗✅ Sandbox all unit and integration tests (#34305)ddb383d 🏗 Sandbox `describes.repeated` and get rid of the global `window.sandbox` (#34329)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-fx-collection (2)
d182a12 🏗✅ Sandbox all unit and integration tests (#34305)f04e66d ♻️ Provide core `tryCallback` helper (#34348)
amp-iframe (3)
d182a12 🏗✅ Sandbox all unit and integration tests (#34305)fea7d58 ♻️ Consolidating more core type helpers (#34253)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-iframely (2)
5b59e36 amp-iframely validation update (#34187)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-ima-video (7)
5245f96 ♻️ Name amp-ima-video methods uniformly for Bento (#34246)51c0542 ♻️ Move `imaVideo.js` so it can be owned by Bento and Components (#34247)b72b712 ✅ ♻️ <amp-ima-video> test is not an AMP element test (#34230)da4174a ♻️ `<amp-ima-video>`: Serialize children (#34229)2179341 ♻️ Simplify rendering <amp-ima-video> with CSS and static templates (#34248)38f3654 🐛Fix lint error in test-ima-video-internal.js (#34365)162d754 amp-script: sandboxed implies nodom (#34025)
amp-image-lightbox (2)
d182a12 🏗✅ Sandbox all unit and integration tests (#34305)fea7d58 ♻️ Consolidating more core type helpers (#34253)
amp-image-slider (2)
7285c14 ♻️ Types: opt for null shorthand (#34233)d182a12 🏗✅ Sandbox all unit and integration tests (#34305)
amp-inline-gallery (1)
520d9bb 🏗 [bento][npm] Add package.json for all bento components with npm definition (#34087)
amp-instagram (4)
7285c14 ♻️ Types: opt for null shorthand (#34233)520d9bb 🏗 [bento][npm] Add package.json for all bento components with npm definition (#34087)c85ae91 🚮 Remove unused font from examples (#34309)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-lightbox (3)
1dfbaff Types: fix all type parse errors and ensure no new ones crop up (#34105)7285c14 ♻️ Types: opt for null shorthand (#34233)520d9bb 🏗 [bento][npm] Add package.json for all bento components with npm definition (#34087)
amp-lightbox-gallery (3)
1dfbaff Types: fix all type parse errors and ensure no new ones crop up (#34105)5a6595b 🐛 [amp-lightbox-gallery] Use declared amp-carousel extension to build carousel (#34292)d182a12 🏗✅ Sandbox all unit and integration tests (#34305)
amp-list (2)
d182a12 🏗✅ Sandbox all unit and integration tests (#34305)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-live-list (2)
d182a12 🏗✅ Sandbox all unit and integration tests (#34305)fea7d58 ♻️ Consolidating more core type helpers (#34253)
amp-megaphone (2)
c85ae91 🚮 Remove unused font from examples (#34309)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-mustache (1)
ddb383d 🏗 Sandbox `describes.repeated` and get rid of the global `window.sandbox` (#34329)
amp-next-page (3)
b287571 ♻️ refactor: move builtin components to their own folders (#34237)c85ae91 🚮 Remove unused font from examples (#34309)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-pan-zoom (3)
7285c14 ♻️ Types: opt for null shorthand (#34233)d182a12 🏗✅ Sandbox all unit and integration tests (#34305)fea7d58 ♻️ Consolidating more core type helpers (#34253)
amp-playbuzz (2)
c85ae91 🚮 Remove unused font from examples (#34309)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-render (4)
1dfbaff Types: fix all type parse errors and ensure no new ones crop up (#34105)7285c14 ♻️ Types: opt for null shorthand (#34233)4516d35 ♿ [amp-render] add aria-live attribute if not specified (#34320)54db502 ✨ [amp-render] `placeholder` and `fallback` support (#34294)
amp-script (6)
7285c14 ♻️ Types: opt for null shorthand (#34233)370e686 update amp-script console error to mention data-ampdevmode (#34235)d182a12 🏗✅ Sandbox all unit and integration tests (#34305)fea7d58 ♻️ Consolidating more core type helpers (#34253)162d754 amp-script: sandboxed implies nodom (#34025)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-selector (4)
1dfbaff Types: fix all type parse errors and ensure no new ones crop up (#34105)7285c14 ♻️ Types: opt for null shorthand (#34233)520d9bb 🏗 [bento][npm] Add package.json for all bento components with npm definition (#34087)180f2eb Upgrade Preact to 10.5.13 (#30043)
amp-sidebar (4)
1dfbaff Types: fix all type parse errors and ensure no new ones crop up (#34105)68394c2 ✨ [bento][amp-sidebar] SSR compatible design for Sidebar Toolbar (#34158)d182a12 🏗✅ Sandbox all unit and integration tests (#34305)e947dec Remove FunctionalTestController, make ControllerPromise extend Promise (#33844)
amp-social-share (1)
e947dec Remove FunctionalTestController, make ControllerPromise extend Promise (#33844)
amp-story (17)
e76986f ✨ [Story video] Added performance metric boolean for video on first page (#34019)955f851 📖 Improved documentation on modern presets (#34083)36e8189 ✨[Amp story] [Page attachments] Adding support for title & cta-text attributes (#34026)ccfc5a6 ✨ [Amp story] [Page attachments] Render page attachment in layoutCallback (#34174)ce8fe2d ✨ ♻️ [amp story] [Page attachments] Pre tap animations (#34142)588a202 allow http and relative for amp-story-page-attachment (#34234)fdad648 ✨ [Amp story] Add `amp-story-page-outlink` component (#34171)72d610d 🖍 [Amp story] [Page attachments] Style adjustments (#34275)d8c06e2 Check video duration when setting AutoAdvance default (#34153)49bea4e ❄️ Skip flaky stories tests (#34303)aa33d85 🐛 ✅ [Amp story] [Attachments] Get reference to win (#34299)d182a12 🏗✅ Sandbox all unit and integration tests (#34305)aa2c23f 🐛Update tests of updateTimeDelay to be more fuzzy (#34313)521db8c 🐛 [Amp story] [Page attachments] [Outlink] Split outlink codepaths for open attachment (#34330)c11536e Add additional wording to page attachment tests for target=_top (#34334)e947dec Remove FunctionalTestController, make ControllerPromise extend Promise (#33844)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-story-auto-ads (6)
1dfbaff Types: fix all type parse errors and ensure no new ones crop up (#34105)7285c14 ♻️ Types: opt for null shorthand (#34233)30d62af ♻️ Use Helpers and Modern Syntax Examples (#34250)d182a12 🏗✅ Sandbox all unit and integration tests (#34305)fea7d58 ♻️ Consolidating more core type helpers (#34253)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-story-dev-tools (1)
1dfbaff Types: fix all type parse errors and ensure no new ones crop up (#34105)
amp-story-panning-media (2)
c7778e4 📖 🐛 Update amp-story-panning-media docs image link and size (#34236)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-stream-gallery (1)
df5b6a1 ♻️ [bento][amp-stream-gallery] Split component files for NPM Packaging (#34208)
amp-subscriptions (5)
1dfbaff Types: fix all type parse errors and ensure no new ones crop up (#34105)d405fe0 🏗 amp-subscriptions* owners update (#34261)d182a12 🏗✅ Sandbox all unit and integration tests (#34305)fea7d58 ♻️ Consolidating more core type helpers (#34253)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-subscriptions-google (3)
d405fe0 🏗 amp-subscriptions* owners update (#34261)ceebc5b SwG release 0.1.22.165 (#34352)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)
amp-timeago (1)
520d9bb 🏗 [bento][npm] Add package.json for all bento components with npm definition (#34087)
amp-twitter (6)
e181aae Bento: Prepare Twitter Preact implementation (#34194)865ef77 amp-twitter: Add Storybook samples (#34273)695ff17 amp-twitter:1.0 - Allow binding to data-tweetid and other configuration attrs (#34296)c85ae91 🚮 Remove unused font from examples (#34309)5a78566 ♻️ Start updating assertions to use core/assert instead of src/log (#34284)8f3d690 🏗 [bento][npm][amp-twitter] Update npm definition and package file for publishing (#34333)
amp-video (6)
edfd93b ✨ Bento amp-video-iframe (#31055)1dfbaff Types: fix all type parse errors and ensure no new ones crop up (#34105)7285c14 ♻️ Types: opt for null shorthand (#34233)a6ec5ec ♻️📖 Provide a Storybook wrapper to execute video actions (#34222)e84936c 🐛 Fix bad type (#34254)44a094c 🏗 Disable JSDoc requirement on Storybook files (#34255)
amp-video-iframe (4)
edfd93b ✨ Bento amp-video-iframe (#31055)e877d38 🐛 Bento <amp-video-iframe>: assorted fixes (#34218)7285c14 ♻️ Types: opt for null shorthand (#34233)4847034 ✅ Validator rules for amp-video-iframe 1.0 (#34200)
amp-viewer-integration (2)
d182a12 🏗✅ Sandbox all unit and integration tests (#34305)027bbe0 ✨ Text fragments support on amp viewer (#34074)
amp-vimeo (5)
5abe364 ✅ Validator rules for amp-vimeo 1.0 (#34199)7285c14 ♻️ Types: opt for null shorthand (#34233)a6ec5ec ♻️📖 Provide a Storybook wrapper to execute video actions (#34222)c85ae91 🚮 Remove unused font from examples (#34309)68bfdae validator update (#34339)
amp-web-push (2)
7285c14 ♻️ Types: opt for null shorthand (#34233)cce0a42 🐛 Initialize Logs in web-push's helper frame endpoint (#34326)
amp-youtube (5)
08ee55b ✅ Validator should satify `amp-youtube`, not `amp-video` (#34198)44a77f9 🐛 amp-youtube 1.0: forward mute method (#34221)7285c14 ♻️ Types: opt for null shorthand (#34233)a6ec5ec ♻️📖 Provide a Storybook wrapper to execute video actions (#34222)520d9bb 🏗 [bento][npm] Add package.json for all bento components with npm definition (#34087)
build-system (36)
6559be0 🏗 Optionally exclude JSS with `make-extension --nojss` (#34173)6a9ada0 ♻️ Condense polyfills and lock down imports (#34151)edfd93b ✨ Bento amp-video-iframe (#31055)f2a49b8 ♻️ Extract type assertions out of log to multiple pure function calls (#34088)1dfbaff Types: fix all type parse errors and ensure no new ones crop up (#34105)3884a6b resources: rename V1 to R1, to clear up ambiguity (#34227)7285c14 ♻️ Types: opt for null shorthand (#34233)627516e ♻️ Enable type-checking src/polyfills in CI (#34239)520d9bb 🏗 [bento][npm] Add package.json for all bento components with npm definition (#34087)51c0542 ♻️ Move `imaVideo.js` so it can be owned by Bento and Components (#34247)4e31c2d ♻️ 📖 Global dep-check rule for Bento video (#34252)d74de58 🏗 runtime: allow for iterator polyfill (#34249)aca625a 🐛 Log output when onError set (#34259)9372b58 🏗️ Simplify enabling npm bundle for components (#34262)3dea667 🏗 Add `wg-components` as bundle size approver of `dist.3p/` (#34267)b287571 ♻️ refactor: move builtin components to their own folders (#34237)df5b6a1 ♻️ [bento][amp-stream-gallery] Split component files for NPM Packaging (#34208)57e1205 ♻️ 🏗 Fix type errors in runtime-test-base (#34161)d47ba35 ♻️ 🏗 Create proxy for kleur/colors to expand typing. (#34243)8612a96 🏗 Improve usability of `describes` by making it configurable (#34286)d182a12 🏗✅ Sandbox all unit and integration tests (#34305)ddb383d 🏗 Sandbox `describes.repeated` and get rid of the global `window.sandbox` (#34329)cce0a42 🐛 Initialize Logs in web-push's helper frame endpoint (#34326)5149732 🏗♻️ Refactor and simplify initialization / clean up of unit and integration tests (#34346)fea7d58 ♻️ Consolidating more core type helpers (#34253)2179341 ♻️ Simplify rendering <amp-ima-video> with CSS and static templates (#34248)8f3d690 🏗 [bento][npm][amp-twitter] Update npm definition and package file for publishing (#34333)81db03e 🐛 Forbid private properties inside BaseElement (#34376)50acf90 🚮 Clean up obsolete npm resolutions (#34388)cdc8fb9 ♻️ 🏗 Fix typing in the build-system (#34162)582c7d5 ❄️ 🏗 🐛 Add empty passing check to visual-diff tests when they are not needed (#34371)e947dec Remove FunctionalTestController, make ControllerPromise extend Promise (#33844)c950d87 🏗 Allow Performance WG to manage check-types (#34395)2271ac3 Fix nits in #34376 (#34392)cee3997 ♻️ Extract json helpers to core/types/object/json (#34367)6bfb301 ♻️ Enable passing type-checking on src/experiments and src/examiner (#34394)
package updates (35)
4afb1e1 📦 Update cimg/base Docker tag to v2021.05 (#34169)3227b39 📦 Update dependency fs-extra to v10 (#34189)e603abf 📦 Update dependency eslint-plugin-jsdoc to v33 (#34156)a312f68 📦 Update subpackage devDependencies (#34155)ced1a8c 📦 Update babel devDependencies to v7.14.0 (#34139)f8a4f5a 📦 Update build-system devDependencies (#34140)01b03f3 📦 Update dependency codecov to v3.8.2 (#34180)a71eafe 📦 Update dependency @babel/preset-env to v7.14.1 (#34203)20cc7f6 📦 Update build-system devDependencies (#34201)61b962a 📦 Update validator devDependencies (#34205)3f36c04 📦 Update dependency @types/node to v14.14.44 (#34219)f945f90 📦 Update dependency eslint-plugin-jsdoc to v33.1.0 (#34225)eafdbdb 📦 Update dependency puppeteer to v9.1.1 (#34226)daaf127 📦 Update core dependencies (#34146)06edda1 📦 Update dependency mocha to v8.4.0 (#34270)b71abd1 📦 Update dependency google-closure-compiler to v20210505 (#34269)69c4783 📦 Update dependency @ampproject/worker-dom to v0.29.3 (#34242)d5b9ac9 📦 Update core devDependencies (#34240)5e34317 📦 Update com_googlesource_code_re2 commit hash to aa45633 (#34290)4772fee 📦 Update dependency postcss-import to v14.0.2 (#34297)07c8f51 📦 Update dependency eslint to v7.26.0 (#34289)0c63a01 📦 Update dependency postcss to v8.2.15 (#34301)643df3b 📦 Update dependency eslint-plugin-jsdoc to v34 (#34304)709223e 📦 Update linting devDependencies (#34288)4251200 📦 Update dependency esbuild to v0.11.19 (#34147)f2813ee 📦 Update dependency esbuild to v0.11.20 (#34322)93f8023 📦 Update com_googlesource_code_re2 commit hash to bc42365 (#34341)d339316 📦 Update dependency eslint-plugin-jsdoc to v34.0.2 (#34336)0f54826 📦 Update dependency jest-progress-bar-reporter to v1.0.21 (#34338)a422114 📦 Update babel devDependencies to v7.14.2 (#34344)9b2011c 📦 Update core devDependencies (#34353)feece2e 📦 Update com_google_googletest commit hash to 662fe38 (#34373)8cadf3d 📦 Update dependency esbuild to v0.11.21 (#34381)4851de2 📦 Update linting devDependencies (#34377)73cba25 📦 Update dependency karma-esbuild to v2.2.0 (#34396)
src (30)
e76986f ✨ [Story video] Added performance metric boolean for video on first page (#34019)6a9ada0 ♻️ Condense polyfills and lock down imports (#34151)f2a49b8 ♻️ Extract type assertions out of log to multiple pure function calls (#34088)1dfbaff Types: fix all type parse errors and ensure no new ones crop up (#34105)3884a6b resources: rename V1 to R1, to clear up ambiguity (#34227)7285c14 ♻️ Types: opt for null shorthand (#34233)627516e ♻️ Enable type-checking src/polyfills in CI (#34239)d74de58 🏗 runtime: allow for iterator polyfill (#34249)e181aae Bento: Prepare Twitter Preact implementation (#34194)a8895fa 🚀 Remove Error classification (#34257)b287571 ♻️ refactor: move builtin components to their own folders (#34237)695ff17 amp-twitter:1.0 - Allow binding to data-tweetid and other configuration attrs (#34296)4d86879 ✨ Add parameter to configure amp-story-player animation (#34204)fb5a5f7 Bento: Assign placeholder and fallback elements to service slot (#34310)726db26 ♻️ Modernize some core code (#34280)da2f35b Bento: Find rendered `lightDomTag` elements by attribute instead of `tagName` (#34325)1832519 🏗 Add OWNERS for `src/preact` (#34298)9181e74 🐛Solve dumb CC type inference bug (#34355)180f2eb Upgrade Preact to 10.5.13 (#30043)5a78566 ♻️ Start updating assertions to use core/assert instead of src/log (#34284)f04e66d ♻️ Provide core `tryCallback` helper (#34348)6733444 ♻️ Clean up extern typedefs (#34345)11b8fd2 ♻️ Modernize polyfills (#34342)fea7d58 ♻️ Consolidating more core type helpers (#34253)54db502 ✨ [amp-render] `placeholder` and `fallback` support (#34294)226a503 [amp-story-player] Fix layout bug (#34360)81db03e 🐛 Forbid private properties inside BaseElement (#34376)2271ac3 Fix nits in #34376 (#34392)6bfb301 ♻️ Enable passing type-checking on src/experiments and src/examiner (#34394)2dd14e5 PubMatic OpenWrap to pass consent strings (#34403)
validator (6)
756bb4e Resolve some minor diffs that have crept in from bad syncs. (#34150)e57cd3d Sync for validator/cpp/engine (#34185)1f4187e Sync for validator/cpp/engine (#34196)20a587e 🐛 Fix a bug that validator failed to get cli opts (#34210)063eef4 🏗 Allow auto-merge for low-risk validator upgrades (#34214)50acf90 🚮 Clean up obsolete npm resolutions (#34388)