Version: 1910291709300
Baseline: 1910222037440
- Use @example.com for email spec example (#25055)
- docs: Use closer to valid JSON in config samples (#25071)
- add warning about slow updates with amp-live-list (#25123)
- update scrollbar url to /html/amp/scrollbar (#25116)
- ๐ฆ Update dependency @percy/agent to v0.19.3 (#25290)
- ๐Fixed social sharing buttons on iOS Webkit (#25195)
- SwG Release 0.1.22.79 (#25286)
- ๐ฆ Update dependency amphtml-validator to v1.0.29 (#25281)
- ๐ฆ Update dependency eslint to v6.6.0 (#25261)
- ๐ Remove unnecessary .json from bundle-size /report URL (#25276)
- Switch iOS iframe scrolling mode configuration to capabilities (#25263)
- Remove unused experiments from config and experiments (#25215)
- ๐ฆ Update dependency eslint-config-prettier to v6.5.0 (#25265)
- ๐ฆ Update dependency fetch-mock to v7.7.0 (#25266)
- ๐Expose amp-form response from SSR in
submit-success
andsubmit-error
events. (#25242) - โจ Invalidate layout boxes in nested scrollers after scroll (#25172)
- Add crossorigin=anonymous to inserted script (#25262)
- Temporarily remove query params from viewer iframe on navigate (#25181)
- Ensure that flexible ad centering isn't applied to slots centered via text-align. (#25256)
- ๐ Improve error logging in
build-system/compile/check-for-unknown-deps.js
(#25248) - Update amp-fit-text AMP4EMAIL tagspec (#25246)
- ๐ Check for unknown dependencies during after compilation (#24284)
- Update sidebar v0.2 + nested menu and remove history API (#25048)
- ๐ฆ Update dependency amphtml-validator to v1.0.28 (#25212)
- ๐ Fix Custom Element instance creation in IE11 (#25245)
- ๐ฎ Remove RRule support from amp-date-picker (#25230)
- ๐ฆ Update dependency eslint-plugin-jsdoc to v15.12.1 (#25218)
- ๐ฆ Update dependency postcss to v7.0.20 (#25237)
- Carve out flex slot expansion for multi-size responses. (#24495)
- ๐ Add Key Commitment to SwG Crypto Handler (#25111)
- ๐๐ Auto-format all markdown files in
ampproject/amphtml
with Prettier (#25182) - โป๏ธ๐Rename methods in SsrTemplateHelper (#25241)
- amp-selector: "select" event should have variable trust (#24431)
- example typo (#25122)
- ๐๐ Refactor and significantly speed up
gulp check-links
(#25235) - ๐ฆ Update dependency autoprefixer to v9.7.0 (#25238)
- Redefine ampdoc-fie experiment as a branched experiment (#25174)
- Fix shop now CTA (#25229)
- Plumb trust in amp-lightbox. (#25112)
- ๐ Preemptively skip empty link check results (#25233)
- OWNERS for extension generator task (#25165)
- ๐ Replace all OWNERS file references to a4a team with wg-ads (#25232)
- ๐ Move extension markdown template into its own file (#25164)
- ๐ Ignore markdown templates in link checker by convention (#25226)
- โจ Enable native Custom Elements v1 (#25173)
- ๐ Update event listeners for mega menu (#25091)
- Validator roll up (#25224)
- Unrevert "๐ Update @percy/percy-puppeteer to v1.x (#25176)" (#25221)
- ๐ Log SwG page start in AMP (#25171)
- ๐ฆ Update react monorepo to v16.11.0 (#25206)
- Revert "๐ Update @percy/percy-puppeteer to v1.x" (#25213)
- โจamp-smartlinks: Adding new field to payload for API Endpoint (#25160)
- ๐ฆ Update dependency amphtml-validator to v1.0.27 (#25201)
- ๐ Update @percy/percy-puppeteer to v1.x (#25176)
- SwG Release 0.1.22.78 (#25202)
- Separate experiments object block from experiment.js code (#25169)
- Navigation: Fix IE a11y patch & clean up (#25177)
- ๐ฆ Update dependency gulp-prettier to v2.2.0 (#25175)
- ๐ฆ Update dependency bluebird to v3.7.1 (#25051)
- ๐ฆ Update babel monorepo (#24969)
- ๐ฆ Update dependency terser to v4.3.9 (#25054)
- ๐ฆ Update dependency eslint-plugin-jsdoc to v15.12.0 (#24984)
- ๐ฆ Update dependency lolex to v5.1.1 (#25033)
- ๐ฆ Update dependency gulp-ava to v3 (#25036)
- ๐ฎ Delete testIE mode because Custom Elements v1 Polyfill was launched (#25167)
- ๐Transition to submit-error on SSR error responses (#25133)
- amp-accordion: Propagate trust from action->event (#25110)
- Upgrade node from ^10.0.0 to ^12.0.0 (#25161)
- amp-sidebar: Propagate trust from action->event (#25095)
- ๐ฆ Update dependency karma to v4.4.1 (#25142)
- ๐ Pre-build JS files and extensions loaded by core runtime during
gulp
startup (#25155) - ๐ Fix escaping of backticks in json configuration (#25156)
- โจ Launch Custom Elements v1 Polyfill (#25141)
- ๐ฆ Update dependency amphtml-validator to v1.0.26 (#25146)
- Adds some more people to collaboration OWNERS (#25151)
- ๐ Fix
gulp prettify
when there's nothing to check (#25152) - allow firebase for 3p frames (#25092)
- ๐โ -> to fix test flake (#25145)
- ๐ฆ Update dependency mocha to v6.2.2 (#25138)
- Validator rollup (#25134)
- ๐๐ Significantly speed up
gulp prettify
(#25140) - Avoid swipe to dismiss errors being logged. (#25139)
- ๐ fix getPreviousPageId (#25131)
- ๐ Fix watch mode on e2e tests (#25136)
- Formatting a code-block (#25109)
- Story branching support for sidebar links. (#24968)
- SwG Release 0.1.22.77 (#25135)
- Remove requirement from amp-analytics that we're inabox for parentPostMessage. (#24902)
- ๐ Add VS Code auto-formatting support for JS and non-JS files (#25117)
- SwG release 0.1.22.76 (#25088)
- ๐Fixes ima-video race condition and percentage played (#24900)
- โจ Add Comscore Translated Consent Parameter (#24965)
- Update insticator readme file. (#25103)
- OWNERS set for video files in src (#25120)
- Improve text-matching algorithm of amp-viewer-integration/findtext.js. (#23853)
- remove sp path from extension location (#25073)
- Set @alanorozco and @wassgha as owners of video service (#24908)
- Fix syntax for spec/email/OWNERS (#25114)
- Fix team names in OWNERS of
tools
(#25096) - Add OWNERS for spec/email. (#25062)
- ๐ Makes Yuan an owner of SwG extension (#25087)
- โ Deflakes SwG E2E Test (#25065)
- ๐Fix subdomain handling in idealmedia widgets (#24579)
- ๐ Replace
globs-to-files
withglobby
(#25097) - Fixing typo (#25101)
- Fix minor URL typo for Collaborators team (#25079)
- ๐ Add a
--local_changes
mode togulp prettify
(#25093) - ๐ Update contributing docs to reflect non-YAML OWNERS files (#25063)
- ๐ฆ Update dependency karma to v4.4.0 (#25090)
- ๐ Upgrade the browsers we use on Sauce Labs (#24735)
- ๐ Enable
gulp prettify
on several non-JS files (and auto-fix them) (#25085) - Fix typo in AMP Variable Substitutions documentation (#24818)
- ๐โจ Check non-JS files for formatting errors using
prettier
during local and Travis PR checks (#25057) - ๐ Update all markdown files to be owned by wg-outreach (#25075)
- ๐Fix progress bar bug with more comprehensive advancement checks (#24947)
- Validator roll up (#25072)
- Add Empower to amp-ad networks (#24949)
- Implement an amp-mega-menu component (#24822)
- โจAdd "conative" ad network support to amp-ad (#25038)
Breakdown by component
amp-a4a
๐ Add / fix language identifiers in `.md` files across `amphtml` (#25254) Redefine ampdoc-fie experiment as a branched experiment (#25174) ๐ Replace all OWNERS file references to a4a team with wg-ads (#25232)amp-access
๐ Add / fix language identifiers in `.md` files across `amphtml` (#25254)amp-ad
๐ Add Insticator to the list of supported embed types. (#25270)amp-ad-network-adsense-impl
Redefine ampdoc-fie experiment as a branched experiment (#25174) ๐ Replace all OWNERS file references to a4a team with wg-ads (#25232)amp-ad-network-adzerk-impl
๐ Replace all OWNERS file references to a4a team with wg-ads (#25232)amp-ad-network-doubleclick-impl
๐ Add / fix language identifiers in `.md` files across `amphtml` (#25254) Ensure that flexible ad centering isn't applied to slots centered via text-align. (#25256) Redefine ampdoc-fie experiment as a branched experiment (#25174) ๐ Replace all OWNERS file references to a4a team with wg-ads (#25232)amp-ad-network-fake-impl
๐ Replace all OWNERS file references to a4a team with wg-ads (#25232)amp-ad-network-gmossp-impl
๐ Replace all OWNERS file references to a4a team with wg-ads (#25232)amp-ad-network-triplelift-impl
๐ Replace all OWNERS file references to a4a team with wg-ads (#25232)amp-analytics
๐ Add / fix language identifiers in `.md` files across `amphtml` (#25254) โจ Enable native Custom Elements v1 (#25173)amp-animation
๐ Add / fix language identifiers in `.md` files across `amphtml` (#25254)amp-app-banner
๐ Add / fix language identifiers in `.md` files across `amphtml` (#25254)amp-date-picker
๐ฎ Remove RRule support from amp-date-picker (#25230)amp-fit-text
Update amp-fit-text AMP4EMAIL tagspec (#25246)amp-form
Fix typo (#25253) ๐Expose amp-form response from SSR in `submit-success` and `submit-error` events. (#25242) โป๏ธ๐Rename methods in SsrTemplateHelper (#25241)amp-install-serviceworker
๐ Add / fix language identifiers in `.md` files across `amphtml` (#25254)amp-list
Remove unused experiments from config and experiments (#25215) ๐ Add / fix language identifiers in `.md` files across `amphtml` (#25254) โป๏ธ๐Rename methods in SsrTemplateHelper (#25241)amp-pan-zoom
๐ Add / fix language identifiers in `.md` files across `amphtml` (#25254)amp-recaptcha-input
๐ Add / fix language identifiers in `.md` files across `amphtml` (#25254)amp-smartlinks
โจamp-smartlinks: Adding new field to payload for API Endpoint (#25160)amp-social-share
๐Fixed social sharing buttons on iOS Webkit (#25195)amp-story
๐ Add / fix language identifiers in `.md` files across `amphtml` (#25254)amp-story-auto-ads
Fix shop now CTA (#25229)amp-subscriptions
๐ Add / fix language identifiers in `.md` files across `amphtml` (#25254)amp-subscriptions-google
๐ Log SwG page start in AMP (#25171)amp-user-notification
๐ Add / fix language identifiers in `.md` files across `amphtml` (#25254)amp-viewer-assistance
๐ Add / fix language identifiers in `.md` files across `amphtml` (#25254)amp-viewer-integration
Switch iOS iframe scrolling mode configuration to capabilities (#25263) ๐ Add / fix language identifiers in `.md` files across `amphtml` (#25254)validator
amphtml-validator v1.0.29 with node 8 support (#25279) Release amphtml-validator with node 8 support@rsimha
/cc @ampproject/wg-caching
๐ Allow amphtml-validator
to be used with node
v8 (#25278)
This PR makes it so that amphtml-validator
can be used with node
v8. This will need to be followed up with a new 1.0.29
release.
Partial mitigation for #25209
Related to #25161 (comment)
/cc @ampproject/wg-caching
Update amp-fit-text AMP4EMAIL tagspec (#25246)
Follow up to #24854
Restrict amp-fit-text
AMP4EMAIL tagspec to only html_format: AMP4EMAIL
.
Validator roll up (#25224)
Add a stub for error category, fixes #25188
- cl/276319310 Restore a stub of amp.validator.categorizeError in javascript.
- cl/275942712 Fix validator issue with error'ing tags satisfying unique requirements.
Bump validator npm to 1.0.28. (#25211)
This is so we can release the node dependency change in 7316d7c.
I'll save downstream changes to dependents for subsequent PRs.
Support node v10, v12, or v14 for amphtml-validator (#25208)
Publish amphtml-validator version 1.0.27 (#25204)
Removed references to deleted amp.validator.categorizeError.
Upgrade amphtml-validator version to 1.0.26 (#25162)
Upgrade node from ^10.0.0 to ^12.0.0 (#25161)
To match node v12 being the active LTS version as of 10/21/19: https://nodejs.org/en/about/releases/
remove preinstall script for node.js (#25153)
@rsimha
In #15602 check_package_manager.js
was added to validator/nodejs/packages.json. When publishing the npm module (npm publish --access public
) we ran into an issue that this file wasn't included and it couldn't be installed (see below for error). Removing the script allowed us to publish. However I'm unsure if that is the final outcome desired given the PR that introduced it. @rsimha do you know if this file is necessary or only useful for yarn
incantations and not npm
?
user@honeybadgerdontcare:~/github/amphtml/validator$ npm install amphtml-validator@1.0.24
> amphtml-validator@1.0.24 preinstall /github/amphtml/validator/node_modules/amphtml-validator
> node ../../build-system/common/check-package-manager.js
internal/modules/cjs/loader.js:638
throw err;
^
Error: Cannot find module '/github/amphtml/validator/build-system/common/check-package-manager.js'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
at Function.Module._load (internal/modules/cjs/loader.js:562:25)
at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
at startup (internal/bootstrap/node.js:283:19)
at bootstrapNodeJSCore (internal/bootstrap/node.js:622:3)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! amphtml-validator@1.0.24 preinstall: `node ../../build-system/common/check-package-manager.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the amphtml-validator@1.0.24 preinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /.npm/_logs/2019-10-18T22_45_40_386Z-debug.log