github ampproject/amphtml 1910251950120

latest releases: 2410292120000, 2410250306000, 2410161801000...
5 years ago

Version: 1910251950120

Baseline: 1910222037440

  • Fix Custom Element instance creation in IE11 (#25245)
  • ๐Ÿ— Update @percy/percy-puppeteer to v1.x (#25176)
  • SwG Release 0.1.22.78 (#25202)
  • Separate experiments object block from experiment.js code (#25169)
  • Navigation: Fix IE a11y patch & clean up (#25177)
  • ๐Ÿ“ฆ Update dependency gulp-prettier to v2.2.0 (#25175)
  • ๐Ÿ“ฆ Update dependency bluebird to v3.7.1 (#25051)
  • ๐Ÿ“ฆ Update babel monorepo (#24969)
  • ๐Ÿ“ฆ Update dependency terser to v4.3.9 (#25054)
  • ๐Ÿ“ฆ Update dependency eslint-plugin-jsdoc to v15.12.0 (#24984)
  • ๐Ÿ“ฆ Update dependency lolex to v5.1.1 (#25033)
  • ๐Ÿ“ฆ Update dependency gulp-ava to v3 (#25036)
  • ๐Ÿšฎ Delete testIE mode because Custom Elements v1 Polyfill was launched (#25167)
  • ๐Ÿ›Transition to submit-error on SSR error responses (#25133)
  • amp-accordion: Propagate trust from action->event (#25110)
  • Upgrade node from ^10.0.0 to ^12.0.0 (#25161)
  • amp-sidebar: Propagate trust from action->event (#25095)
  • ๐Ÿ“ฆ Update dependency karma to v4.4.1 (#25142)
  • ๐Ÿ— Pre-build JS files and extensions loaded by core runtime during gulp startup (#25155)
  • ๐Ÿ› Fix escaping of backticks in json configuration (#25156)
  • โœจ Launch Custom Elements v1 Polyfill (#25141)
  • ๐Ÿ“ฆ Update dependency amphtml-validator to v1.0.26 (#25146)
  • Adds some more people to collaboration OWNERS (#25151)
  • ๐Ÿ— Fix gulp prettify when there's nothing to check (#25152)
  • allow firebase for 3p frames (#25092)
  • ๐Ÿ›โœ… -> to fix test flake (#25145)
  • ๐Ÿ“ฆ Update dependency mocha to v6.2.2 (#25138)
  • Validator rollup (#25134)
  • ๐Ÿ—๐Ÿš€ Significantly speed up gulp prettify (#25140)
  • Avoid swipe to dismiss errors being logged. (#25139)
  • ๐Ÿ› fix getPreviousPageId (#25131)
  • ๐Ÿ— Fix watch mode on e2e tests (#25136)
  • Story branching support for sidebar links. (#24968)
  • SwG Release 0.1.22.77 (#25135)
  • Remove requirement from amp-analytics that we're inabox for parentPostMessage. (#24902)
  • ๐Ÿ— Add VS Code auto-formatting support for JS and non-JS files (#25117)
  • SwG release 0.1.22.76 (#25088)
  • ๐Ÿ›Fixes ima-video race condition and percentage played (#24900)
  • โœจ Add Comscore Translated Consent Parameter (#24965)
  • OWNERS set for video files in src (#25120)
  • Improve text-matching algorithm of amp-viewer-integration/findtext.js. (#23853)
  • remove sp path from extension location (#25073)
  • Set @alanorozco and @wassgha as owners of video service (#24908)
  • Fix syntax for spec/email/OWNERS (#25114)
  • ๐Ÿ— Fix team names in OWNERS of tools (#25096)
  • Add OWNERS for spec/email. (#25062)
  • ๐Ÿ— Makes Yuan an owner of SwG extension (#25087)
  • โœ… Deflakes SwG E2E Test (#25065)
  • ๐Ÿ›Fix subdomain handling in idealmedia widgets (#24579)
  • ๐Ÿ— Replace globs-to-files with globby (#25097)
  • Fix minor URL typo for Collaborators team (#25079)
  • ๐Ÿ— Add a --local_changes mode to gulp prettify (#25093)
  • ๐Ÿ“– Update contributing docs to reflect non-YAML OWNERS files (#25063)
  • ๐Ÿ“ฆ Update dependency karma to v4.4.0 (#25090)
  • ๐Ÿ— Upgrade the browsers we use on Sauce Labs (#24735)
  • ๐Ÿ— Enable gulp prettify on several non-JS files (and auto-fix them) (#25085)
  • Fix typo in AMP Variable Substitutions documentation (#24818)
  • ๐Ÿ—โœจ Check non-JS files for formatting errors using prettier during local and Travis PR checks (#25057)
  • ๐Ÿ— Update all markdown files to be owned by wg-outreach (#25075)
  • ๐Ÿ›Fix progress bar bug with more comprehensive advancement checks (#24947)
  • Validator roll up (#25072)
  • Add Empower to amp-ad networks (#24949)
  • Implement an amp-mega-menu component (#24822)
  • โœจAdd "conative" ad network support to amp-ad (#25038)

Breakdown by component

amp-3d-gltf Validator rollup (#25134)
amp-3q-player Validator rollup (#25134)
amp-access Validator rollup (#25134)
amp-accordion amp-accordion: Propagate trust from action->event (#25110) Validator rollup (#25134)
amp-ad Validator rollup (#25134)
amp-ad-custom Validator rollup (#25134) Formatting a code-block (#25109) Fixing typo (#25101)
amp-ad-exit Validator rollup (#25134)
amp-anim Validator rollup (#25134)
amp-animation Validator rollup (#25134)
amp-app-banner Validator rollup (#25134)
amp-audio Validator rollup (#25134)
amp-autocomplete Validator rollup (#25134)
amp-base-carousel Validator rollup (#25134)
amp-bodymovin-animation Validator rollup (#25134)
amp-brid-player Validator rollup (#25134)
amp-brightcove Validator rollup (#25134)
amp-byside-content Validator rollup (#25134)
amp-call-tracking Validator rollup (#25134)
amp-carousel Validator rollup (#25134)
amp-connatix-player Validator rollup (#25134)
amp-consent Validator rollup (#25134)
amp-dailymotion Validator rollup (#25134)
amp-date-countdown Validator rollup (#25134)
amp-date-display Validator rollup (#25134)
amp-date-picker Validator rollup (#25134)
amp-form ๐Ÿ›Transition to submit-error on SSR error responses (#25133)
amp-lightbox-gallery Avoid swipe to dismiss errors being logged. (#25139)
amp-sidebar amp-sidebar: Propagate trust from action->event (#25095)
amp-story ๐Ÿ› fix getPreviousPageId (#25131)
validator Publish amphtml-validator version 1.0.27 (#25204) Removed references to deleted amp.validator.categorizeError. Upgrade amphtml-validator version to 1.0.26 (#25162)

Upgrade node from ^10.0.0 to ^12.0.0 (#25161)
To match node v12 being the active LTS version as of 10/21/19: https://nodejs.org/en/about/releases/
remove preinstall script for node.js (#25153)
@rsimha

In #15602 check_package_manager.js was added to validator/nodejs/packages.json. When publishing the npm module (npm publish --access public) we ran into an issue that this file wasn't included and it couldn't be installed (see below for error). Removing the script allowed us to publish. However I'm unsure if that is the final outcome desired given the PR that introduced it. @rsimha do you know if this file is necessary or only useful for yarn incantations and not npm?

user@honeybadgerdontcare:~/github/amphtml/validator$ npm install amphtml-validator@1.0.24

> amphtml-validator@1.0.24 preinstall /github/amphtml/validator/node_modules/amphtml-validator
> node ../../build-system/common/check-package-manager.js

internal/modules/cjs/loader.js:638
    throw err;
    ^

Error: Cannot find module '/github/amphtml/validator/build-system/common/check-package-manager.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:622:3)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! amphtml-validator@1.0.24 preinstall: `node ../../build-system/common/check-package-manager.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the amphtml-validator@1.0.24 preinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /.npm/_logs/2019-10-18T22_45_40_386Z-debug.log

Don't miss a new amphtml release

NewReleases is sending notifications on new releases.