github ampproject/amphtml 1906042041510

latest releases: 2404230718000, 2404181825000, 2404091947000...
4 years ago

Version: 1906042041510

Baseline: 1905292322390

  • Viewer messaging to select the next/previous document. (#22684)
  • ✅ Add second visual test for amp-autocomplete (#22047)
  • ♻️Cleanup e2e test endpoints and remove unused screenshot calls (#22674)
  • ✨ Add custom cookie expiration (#22483)
  • 🏗 Create gulp integration (#22673)
  • ✅ Remove special casing for tests from amp-mustache extension registration (#22598)
  • Adds refs for amp-twitter (#21508)
  • add browsers option to e2e task (#22471)
  • ✨ Adds generator for JSON version of the validator spec (#22528)
  • getHighestAvailableDomain helper method (#22510)
  • 🐛 Fix sauce (#22680)
  • 🐛Fix broken args in expander. (#22508)
  • ♻️ Replace usage of pagesCount with page_ids.length (#22655)
  • ✨ FEATURE: AMP form dirtiness indicator class (#22640)
  • ✨amp-experiment 1.0: Allow an #amp-x_disable_all_experiments_ to disable all experiments (#22419)
  • 🏗♻️ Refactor / clean up the watch logic used for extensions (#22659)
  • 🏗 Create gulp unit (#22606)
  • 🚮Remove autosuggest examples and assets (#22653)
  • 🏗 Fix code coverage logging on Travis (#22634)
  • Attachment theme validation. (#22643)
  • Remove onBodyAvailable from doc-state service. Start deprecation. (#22580)
  • Replacing story attachment data-dark-mode with theme. (#22642)
  • Handling the lifecycle of AMP components within an attachment. (#22603)
  • Adding a label for the "line" share provider. (#22639)
  • 🐛amp-call-tracking: Made the 'phoneNumber' field optional (#22613)
  • 🏗♻️ Refactor and speed up unminified builds (#22635)
  • Add services to overridekeys for addthis (#22588)
  • 🐛 Fix .codecov.yaml (#22633)
  • Move shared CSS from ampdoc.css to ampelement.css (#22494)
  • Pure renaming PR: ampelement.css -> ampshared.css (#22628)
  • Include userActivation in the 3p iframe postMessage (#22627)
  • Add trailing newlines to validator files. (#22625)
  • Validator Rollup (#22620)
  • 🏗 Consolidate AMP's code coverage PR statuses (#22567)
  • Add isFieldEmpty helper (#22584)
  • 🐛 Copy sourcemap file for aliased bundles (#22605)
  • 🐛 Fixed spelling inconsistency in extensions/amp-animation/0.1/css-expr-impl.js (#22590)
  • 🐛 Enable type checking for 3p/environment.js (#22589)
  • 🐛 Suppress expected LGTM alerts that can't be fixed (#22596)
  • 🖍 Make story page viewport units public, for usage in publisher styles (#22591)
  • 🏗 Report test status for integration tests on stable browsers on SauceLabs (#22268)
  • ✅ Fix amp-img integration test on IE 11 (#22557)
  • integration ADOP(3p) <> amp-ad (#22428)
  • Fix friendly embedding on amp-ad, and reenable test-amp-ad-fake.js (#22504)
  • Story render service for amp-story 0.1. (#22575)
  • ✨Adds button when new update is available (#22519)
  • ✨ Enable typeahead with a suggest-first attribute on amp-autocomplete. (#22213)
  • Revert deferment of local data [src] render until layout. (#22559)
  • Fix sidebar opening for Firefox. (#22563)
  • SwG 0.1.22.53 (#22560)
  • Revert deferral of [src] local data render until layout (#22559)
  • Fix sidebar opening for Firefox. (#22563)
  • 📦 Update dependency jsdom to v15.1.1 (#22523)
  • 📦 Update dependency eslint-plugin-jsdoc to v7.2.0 (#22522)
  • 📦 Update dependency express to v4.17.1 (#22513)
  • 📦 Update dependency nodemon to v1.19.1 (#22512)
  • ♻️✅ Extract isFieldDefault helper (#22541)
  • SwG 0.1.22.53 (#22560)
  • 🏗 Upload codecov reports only for runtime changes (#22549)
  • ♻️✅ Export isDisabled helper (#22536)
  • Validator rollup (#22548)
  • Fix invisible amp-sidebar in AMP4EMAIL (#22539)
  • ✨amp-experiment 1.0: Created the Base Allow List for Attribute Mutations (#22349)
  • Run amp-mustache-0.1 integration tests. (#22314)
  • 🐛Improvements to Permutive amp-analytics config (#22521)
  • ✅ Make sure amp-autocomplete example validates (#22537)
  • ✨ Support multi entitlement pingback in amp-subscriptions (#22469)
  • 🐛 Page layout improvements (#22369)
  • ✨ Implement (#22302)
  • ✨Bold partial user input in suggested items (amp-autocomplete). (#21466)
  • Story page attachment dark mode. (#22505)
  • 🏗 Add new task gulp codecov-upload to upload coverage reports (#22515)
  • applyFillContent on amp-ad-custom (#22516)
  • ✨ Display fallback on error in amp-autocomplete (#21443)
  • Remove "ampdoc-shell" experimental code (#22275)
  • 🐛 FIX: Allow empty string as rendered template (#22503)
  • Updating the story amp-sidebar animations. (#22495)
  • 📦 Update dependency puppeteer to v1.17.0 (#22486)
  • 🏗 test-status app refactors + report e2e tests (#22501)
  • 📦 Update dependency bluebird to v3.5.5 (#22492)
  • 📦 Update dependency @octokit/rest to v16.27.0 (#22484)
  • 📦 Update dependency eslint-plugin-jsdoc to v7 (#22489)
  • ✨Support lightbox gallery crop animation. (#22476)
  • 🏗 Enable noDefaults: true for jsdoc/check-types (#22498)
  • 🐛 Fix LGTM alerts in AMP codebase (#22488)
  • Allow input tags in amp-autocomplete to have no "type" attribute. (#22470)
  • Replacing the data-text-background-color img examples to add cats. (#22497)
  • Split amp.css to ampdoc.css & ampelement.css (#22458)
  • 🚀Optimize svgs used in lightbox gallery. (#22487)
  • Ban getServiceForDoc() in extensions/* paths. (#22468)
  • Validate and document text background color attribute for amp-story (#22472)
  • 🏗 Turn E2E tests into BLOCKING MODE in our CI build (#22477)
  • Make amp-autocomplete more accessible via aria labels (#22316)
  • Fix hardcoded CSS filename in closure compiler code. (#22485)
  • Fix up sample HTML syntax in doc (#22460)
  • 🏗 Allow gulp to run from amphtml/node_modules (#22479)
  • ✨ SwG crypto: decryption implementation (#22285)
  • 🏗 Add a check for the default gulp executable path (#22459)
  • add firefox option for e2e tests (#22225)
  • Use connect URL for activate iframe in amp-access-scroll (#22387)
  • 🏗🐛 Don't run clean during build, check-types, or dist (#22455)
  • Add two inabox visual diff tests (#22130)
  • Add fuzzy client-side filter option on amp-autocomplete (#22240)
  • Clean up: remove copies of CSS files under /build/. (#22457)
  • Remove duplicated polyfill import. (#22377)
  • Remove the confusing "force3p" string in a4a envelope. (#22444)
  • ♻️ Refactor lightbox controls (#22442)
  • fix typo in ssr handling request example (#22434)
  • 📦 Update babel monorepo to v7.4.5 (#22416)
  • 🐛Fix $SUBSTR macro (#22443)
  • 🔥 Fix pubmine ads (#22431)
  • Update docs/template for new cherry pick approvers (#22453)
  • 🏗✨ Upgrade closure compiler to v20190513 (#22446)
  • 🔥 Fix pubmine ads (#22431)
  • 🏗 Use minified build for e2e tests (#22397)
  • 📦 Update dependency jest-dot-reporter to v1.0.8 (#22448)
  • 📦 Update dependency gzip-size to v5.1.1 (#22407)
  • 📦 Update dependency express to v4.17.0 (#22350)
  • 📦 Update dependency @octokit/rest to v16.26.0 (#22261)
  • 📦 Update dependency eslint-plugin-eslint-plugin to v2.1.0 (#22203)
  • SwG release 0.1.22.51.1 (#22445)
  • Revert "Add new (#22417)" (#22447)
  • 🐛Fix $SUBSTR macro (#22443)
  • 📦 Update dependency google-closure-compiler to v20190513 (#22368)
  • 🏗 Log Karma results when zero tests are detected (#22439)
  • Add animate-in-timing-function attribute to the amp-story documentation. (#22436)
  • 🐛 amp-carousel: hide next/prev in type=carousel for screen readers (#22405)
  • 🐛Don't report error when amp-google-client-id-api is set to gtag (#21970)
  • ✨ Update progress bar when new page is appended by the LiveStoryManager (#22367)
  • Implementation for amp-user-location component (#22182)
  • 🏗 Run unit tests on Firefox (#22420)
  • ✨amp-experiment 1.0: Implemented a maximum number of mutations (#22176)
  • Removed the no mutations limitation (#22395)
  • ♻️Added comment on generating .out files for validator (#22374)
  • Add new (#22417)

Breakdown by component

amp-3q-player Add trailing newlines to validator files. (#22625)
amp-a4a applyFillContent on amp-ad-custom (#22516)
amp-accordion Add trailing newlines to validator files. (#22625)
amp-ad Add trailing newlines to validator files. (#22625)
amp-ad-custom Add trailing newlines to validator files. (#22625)
amp-addthis Add services to overridekeys for addthis (#22588)
amp-analytics ✨ Add custom cookie expiration (#22483) 🐛Fix broken args in expander. (#22508) Remove onBodyAvailable from doc-state service. Start deprecation. (#22580) 🐛Improvements to Permutive amp-analytics config (#22521)
amp-animation 🐛 Fixed spelling inconsistency in extensions/amp-animation/0.1/css-expr-impl.js (#22590)
amp-autocomplete Add trailing newlines to validator files. (#22625) 📖Update amp-autocomplete md file to be more concise (#22529) ✅ Make sure amp-autocomplete example validates (#22537)
amp-base-carousel ♻️Cleanup e2e test endpoints and remove unused screenshot calls (#22674) Add trailing newlines to validator files. (#22625)
amp-bind 🚮Remove autosuggest examples and assets (#22653) Add trailing newlines to validator files. (#22625) Fix friendly embedding on amp-ad, and reenable test-amp-ad-fake.js (#22504)
amp-bodymovin-animation Add trailing newlines to validator files. (#22625)
amp-brightcove Add trailing newlines to validator files. (#22625)
amp-byside-content Add trailing newlines to validator files. (#22625)
amp-call-tracking 🐛amp-call-tracking: Made the 'phoneNumber' field optional (#22613)
amp-carousel Validator rollup (#22548)
amp-dailymotion Add trailing newlines to validator files. (#22625)
amp-date-countdown Add trailing newlines to validator files. (#22625)
amp-date-display Add trailing newlines to validator files. (#22625)
amp-delight-player Add trailing newlines to validator files. (#22625)
amp-embedly-card Add trailing newlines to validator files. (#22625)
amp-experiment Add trailing newlines to validator files. (#22625)
amp-facebook Add trailing newlines to validator files. (#22625)
amp-form ♻️Cleanup e2e test endpoints and remove unused screenshot calls (#22674) ✨ FEATURE: AMP form dirtiness indicator class (#22640) ♻️✅ Extract `isFieldDefault` helper (#22541)
amp-google-document-embed Add trailing newlines to validator files. (#22625)
amp-gwd-animation Fix friendly embedding on amp-ad, and reenable test-amp-ad-fake.js (#22504)
amp-ima-video Add trailing newlines to validator files. (#22625)
amp-jwplayer Add trailing newlines to validator files. (#22625)
amp-lightbox Add trailing newlines to validator files. (#22625)
amp-lightbox-gallery 🚀Optimize svgs used in lightbox gallery. (#22487)
amp-link-rewriter Add trailing newlines to validator files. (#22625)
amp-list ♻️Cleanup e2e test endpoints and remove unused screenshot calls (#22674) Add trailing newlines to validator files. (#22625) Revert deferral of [src] local data render until layout (#22559) 🐛 FIX: Allow empty string as rendered template (#22503)
amp-mowplayer Add trailing newlines to validator files. (#22625)
amp-mustache ✅ Remove special casing for tests from amp-mustache extension registration (#22598) Add trailing newlines to validator files. (#22625)
amp-sidebar Fix sidebar opening for Firefox. (#22563)
amp-story Viewer messaging to select the next/previous document. (#22684) ♻️ Replace usage of pagesCount with page_ids.length (#22655) Attachment theme validation. (#22643) Remove onBodyAvailable from doc-state service. Start deprecation. (#22580) Replacing story attachment data-dark-mode with theme. (#22642) Handling the lifecycle of AMP components within an attachment. (#22603) Adding a label for the "line" share provider. (#22639) Documentation for story page attachments dark mode. (#22506) 🖍 Make story page viewport units public, for usage in publisher styles (#22591) Story render service for amp-story 0.1. (#22575) ✨Adds button when new update is available (#22519) Story page attachment dark mode. (#22505) Updating the story amp-sidebar animations. (#22495) Replacing the data-text-background-color img examples to add cats. (#22497)
amp-story-auto-ads Remove onBodyAvailable from doc-state service. Start deprecation. (#22580)
amp-vimeo 🐛 Fix LGTM alerts in AMP codebase (#22488)
validator ✨ Adds generator for JSON version of the validator spec (#22528) This makes it easier to consume by scripts to e.g. pull the list of all tags allowed by a specific format or generate autocomplete definitions for playground.amp.dev. Validator Rollup (#22620) Fix #22535 where the validator considers a document with 1,000+ bytes of inline CSS as valid. 🐛 Suppress expected LGTM alerts that can't be fixed (#22596) In #22488, we fixed all the security, correctness, and maintainability issues in our code detected via static analysis from LGTM.com.

This PR suppresses the remaining issues that are expected and can't be fixed.

Files:

Rules that were suppressed:

Fixed:

Left alone:

Don't miss a new amphtml release

NewReleases is sending notifications on new releases.