Version: 1905292322390
Baseline: 1905211840370
- Fix friendly embedding on amp-ad, and reenable test-amp-ad-fake.js (#22504)
- Story render service for amp-story 0.1. (#22575)
- ✨Adds button when new update is available (#22519)
- ✨ Enable typeahead with a suggest-first attribute on amp-autocomplete. (#22213)
- Revert deferment of local data [src] render until layout. (#22559)
- Fix sidebar opening for Firefox. (#22563)
- SwG 0.1.22.53 (#22560)
- Revert deferral of [src] local data render until layout (#22559)
- Fix sidebar opening for Firefox. (#22563)
- 📦 Update dependency jsdom to v15.1.1 (#22523)
- 📦 Update dependency eslint-plugin-jsdoc to v7.2.0 (#22522)
- 📦 Update dependency express to v4.17.1 (#22513)
- 📦 Update dependency nodemon to v1.19.1 (#22512)
- ♻️✅ Extract
isFieldDefault
helper (#22541) - SwG 0.1.22.53 (#22560)
- 🏗 Upload codecov reports only for runtime changes (#22549)
- ♻️✅ Export
isDisabled
helper (#22536) - Validator rollup (#22548)
- Fix invisible amp-sidebar in AMP4EMAIL (#22539)
- ✨amp-experiment 1.0: Created the Base Allow List for Attribute Mutations (#22349)
- Run amp-mustache-0.1 integration tests. (#22314)
- 🐛Improvements to Permutive amp-analytics config (#22521)
- ✅ Make sure amp-autocomplete example validates (#22537)
- ✨ Support multi entitlement pingback in amp-subscriptions (#22469)
- 🐛 Page layout improvements (#22369)
- ✨ Implement (#22302)
- ✨Bold partial user input in suggested items (amp-autocomplete). (#21466)
- Story page attachment dark mode. (#22505)
- 🏗 Add new task
gulp codecov-upload
to upload coverage reports (#22515) - applyFillContent on amp-ad-custom (#22516)
- ✨ Display fallback on error in amp-autocomplete (#21443)
- Remove "ampdoc-shell" experimental code (#22275)
- 🐛 FIX: Allow empty string as rendered template (#22503)
- Updating the story amp-sidebar animations. (#22495)
- 📦 Update dependency puppeteer to v1.17.0 (#22486)
- 🏗 test-status app refactors + report e2e tests (#22501)
- 📦 Update dependency bluebird to v3.5.5 (#22492)
- 📦 Update dependency @octokit/rest to v16.27.0 (#22484)
- 📦 Update dependency eslint-plugin-jsdoc to v7 (#22489)
- ✨Support lightbox gallery crop animation. (#22476)
- 🏗 Enable
noDefaults: true
forjsdoc/check-types
(#22498) - 🐛 Fix LGTM alerts in AMP codebase (#22488)
- Allow input tags in amp-autocomplete to have no "type" attribute. (#22470)
- Replacing the data-text-background-color img examples to add cats. (#22497)
- Split amp.css to ampdoc.css & ampelement.css (#22458)
- 🚀Optimize svgs used in lightbox gallery. (#22487)
- Ban getServiceForDoc() in extensions/* paths. (#22468)
- Validate and document text background color attribute for amp-story (#22472)
- 🏗 Turn E2E tests into BLOCKING MODE in our CI build (#22477)
- Make amp-autocomplete more accessible via aria labels (#22316)
- Fix hardcoded CSS filename in closure compiler code. (#22485)
- 🏗 Allow
gulp
to run fromamphtml/node_modules
(#22479) - ✨ SwG crypto: decryption implementation (#22285)
- 🏗 Add a check for the default
gulp
executable path (#22459) - add firefox option for e2e tests (#22225)
- Use connect URL for activate iframe in amp-access-scroll (#22387)
- 🏗🐛 Don't run
clean
duringbuild
,check-types
, ordist
(#22455) - Add two inabox visual diff tests (#22130)
- Add
fuzzy
client-side filter option on amp-autocomplete (#22240) - Clean up: remove copies of CSS files under /build/. (#22457)
- Remove duplicated polyfill import. (#22377)
- Remove the confusing "force3p" string in a4a envelope. (#22444)
- ♻️ Refactor lightbox controls (#22442)
- fix typo in ssr handling request example (#22434)
- 📦 Update babel monorepo to v7.4.5 (#22416)
- 🐛Fix $SUBSTR macro (#22443)
- 🔥 Fix pubmine ads (#22431)
- 🏗✨ Upgrade closure compiler to v20190513 (#22446)
- 🔥 Fix pubmine ads (#22431)
- 🏗 Use minified build for e2e tests (#22397)
- 📦 Update dependency jest-dot-reporter to v1.0.8 (#22448)
- 📦 Update dependency gzip-size to v5.1.1 (#22407)
- 📦 Update dependency express to v4.17.0 (#22350)
- 📦 Update dependency @octokit/rest to v16.26.0 (#22261)
- 📦 Update dependency eslint-plugin-eslint-plugin to v2.1.0 (#22203)
- SwG release 0.1.22.51.1 (#22445)
- Revert "✨ Add new " (#22447)
- 🐛Fix $SUBSTR macro (#22443)
- 📦 Update dependency google-closure-compiler to v20190513 (#22368)
- 🏗 Log Karma results when zero tests are detected (#22439)
- 🐛 amp-carousel: hide next/prev in type=carousel for screen readers (#22405)
- 🐛Don't report error when amp-google-client-id-api is set to gtag (#21970)
- ✨ Update progress bar when new page is appended by the LiveStoryManager (#22367)
- Implementation for amp-user-location component (#22182)
- 🏗 Run unit tests on Firefox (#22420)
- ✨amp-experiment 1.0: Implemented a maximum number of mutations (#22176)
- ✨amp-experiment 1.0: Removed the "No mutations" limitation (#22395)
- ♻️Added comment on generating
.out
files for validator (#22374) - ✨ Add new (#22417)
Breakdown by component
ads
🔥 Fix pubmine ads (#22431)amp-a4a
applyFillContent on amp-ad-custom (#22516)amp-ad-network-doubleclick-impl
📖 Fix up sample HTML syntax in doc (#22460)amp-autocomplete
📖Update amp-autocomplete md file to be more concise (#22529) ✅ Make sure amp-autocomplete example validates (#22537) Allow input tags in amp-autocomplete to have no "type" attribute. (#22470) Split amp.css to ampdoc.css & ampelement.css (#22458)amp-bind
Fix friendly embedding on amp-ad, and reenable test-amp-ad-fake.js (#22504) 🏗✨ Upgrade closure compiler to v20190513 (#22446)amp-carousel
Validator rollup (#22548) 🐛 amp-carousel: hide next/prev in type=carousel for screen readers (#22405)amp-experiment
✨amp-experiment 1.0: Removed the "No mutations" limitation (#22395)amp-form
♻️✅ Extract `isFieldDefault` helper (#22541)amp-gwd-animation
Fix friendly embedding on amp-ad, and reenable test-amp-ad-fake.js (#22504) 🏗✨ Upgrade closure compiler to v20190513 (#22446)amp-lightbox-gallery
✨Support lightbox gallery crop animation. (#22476) 🚀Optimize svgs used in lightbox gallery. (#22487) ♻️ Refactor lightbox controls (#22442)amp-list
Revert deferral of [src] local data render until layout (#22559) 🐛 FIX: Allow empty string as rendered template (#22503) 🏗 Use minified build for e2e tests (#22397)amp-live-list
Split amp.css to ampdoc.css & ampelement.css (#22458)amp-recaptcha-input
Split amp.css to ampdoc.css & ampelement.css (#22458)amp-sidebar
Fix sidebar opening for Firefox. (#22563)amp-story
Story render service for amp-story 0.1. (#22575) ✨Adds button when new update is available (#22519) Story page attachment dark mode. (#22505) Updating the story amp-sidebar animations. (#22495) Replacing the data-text-background-color img examples to add cats. (#22497) Split amp.css to ampdoc.css & ampelement.css (#22458) Validate and document text background color attribute for amp-story (#22472) Add animate-in-timing-function attribute to the amp-story documentation. (#22436)amp-subscriptions
✨ Support multi entitlement pingback in amp-subscriptions (#22469) 🏗✨ Upgrade closure compiler to v20190513 (#22446)amp-subscriptions-google
✨ Support multi entitlement pingback in amp-subscriptions (#22469)amp-vimeo
🐛 Fix LGTM alerts in AMP codebase (#22488)validator
Validator rollup (#22548) - cl/250386704 Revision bump for #22488 - cl/250316079 Revision bump for #22470 - cl/249558901 Revision bump for #22447 - cl/249525181 Revision bump for #22182 - cl/249465797 Revision bump for #22417 - cl/249302791 Remove non-AMP formats for carousel reference points. 🐛 Fix LGTM alerts in AMP codebase (#22488) This PR fixes a few of the security, correctness, and maintainability [issues](https://lgtm.com/projects/g/ampproject/amphtml/alerts/?mode=tree) in our code detected via static analysis from LGTM.com.Fixed:
- 3p/embedly.js
- 3p/github.js
- 3p/nameframe.max.html
- extensions/amp-vimeo/0.1/amp-vimeo.js
- src/3p-frame.js
- validator/build.py
- validator/engine/json-testutil.js
- validator/webui/build.py
- validator/webui/build.py
Left alone:
Revert "✨ Add new " (#22447)
Reverts #22417
Per #21931 (comment), we've decided not to offer a page level opt-out.
✨ Add new (#22417)
Certain experiments are will be enabled by default (eg, the new blurry image placeholders). This provides a way for publishers to opt-out of the experiment.
We considered whether to reuse the amp-experiments-opt-in
meta tag, but we found opting-out using an opt-in was confusing. This provides a more natural way.