Version: 1904170517570
Baseline: 1904091426070
- Revert "🏗 Replace
gulp-closure-compilerwithgoogle-closure-compiler(#21868) (#21879) - Remove resizable children experiment (#21877)
- 🏗 Replace
gulp-closure-compilerwithgoogle-closure-compiler(#21868) - 📦 Update dependency karma to v4.1.0 (#21859)
- 📦 Update dependency babel-plugin-istanbul to v5.1.2 (#21869)
- 📦 Update dependency tempy to v0.3.0 (#21871)
- ✨ Add support for "error" param for amp-viewer-assistance.updateActionState (#21805)
- Add explicity
--unitto automated tests that run on--local-changes(#21851) - 📦 Update dependency gzip-size to v5.1.0 (#21850)
- 📦 Update dependency @octokit/rest to v16.24.1 (#21847)
- 📦 Update dependency @ampproject/worker-dom to v0.9.0 (#21836)
- add single pass experiment IDs when needed. (#21824)
- 📦 Update dependency mocha to v6.1.3 (#21833)
- 📦 Update dependency babel-plugin-filter-imports to v3 (#21840)
- Update flaky integration test on amp-list (#21831)
- 📦 Update dependency acorn-globals to v4.3.1 (#21841)
- 📦 Update dependency jest to v24.7.1 (#21668)
- SwG Release 0.1.22.49 (#21825)
- 📦 Update dependency html-minifier to v4 (#21659)
- 📦 Update dependency typescript to v3.4.3 (#21494)
- 📦 Update dependency sinon to v7.3.1 (#21501)
- 📦 Update dependency ava to v1.4.1 (#21557)
- 📦 Update dependency eslint-plugin-jsdoc to v4.8.3 (#21587)
- 📦 Update dependency eslint to v5.16.0 (#21648)
- 📦 Update dependency commander to v2.20.0 (#21690)
- 📦 Update dependency mocha to v6.1.2 (#21756)
- 🐛 Fix Source maps (#21818)
- Revert third_party/subscriptions-project/ files for Closure upgrade (#21827)
- Validator Rollup (#21823)
- 🏗 Change disconnect / no activity timeouts for Sauce Labs (#21822)
- Validator Rollup (#21810)
- 🏗 Clear node require cache when running E2E tests (#21779)
- 📦 Update dependency autoprefixer to v9.5.1 (#21259)
- 📦 Update dependency @octokit/rest to v16.23.4 (#21506)
- 📦 Update dependency cli-highlight to v2.1.0 (#21547)
- ✨Avoid rewriting href with multiple extensions (#21770)
- ✅ Skip
inaboxtests on Windows, not just Edge (#21814) - ✅ Skip
amp-scripttests on Windows (Edge, Firefox, and Chrome) (#21813) - ✅ Skip some tests that fail on Edge now that we're running tests on the browser (#21812)
- ✨ SVK-Native Ads. Network integration (#21713)
- 📦 Update dependency del to v4.1.0 (#21652)
- 📦 Update dependency bluebird to v3.5.4 (#21694)
- 📦 Update dependency codecov to v3.3.0 (#21695)
- 🏗 Add lint rule to enforce that e2e test
expectsareawaited (#21801) - ✨🏗 Upgrade closure compiler to v20190301 (#21618)
- 📦 Update dependency nodemon to v1.18.11 (#21765)
- 📦 Update dependency @ampproject/worker-dom to v0.8.0 (#21784)
- ✅ Skip amp-list e2e tests for now (#21798)
- object-fit and object-position attributes for amp-img, amp-video, and amp-anim. (#21747)
- Skip AMP Video failing HTTP test. (#21775)
- 🏗 Reenable Edge and Chrome on Remote Tests (Sauce Labs) job (#21796)
- ✅ Convert skipped amp-bind integration tests to e2e tests (#21789)
- Additional message in validation pass to follow up with CORS testing (#21313)
- ✨ Allowing custom scope for SW in (#21702)
Breakdown by component
ads
✨ SVK-Native Ads. Network integration (#21713)amp-a4a
add single pass experiment IDs when needed. (#21824)amp-ad
✨ SVK-Native Ads. Network integration (#21713)amp-ad-network-adsense-impl
add single pass experiment IDs when needed. (#21824)amp-ad-network-doubleclick-impl
add single pass experiment IDs when needed. (#21824)amp-analytics
🐛 Fix Source maps (#21818)amp-anim
object-fit and object-position attributes for amp-img, amp-video, and amp-anim. (#21747)amp-bind
✨ Add support for "error" param for amp-viewer-assistance.updateActionState (#21805)amp-img
object-fit and object-position attributes for amp-img, amp-video, and amp-anim. (#21747)amp-link-rewriter
✨Avoid rewriting href with multiple extensions (#21770)amp-list
Update docs for amp-list to indicate that load-more is out of experimental (#21842) ✨ Add support for "error" param for amp-viewer-assistance.updateActionState (#21805) Update flaky integration test on amp-list (#21831) ✅ Skip amp-list e2e tests for now (#21798)amp-recaptcha-input
🐛 Fix Source maps (#21818)amp-script
✅ Skip `amp-script` tests on Windows (Edge, Firefox, and Chrome) (#21813)amp-sidebar
📖 Fix sidebar for stories side documentation (#21793)amp-skimlinks
✨Avoid rewriting href with multiple extensions (#21770)amp-smartlinks
✨Avoid rewriting href with multiple extensions (#21770)amp-subscriptions-google
SwG Release 0.1.22.49 (#21825)amp-video
object-fit and object-position attributes for amp-img, amp-video, and amp-anim. (#21747) Skip AMP Video failing HTTP test. (#21775)amp-viewer-assistance
✨ Add support for "error" param for amp-viewer-assistance.updateActionState (#21805)amp-web-push
✨ Allowing custom scope for SW in (#21702)validator
Validator Rollup (#21823) Revision bump for #21747Validator Rollup (#21810)
- cl/242712441 Revision bump for #21764
object-fit and object-position attributes for amp-img, amp-video, and amp-anim. (#21747)
This PR introduces a helper that retrieves theobject-fitandobject-positionattributes of the element (ie:<amp-img>), and if they exist, sets inline styles on the childElement (ie:<img>). These inline styles are not marked as!important, so they can still be overridden by AMP extensions CSS if needed.
It gives better control to publishers over how their assets are displayed, by making it easier to select what part of the image should always be visible, or how the image should fit its container.
This helper is used for amp-img, amp-video, and amp-anim.
These styles are added right before the child element is appended to the DOM, so assets are rendered with the expected positions.
Since publishers have to explicitly write these attributes, this is not a breaking change. However, if they decide to use these attributes, it will likely override their existing CSS, because the specificity of inline styles is hard to top.